From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 8DECD93F8 for ; Wed, 21 Oct 2015 13:54:21 +0200 (CEST) Received: by wicfv8 with SMTP id fv8so71140185wic.0 for ; Wed, 21 Oct 2015 04:54:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xrgcQJ8nnGPGhMuAchrMGq+8LxRQu+/Or5DywO299Gg=; b=R6PJ/cCSURfEqeMzMZBQX60dAHsHJ8c1tkgjEyEmbSqipxvQXBjjujFYnKnEelbtL+ 6CeWXBcQBxQvZt3a+pNPxhB4v+zTZgwUfjIgONtbr1Owg42aLWJK5++txUf1eP5rN12G WP6fP+g5ajmF8N02vqPkHyfYm5J/GjrhGNqR9MjS7eEUdBGAHcoVYil8gaHYnNfr+J86 kzBCPwdhUlQJE5ia4MOoor9nqJ/8iuUyhSUx1Egd+/UMc0YFSyw4fiyW00/0UDX+o3Ug GQUujjhoy01ai1o95FYpF1Le/IbGZWpeP0ZagguZPGx1xSlzOOvTr3v7wVlJlaAstuoV pHYA== X-Gm-Message-State: ALoCoQniY90RwALUPTBUsbg2PAf1IrnDkpeC88U4vxne6Li9s/UPRA3/JAQVxzknv/H0FfHzrBO8 X-Received: by 10.180.93.133 with SMTP id cu5mr31671293wib.49.1445428461382; Wed, 21 Oct 2015 04:54:21 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id p18sm1837147wik.21.2015.10.21.04.54.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 04:54:20 -0700 (PDT) From: Thomas Monjalon To: David Marchand , Panu Matilainen Date: Wed, 21 Oct 2015 13:53:16 +0200 Message-ID: <3136074.xcMQgt4DKX@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151021111520.GA21768@bricha3-MOBL3> References: <20151021111520.GA21768@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 11:54:21 -0000 2015-10-21 12:15, Bruce Richardson: > On Wed, Oct 21, 2015 at 01:09:24PM +0200, David Marchand wrote: > > On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen > > wrote: > > > > > > Btw, returning an error here would change current behavior of dpdk loading > > >> drivers. > > >> Not sure we want this as people may rely on this loading not failing. > > >> > > > > > > Yeah, dpdk currently doesn't fail if you pass garbage to -d, which is > > > actually fairly questionable behavior. Why would you load drivers with -d > > > if you dont care about them getting loaded? Well, maybe to handle an > > > "everything" case but that's much better handled with the driver directory > > > thing. > > > > > > So actually the current patches make things a bit inconsistent, why should > > > driver directories cause a failure if individual drivers do not? The > > > question is, which behavior is the one people want: I personally would > > > rather make -dgiddy.goo fail rather than just warn and chug away but its > > > not exactly a deal-breaker for me. > > > > > > > Neither to me. > > I agree on the principle of failing when passing wrong stuff, it is saner. > > I just want to make sure nobody complains about this change later. > > > > Thomas ? Bruce ? > > Error early rather than later. If the -d flag doesn't work crash then, rather > than leaving people having to scroll-back to find why their NIC isn't working. Yes, no reason to ignore errors.