From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API
Date: Tue, 22 May 2018 14:12:36 +0200 [thread overview]
Message-ID: <313c5cfe-f3d1-5003-48fa-271b6b29ec15@redhat.com> (raw)
In-Reply-To: <20180522120937.GA26211@debian>
On 05/22/2018 02:09 PM, Tiwei Bie wrote:
> On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote:
>> On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote:
>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>> ---
>>> drivers/net/vhost/rte_eth_vhost.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
>>> index f473bbbb3..aadb2327c 100644
>>> --- a/drivers/net/vhost/rte_eth_vhost.c
>>> +++ b/drivers/net/vhost/rte_eth_vhost.c
>>> @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
>>> struct pmd_internal *internal = dev->data->dev_private;
>>> const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
>>>
>>> - internal->vlan_strip = rxmode->hw_vlan_strip;
>>> + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);
>>>
>>> - if (rxmode->hw_vlan_filter)
>>> + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
>>> VHOST_LOG(WARNING,
>>> "vhost(%s): vlan filtering not available\n",
>>> internal->dev_name);
>>
>> To better align with the new offload API, I think we
>> also need to announce those features in dev_infos_get.
I'm looking at it, and agree we have to announce support for these
offload features.
> I mean offloads (I'm too used to say features recently...).
> Besides, maybe we can also take this chance to announce the
> DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think?
Yes, and also DEV_TX_OFFLOAD_VLANiINSERT. Right?
> Best regards,
> Tiwei Bie
>
next prev parent reply other threads:[~2018-05-22 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 11:36 Maxime Coquelin
2018-05-22 11:41 ` Ferruh Yigit
2018-05-22 11:49 ` Ferruh Yigit
2018-05-22 12:34 ` Ferruh Yigit
2018-05-22 11:53 ` Tiwei Bie
2018-05-22 12:09 ` Tiwei Bie
2018-05-22 12:12 ` Maxime Coquelin [this message]
2018-05-22 12:16 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313c5cfe-f3d1-5003-48fa-271b6b29ec15@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).