From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C3C7A00C2; Thu, 5 Jan 2023 10:04:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82BB7400D4; Thu, 5 Jan 2023 10:04:50 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 6AB5040041 for ; Thu, 5 Jan 2023 10:04:49 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 09E805C020B; Thu, 5 Jan 2023 04:04:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 05 Jan 2023 04:04:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672909489; x= 1672995889; bh=MtkmrE4urjR2ZA5xhSNzZWyDRFi8LHSwObAvqx5Mikc=; b=K i3V0MtNcV9PBMEH/ByHT1gS3r3uEzhYW5ldp751tqSW3Yij/Y5Xfz7TfnlRFa38k Uc9DB8KHPVIP43iaj0fbLm1nDlUucVXxYGY/rJd9HPlQ7LZKtPG2jUwPYu7FeNsF Xj20ZoaKW6+M6Do2thKdM8AkBfKxvA5FHtcoQEGcwY22+iGwQcOfVBmWNQcJfbex zlY567sbzL3NOGfR9mB2JFK5YVKeISFwad0ivS/eR9kwDXYFnp8725sJ0ycve5CT pxhWNTGqPE+IbbwvkBEyKhe4Zo70KLx2ibI9rIgIG4bUO4HQHR9VXmP65Vz96tU1 4O3DpWEzZiBRsHgmOvf/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672909489; x= 1672995889; bh=MtkmrE4urjR2ZA5xhSNzZWyDRFi8LHSwObAvqx5Mikc=; b=w Gr0dlvY5HIx4zKdSmKGOtGT/sylj/2/ElA2d+JIPHkIUM3SzLeOx8WUjzsNsBJgi qzrwbFFzYHFWSOzDMcG/bn3869tWr93AdlWkIAD01AQ3N4j1pny+FS5AR4vSuGd3 5VYnQ+J+aYowioqn1NcI6Lh2+CMVXEz0vvyFjGFcUT2lxiOGqJAbkqhLwcW4NmtE cvpI4KqsuaF1NHukWn7JFH3mG0KPnTAEydj1lHHRScf4SLuCHpQVUTMzyHwJWf4L XVaAGpZgzNWxq6QFTGDW4Tn4bZD3BZAv7B4lYAWlAAr5s8EfcjF7FQ5E8KahclZl Fu9Dj0bfGUPxY4+T2Fu4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeejgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Jan 2023 04:04:48 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= , dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction Date: Thu, 05 Jan 2023 10:04:46 +0100 Message-ID: <3140231.5fSG56mABF@thomas> In-Reply-To: <20221128172756.GC28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87520@smartserver.smartshare.dk> <20221128172756.GC28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/11/2022 18:27, Tyler Retzlaff: > On Mon, Nov 28, 2022 at 06:22:10PM +0100, Morten Br=F8rup wrote: > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > Sent: Monday, 28 November 2022 18.14 > > >=20 > > > On Thu, Nov 24, 2022 at 11:17:23AM +0100, Morten Br=F8rup wrote: > > > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > > > Sent: Thursday, 24 November 2022 00.43 > > > > > > > > > > Provide an abstraction for leading and trailing zero bit counting > > > > > functions to hide compiler specific intrinsics and builtins. > > > > > > > > > > Signed-off-by: Tyler Retzlaff > > >=20 > > > let me unpack what is being asked for here. > > >=20 > > > > Related functions already exist in lib/eal/include/rte_common.h. > > >=20 > > > i don't understand. are you saying these inline functions duplicate > > > existing bit counting functionality? if so i'll relocate any you > > > identify. > >=20 > > Sorry about not being clear about my intentions with the feedback. > >=20 > > I'm not asking for anything; I only wanted to point at the similar fami= ly of functions in rte_common.h, to make sure that you were aware of them. >=20 > oh! not a problem. i'm very keen to catch any mistakes, thought i had > missed something. I think we should move all bit-related functions together. Please could you add another patch to your series moving "ms1b"/"bsf"/"fls" functions in this file?