Re: [dpdk-dev] [PATCH v6 2/2] testpmd: add mode 4 support v6

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-11-26 11:17, Michal Jastrzebski:
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -254,8 +254,17 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
>  	 */
>  	nb_rx = rte_eth_rx_burst(fs->rx_port, fs->rx_queue, pkts_burst,
>  				 nb_pkt_per_burst);
> +#ifndef RTE_LIBRTE_PMD_BOND
>  	if (unlikely(nb_rx == 0))
>  		return;
> +#else
> +	if (unlikely(nb_rx == 0 && (fs->forward_timeout == 0 ||
> +			fs->next_forward_time > rte_rdtsc())))
> +		return;
> +
> +	if (fs->forward_timeout != 0)
> +		fs->next_forward_time = rte_rdtsc() + fs->forward_timeout;
> +#endif

I don't understand why you need to make such change for bonding,
and there is no comment to explain.
Bonding should be a PMD like any other and shouldn't require such change.
I don't know mode 4 but it seems there is a design problem here.

-- 
Thomas