From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 01D65231C for ; Wed, 26 Nov 2014 13:20:40 +0100 (CET) Received: by mail-wg0-f44.google.com with SMTP id b13so3575325wgh.17 for ; Wed, 26 Nov 2014 04:31:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9z5U6ALBP6U+/Sgp4EUPQfXpfy39NzNZc27jpB7JrEk=; b=Ree21UaEyXUwsZtmuELTFY3iw0p38bF8Zi35wUn/WzNHznMsCJjBJsemZDVGUNV/xK mboD7mEV8LZ0wSvKw9lEJRfiQkwyPIin4uPw2Nna5LZQ9JJoqlSi9IlLSPAE/PJxmcFv 9KD7UZtP/v5004NT0HbbBcdkmOMpPw5bdiupMORZS2iVdtr7aIGMS34fwOlF/a+F/Ake 8/TrbJdQ4Rhfy1kurXUeO+QJUMHclurSO8YA68YBOUYcHpCBdGd6yPlDHFSC9hVMUd/x v+aNSgav4OuwJdpBZ5hMYnqmZp1LEwVvg0BobpAvdAsH1sHmwDODSsl7rOy/ZQRdHcLj BBVQ== X-Gm-Message-State: ALoCoQmrkciKqJdZQO6U9lQVLK039bcF7/BDXgzRYSFpkvmp4u2fLW6JBQXyj1HNeGkteVwBxnwJ X-Received: by 10.194.52.36 with SMTP id q4mr2938006wjo.114.1417005096692; Wed, 26 Nov 2014 04:31:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id n8sm6209866wjx.0.2014.11.26.04.31.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2014 04:31:35 -0800 (PST) From: Thomas Monjalon To: Michal Jastrzebski Date: Wed, 26 Nov 2014 13:31:11 +0100 Message-ID: <3141494.bx8cpoIdIi@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1417000643-26885-3-git-send-email-michalx.k.jastrzebski@intel.com> References: <1417000643-26885-1-git-send-email-michalx.k.jastrzebski@intel.com> <1417000643-26885-3-git-send-email-michalx.k.jastrzebski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 2/2] testpmd: add mode 4 support v6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2014 12:20:40 -0000 2014-11-26 11:17, Michal Jastrzebski: > From: Pawel Wodkowski > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -254,8 +254,17 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > */ > nb_rx = rte_eth_rx_burst(fs->rx_port, fs->rx_queue, pkts_burst, > nb_pkt_per_burst); > +#ifndef RTE_LIBRTE_PMD_BOND > if (unlikely(nb_rx == 0)) > return; > +#else > + if (unlikely(nb_rx == 0 && (fs->forward_timeout == 0 || > + fs->next_forward_time > rte_rdtsc()))) > + return; > + > + if (fs->forward_timeout != 0) > + fs->next_forward_time = rte_rdtsc() + fs->forward_timeout; > +#endif I don't understand why you need to make such change for bonding, and there is no comment to explain. Bonding should be a PMD like any other and shouldn't require such change. I don't know mode 4 but it seems there is a design problem here. -- Thomas