From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 91EC614EC; Thu, 17 Jan 2019 22:41:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8B6D610FE; Thu, 17 Jan 2019 16:41:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 16:41:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=fWxaGALObtIoSMfSp5JY7RZIFELoCGV9aC2xQNqjTRA=; b=HeC4pZxFIJsq RFqVRVjQ44OOfLBfjuoCsrOwgavE7wg+RxJqeDuKCY+ve4cvGtKtttaLbB4RHuo+ io8dZDJ3e4giWpx0Zu+yJECyd08Wk6Vb5K1MQUjQ2DJCK+mMZPtOSK7LBWhQfJHQ DvxjCBg/QKtutS4ligPl+YUrKG2FqfI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fWxaGALObtIoSMfSp5JY7RZIFELoCGV9aC2xQNqjT RA=; b=AushPP3DVbpH8SEyu17izVQps1sBDIuFiR6ZE0wIQALIztHi1QBbCols1 yygaV0HSSOV7XiCDrb0qWF3aZqEUO6C6qw39aVyJY+t/+vD0DEWQUYwdJQh7dRSj HodyYw6SOGKtb7kiRMp7PoGvYA4V5OXPhr25zfnlMGzlw8gc6EVGFjaylfPS4chc lskVl99xjAZQnJLIsyN/qmNJGxSud/XQ8NIXnDT3G7ThP93c7bbQBNGJI9svkKwi DqmZWij2qVi2CXFZDMZfEdZM9fk6ndSF62cQFcmBdMnNO8kiCORMGtFPa2/XILMU moWokW7VFUgUAwZ7c9xS51mtKs2hQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 10163100E5; Thu, 17 Jan 2019 16:41:12 -0500 (EST) From: Thomas Monjalon To: "Hu, Jiayu" Cc: dev@dpdk.org, "Ananyev, Konstantin" , "stable@dpdk.org" Date: Thu, 17 Jan 2019 22:41:11 +0100 Message-ID: <3141903.1XLmcNQKVu@xps> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D9047CF@irsmsx105.ger.corp.intel.com> References: <1547132768-2384-1-git-send-email-jiayu.hu@intel.com> <1547599533-124469-1-git-send-email-jiayu.hu@intel.com> <2601191342CEEE43887BDE71AB977258010D9047CF@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] gro: add missing invalid TCP header length check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 21:41:15 -0000 16/01/2019 10:49, Ananyev, Konstantin: > From: Hu, Jiayu > > > > When the TCP header length of input packets is invalid (i.e., less > > than 20 bytes or greater than 60 bytes), check_seq_option() will > > access illegal memory area when compare TCP Options, which may > > cause a segmentation fault. > > > > This patch adds missing invalid TCP header length check to avoid > > illegal memory accesses. > > > > Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") > > Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jiayu Hu > > Tested-by: Yinan Wang > > Acked-by: Konstantin Ananyev Applied, thanks