From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] default unicast mac address - was: add multicast address filtering
Date: Fri, 29 May 2015 15:12:28 +0200 [thread overview]
Message-ID: <3149965.63Z4QvtXnx@xps13> (raw)
In-Reply-To: <20150528092256.292e566c@urahara>
Hi Stephen,
Looking at mac address management, you and Changchun added an entry in
driver ops to be able to change the default mac address with virtio:
http://dpdk.org/browse/dpdk/commit/?id=5186fb1f37fe986
Other ops functions (mac_addr_add/remove) manage the secondary unicast
mac addresses and have a wrapper function in the API:
http://dpdk.org/doc/api/rte__ethdev_8h.html#aa2b81750086f5f9e55cf65e5cf9f2c58
It seems now that the review of the above patch was too weak and I'd like
these issues to be fixed:
- mac_addr_set must be wrapped by rte_eth_dev_mac_addr_set()
- eth_mac_addr_set_t must be fixed to explicitly state that it
replaces the default address
I'm wondering what was the first intent since virtio_mac_addr_set() is
never called?
next prev parent reply other threads:[~2015-05-29 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 15:05 [dpdk-dev] [PATCH 0/5] " Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 1/5] ethdev: add " Ivan Boule
2015-05-28 16:22 ` Stephen Hemminger
2015-05-29 7:52 ` Ivan Boule
2015-05-29 8:56 ` [dpdk-dev] [PATCH v2 " Ivan Boule
2015-05-29 13:12 ` Thomas Monjalon [this message]
2015-05-29 15:18 ` [dpdk-dev] default unicast mac address - was: " Stephen Hemminger
2015-05-28 15:05 ` [dpdk-dev] [PATCH 2/5] app/testpmd: new command to add/remove multicast MAC addresses Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 3/5] e1000: add multicast MAC address filtering Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 4/5] ixgbe: " Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 5/5] app/testpmd: fix reply to a multicast ICMP request Ivan Boule
2015-05-28 16:21 ` [dpdk-dev] [PATCH 0/5] multicast address filtering Stephen Hemminger
2015-05-29 9:33 ` Ivan Boule
2015-05-29 15:17 ` Stephen Hemminger
2015-06-12 13:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3149965.63Z4QvtXnx@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).