From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id C85D35A57
 for <dev@dpdk.org>; Fri, 29 May 2015 15:13:19 +0200 (CEST)
Received: by wicmx19 with SMTP id mx19so17283972wic.0
 for <dev@dpdk.org>; Fri, 29 May 2015 06:13:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=/0ONq9avtDL36cB+c/yAH2Zv2zIP6A/CpCgWszSWNWM=;
 b=MgybqIYDPUB6cxOOHLpB60DbgJqH362ZdGpvFEctwqVY8itK5IZqXyvZGC5ONxZRxb
 KajoY+GFPHfYdMghUnY89Q5/V1fT/HbjEjEKuvnEeqkWx/SM+Je9rwh0bT0CcDj2cT+o
 NF7SOCLOnrtTyrGWA/0isjdaIJWeHYjRM5VG/NvhOFyDPb4ogRzx6BJe0ts3D3oaTxcB
 yYYH/aWAacM4OCmOGeagbGAjL6XOfCjqQlxevHZpzY5YxP2TejIbHucim6EMnYBS6/Ys
 qp4uG5qHUk+usDWZaxrT3wAKQJkCpT31Dktf8B+TbgGuFDQAsm96xD4fyQVrkI2UXuzv
 /gJQ==
X-Gm-Message-State: ALoCoQnWP9/dkaxFS3jGKP92zk7rWPnSC9Z16Uv5NnTBXBs5TkKiUcXSXXmYgEBBi7YYbGz6Ja0E
X-Received: by 10.181.11.193 with SMTP id ek1mr6389379wid.15.1432905199654;
 Fri, 29 May 2015 06:13:19 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id uc9sm8323607wjc.7.2015.05.29.06.13.18
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 29 May 2015 06:13:18 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 29 May 2015 15:12:28 +0200
Message-ID: <3149965.63Z4QvtXnx@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <20150528092256.292e566c@urahara>
References: <1432825523-19006-1-git-send-email-ivan.boule@6wind.com>
 <1432825523-19006-2-git-send-email-ivan.boule@6wind.com>
 <20150528092256.292e566c@urahara>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] default unicast mac address - was: add multicast
	address filtering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2015 13:13:20 -0000

Hi Stephen,

Looking at mac address management, you and Changchun added an entry in
driver ops to be able to change the default mac address with virtio:
	http://dpdk.org/browse/dpdk/commit/?id=5186fb1f37fe986
Other ops functions (mac_addr_add/remove) manage the secondary unicast
mac addresses and have a wrapper function in the API:
	http://dpdk.org/doc/api/rte__ethdev_8h.html#aa2b81750086f5f9e55cf65e5cf9f2c58

It seems now that the review of the above patch was too weak and I'd like
these issues to be fixed:
	- mac_addr_set must be wrapped by rte_eth_dev_mac_addr_set()
	- eth_mac_addr_set_t must be fixed to explicitly state that it
replaces the default address

I'm wondering what was the first intent since virtio_mac_addr_set() is
never called?