From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D95745BB4;
	Wed, 23 Oct 2024 18:00:54 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2CC6F40613;
	Wed, 23 Oct 2024 18:00:54 +0200 (CEST)
Received: from fhigh-b4-smtp.messagingengine.com
 (fhigh-b4-smtp.messagingengine.com [202.12.124.155])
 by mails.dpdk.org (Postfix) with ESMTP id 3CDAB402DF
 for <dev@dpdk.org>; Wed, 23 Oct 2024 18:00:53 +0200 (CEST)
Received: from phl-compute-12.internal (phl-compute-12.phl.internal
 [10.202.2.52])
 by mailfhigh.stl.internal (Postfix) with ESMTP id 1E6412540109;
 Wed, 23 Oct 2024 12:00:52 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
 by phl-compute-12.internal (MEProxy); Wed, 23 Oct 2024 12:00:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm3; t=1729699251;
 x=1729785651; bh=GGgvWpnd82cWu+fORzyu43nWFF6wFW20ndZeHDZhYnU=; b=
 iVe8COXbkD+3tJbXqGx6akGF4fWW0BNDA6VMNItoQO+Qhmks+uwqxmdkM0q0Jkuj
 gkwH2nFJAeWt4uQL4gmZl1DuV4CcN1mIGfNLVj8Fx8UctsyOd5zBYgiRq8vbuoLq
 djKddzGQl0ySdR7u0fwIr+9h4xd615eHh28zkvXUhAn+s1r9cJiBLN+Za93H3n60
 nuEHNrGh9Qb5IsK5vgphTX+jRA2tGRKkD+pedy4HIQS3pp8+J8M+xuK59Bsk9Ln8
 8jTvNmqiYKIjlT8swZbgbuz2j/fAPRXD3aI21FM0YHTfoGtawHIqK3ONj8vPY4Ri
 8ae4ZvjyKPQIm9WzXe1LAA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729699251; x=
 1729785651; bh=GGgvWpnd82cWu+fORzyu43nWFF6wFW20ndZeHDZhYnU=; b=c
 /cxNxhlqePbsF68cfYyWsY8NDGodL+Xki3pZ3PqHUhppnu7ukb7g2rKbqSWSH5sZ
 5Z4/cjcTNoun+NJsntPEeCl8nxALcPOuGV7A9aa9dnpx3+INwVcvjFKsWfrNuzqV
 qlIqY39MaKiIqJe19xmkt/4ePxfLkLR0489RGFzpTkQNvMWIGl9AWH7cN+WnU07d
 6WMXEIXmJ30Uu6dUlGSk20LNZ77NYEsC50RKWFC0I0db8LdXGVgVx79E8pYnkZKY
 J986cqaQE6Eyc9SQiQjk96SJ5kztxCz3O9oBqC9FnNS6zDwAD8NH6iIoUuGlub0w
 3bR0vTFcz8fvTUZ2pYm8w==
X-ME-Sender: <xms:sx0ZZx2HkcXhuNznMxZX_pcsYEMpvD9WuZp4MEkRXYjc7ESSxSprgg>
 <xme:sx0ZZ4GxDNt2Pb17-ebjtMvV5ZeAHsvotykf1n-0Cv7VghiSW1o1Fhty8R0q_2Ur2
 volzFYJBxee1g_RbQ>
X-ME-Received: <xmr:sx0ZZx7SLSRvvQBoQ6VsCKeIag_Trw_vy6SMUZAt_j3BPu2npMed4LDwuzcVEnwvaY539_GN6dUKivjOq8W9wIHh_w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeijedgleefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
 rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
 htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen
 ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg
 hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt
 heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf
 grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn
 sggprhgtphhtthhopeduuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghgrkh
 hhihhlsehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtohepuggrvhhiugdrmhgrrhgthhgr
 nhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprh
 gtphhtthhopehjvghrihhnjhgrtghosghksehgmhgrihhlrdgtohhmpdhrtghpthhtohep
 jhgvrhhinhhjsehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtohephhhkrghlrhgrsehmrg
 hrvhgvlhhlrdgtohhmpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplhhu
 mhgsvghrrdhorhhgpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughssehinhhtvg
 hlrdgtohhmpdhrtghpthhtohephhgvmhgrnhhtrdgrghhrrgifrghlsehngihprdgtohhm
X-ME-Proxy: <xmx:sx0ZZ-3W1I7O68nJA-t7y6uEMd9_cqEEQHBLwQzZ030lpT5tv_BlTw>
 <xmx:sx0ZZ0E1eO604gdog_IhaqZXrNFOnRC8pfewnxzzzhIi_yuRfDCjCw>
 <xmx:sx0ZZ_-u2X--cuSFlVD8WlEU6C_uqrmD1UhG5jsbU3GnVT3Wa-uUrA>
 <xmx:sx0ZZxkumuo_vWihVPo-x1KdLD6aShn9xThdhQc772ZjeaOHgn3Mqw>
 <xmx:sx0ZZ39_xVP5VD1dQ3gr4htc39RLPNEwSBWEMzd7eDJl_2n7f455z5qE>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 23 Oct 2024 12:00:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
 Jerin Jacob <jerinjacobk@gmail.com>, Jerin Jacob <jerinj@marvell.com>,
 Harman Kalra <hkalra@marvell.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Bruce Richardson <bruce.richards@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>,
 Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get
 BAR addresses
Date: Wed, 23 Oct 2024 18:00:47 +0200
Message-ID: <3152317.f0I1acK8xe@thomas>
In-Reply-To: <PH0PR18MB4491DA064F770FA3FAD4593DD84C2@PH0PR18MB4491.namprd18.prod.outlook.com>
References: <20241008105415.1026962-1-gakhil@marvell.com>
 <CAJFAV8wB5mH6OtdzRj+xWv0OzFP_D4N61oZckimPEdy6Raj6gg@mail.gmail.com>
 <PH0PR18MB4491DA064F770FA3FAD4593DD84C2@PH0PR18MB4491.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

22/10/2024 14:06, Akhil Goyal:
> > On Tue, Oct 22, 2024 at 8:06=E2=80=AFAM Akhil Goyal <gakhil@marvell.com=
> wrote:
> > > > The rational to NOT pull "Hardware abstraction library using the BAR
> > > > address" to DPDK are
> > > > -Yet another 200K of driver C++ code which does not make sense to k=
eep
> > > > in dpdk.org
> > > > -It can not implemenent any of the current subsystems
> > > >
> > > > In this context, let me know what you think?
> >=20
> > This hardware abstraction library will have to call some driver
> > specific API (like the added raw/cnxk_rvu API).
> > Can this library directly use the PCI driver API, and call the cnxk
> > common driver?
> > If so, there is no need to add another driver API (that breaks
> > layers), and the rawdev driver is only about adding the mailbox
> > features.
>=20
> cnxk  common has a lot of internal APIs which
> we do not want to expose directly to application.

Actually the target is an out-of-tree driver, not an application.

> It seems the only contentious API is to get the BAR addresses.
> All other APIs seems to be fine. Right?

Interrupt management is also something we would like to see reserved to dri=
vers.

> If so, we can remove that API and get the bar addresses as you suggested =
below.
> rte_rawdev_info_get() -> get rte_device -> RTE_DEV_TO_PCI -> get bar addr
>     via bus_pci_driver.h header, exported via enable_driver_sdk option

Yes please, it is better to avoid confusion between driver and application.
Any driver type layer should be exposed only when the Meson option
enable_driver_sdk is enabled.

You probably should export the interrupt functions in a separate file
through driver_sdk_headers, so it is clear it is not an application level.
Does it apply to the mailbox functions as well?

> If it is ok, I can send the next version with this change and documentati=
on update.

Yes, thanks.