From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C59A92C4F for ; Mon, 5 Dec 2016 15:52:39 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 05 Dec 2016 06:52:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,747,1477983600"; d="scan'208";a="13825077" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga002.jf.intel.com with ESMTP; 05 Dec 2016 06:52:37 -0800 To: Jingjing Wu , dev@dpdk.org References: <1480727953-92137-1-git-send-email-jingjing.wu@intel.com> <1480727953-92137-26-git-send-email-jingjing.wu@intel.com> Cc: helin.zhang@intel.com From: Ferruh Yigit Message-ID: <31541149-0a88-ea86-fd51-abfcb30ea4c9@intel.com> Date: Mon, 5 Dec 2016 14:52:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480727953-92137-26-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 25/31] net/i40e/base: remove duplicate definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 14:52:40 -0000 On 12/3/2016 1:19 AM, Jingjing Wu wrote: > We already define I40E_AQ_PHY_TYPE_EXT_25G* flags in the response adminq > structure above, and do not need to re-define these. See eee_capability > for an example where we didn't re-define these. This prevents Linux > driver from complaining about using these flags in an #ifdef when > running cppkeep tool, and generally makes more sense to avoid > duplicating the definitions. Although this is base driver and used in various platforms, mentioning from the Linux driver and cppkeep here can be confusing, what do you think removing that part? > > While we are here, replace 0X with 0x as normal style. > > Signed-off-by: Jingjing Wu > --- <...>