From: Thomas Monjalon <thomas@monjalon.net> To: Gregory Etelson <getelson@nvidia.com> Cc: orika@nvidia.com, ajit.khaparde@broadcom.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, ferruh.yigit@intel.com, jerinj@marvell.com, jerinjacobk@gmail.com, olivier.matz@6wind.com, viacheslavo@nvidia.com, matan@nvidia.com, rasland@nvidia.com Subject: Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add packet integrity checks Date: Mon, 19 Apr 2021 10:47:42 +0200 Message-ID: <3158315.YsgzKm6jbH@thomas> (raw) In-Reply-To: <20210419082908.8805-2-getelson@nvidia.com> 19/04/2021 10:29, Gregory Etelson: > +Item: ``PACKET_INTEGRITY_CHECKS`` > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > + > +Matches packet integrity. > +For some devices application needs to enable integration checks in HW > +before using this item. > + > +- ``level``: the encapsulation level that should be checked. level 0 means the > + default PMD mode (Can be inner most / outermost). value of 1 means outermost > + and higher value means inner header. See also RSS level. Would be nicer to make sub-list for levels. Please start sentences with a capital letter. > +- ``packet_ok``: All HW packet integrity checks have passed based on the max > + layer of the packet. "based on the max layer" is not clear. Do you mean all layers? > +- ``l2_ok``: all layer 2 HW integrity checks passed. > +- ``l3_ok``: all layer 3 HW integrity checks passed. > +- ``l4_ok``: all layer 4 HW integrity checks passed. > +- ``l2_crc_ok``: layer 2 crc check passed. s/crc/CRC/ > +- ``ipv4_csum_ok``: ipv4 checksum check passed. s/ipv4/IPv4/ > +- ``l4_csum_ok``: layer 4 checksum check passed. > +- ``l3_len_ok``: the layer 3 len is smaller than the frame len. s/len/length/ > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > +* **Added packet integrity match to flow rules.** > + > + * Added ``RTE_FLOW_ITEM_TYPE_INTEGRITY`` flow item. > + * Added ``rte_flow_item_integrity`` data structure. It should be moved with other ethdev changes. > + > * **Added support for Marvell CN10K SoC drivers.** > > Added Marvell CN10K SoC support. Marvell CN10K SoC are based on Octeon 10 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > + /** > + * [META] > + * > + * Matches on packet integrity. > + * For some devices application needs to enable integration checks in HW > + * before using this item. > + * > + * See struct rte_flow_item_integrity. Better to use @see syntax. > + */ > + RTE_FLOW_ITEM_TYPE_INTEGRITY, > }; > +struct rte_flow_item_integrity { > + /**< Tunnel encapsulation level the item should apply to. > + * @see rte_flow_action_rss > + */ > + uint32_t level; missing RTE_STD_C11 here for anonymous union. > + union { > + __extension__ > + struct { > + /**< The packet is valid after passing all HW checks. */ > + uint64_t packet_ok:1; > + /**< L2 layer is valid after passing all HW checks. */ > + uint64_t l2_ok:1; > + /**< L3 layer is valid after passing all HW checks. */ > + uint64_t l3_ok:1; > + /**< L4 layer is valid after passing all HW checks. */ > + uint64_t l4_ok:1; > + /**< L2 layer CRC is valid. */ > + uint64_t l2_crc_ok:1; > + /**< IPv4 layer checksum is valid. */ > + uint64_t ipv4_csum_ok:1; > + /**< L4 layer checksum is valid. */ > + uint64_t l4_csum_ok:1; > + /**< The l3 length is smaller than the frame length. */ > + uint64_t l3_len_ok:1; > + uint64_t reserved:56; > + }; > + uint64_t value; > + }; > +};
next prev parent reply other threads:[~2021-04-19 8:47 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-05 18:04 [dpdk-dev] [PATCH] " Ori Kam 2021-04-06 7:39 ` Jerin Jacob 2021-04-07 10:32 ` Ori Kam 2021-04-07 11:01 ` Jerin Jacob 2021-04-07 22:15 ` Ori Kam 2021-04-08 7:44 ` Jerin Jacob 2021-04-11 4:12 ` Ajit Khaparde 2021-04-11 6:03 ` Ori Kam 2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 0/2] " Gregory Etelson 2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 1/2] ethdev: " Gregory Etelson 2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-13 17:15 ` Ferruh Yigit 2021-04-14 12:56 ` [dpdk-dev] [PATCH v4 0/2] add packet integrity checks Gregory Etelson 2021-04-14 12:56 ` [dpdk-dev] [PATCH v4 1/2] ethdev: " Gregory Etelson 2021-04-14 13:27 ` Ferruh Yigit 2021-04-14 13:31 ` Ferruh Yigit 2021-04-14 12:57 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 0/2] add packet integrity checks Gregory Etelson 2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 1/2] ethdev: " Gregory Etelson 2021-04-14 17:24 ` Ajit Khaparde 2021-04-15 15:10 ` Ori Kam 2021-04-15 15:25 ` Ajit Khaparde 2021-04-15 16:46 ` Thomas Monjalon 2021-04-16 7:43 ` Ori Kam 2021-04-18 8:15 ` Gregory Etelson 2021-04-18 18:00 ` Thomas Monjalon 2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-14 16:26 ` [dpdk-dev] [PATCH v5 0/2] add packet integrity checks Ferruh Yigit 2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 " Gregory Etelson 2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 1/2] ethdev: " Gregory Etelson 2021-04-18 18:11 ` Thomas Monjalon 2021-04-18 19:24 ` Gregory Etelson 2021-04-18 21:30 ` Thomas Monjalon 2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 0/2] add packet integrity checks Gregory Etelson 2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 1/2] ethdev: " Gregory Etelson 2021-04-19 8:47 ` Thomas Monjalon [this message] 2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-19 11:20 ` [dpdk-dev] [PATCH v7 0/2] add packet integrity checks Ferruh Yigit 2021-04-19 12:08 ` Gregory Etelson 2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 " Gregory Etelson 2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 1/2] ethdev: " Gregory Etelson 2021-04-19 14:09 ` Ajit Khaparde 2021-04-19 16:34 ` Thomas Monjalon 2021-04-19 17:06 ` Ferruh Yigit 2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-19 14:09 ` Ajit Khaparde 2021-04-08 8:04 ` [dpdk-dev] [PATCH] ethdev: add packet integrity checks Andrew Rybchenko 2021-04-08 11:39 ` Ori Kam 2021-04-09 8:08 ` Andrew Rybchenko 2021-04-11 6:42 ` Ori Kam 2021-04-11 17:30 ` Ori Kam 2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 0/2] " Gregory Etelson 2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 1/2] ethdev: " Gregory Etelson 2021-04-12 17:36 ` Ferruh Yigit 2021-04-12 19:26 ` Ori Kam 2021-04-12 23:31 ` Ferruh Yigit 2021-04-13 7:12 ` Ori Kam 2021-04-13 8:03 ` Ferruh Yigit 2021-04-13 8:18 ` Ori Kam 2021-04-13 8:30 ` Ferruh Yigit 2021-04-13 10:21 ` Ori Kam 2021-04-13 17:28 ` Ferruh Yigit 2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item Gregory Etelson 2021-04-12 17:49 ` Ferruh Yigit 2021-04-13 7:53 ` Ori Kam 2021-04-13 8:14 ` Ferruh Yigit 2021-04-13 11:36 ` Ori Kam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3158315.YsgzKm6jbH@thomas \ --to=thomas@monjalon.net \ --cc=ajit.khaparde@broadcom.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=getelson@nvidia.com \ --cc=jerinj@marvell.com \ --cc=jerinjacobk@gmail.com \ --cc=matan@nvidia.com \ --cc=olivier.matz@6wind.com \ --cc=orika@nvidia.com \ --cc=rasland@nvidia.com \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git