From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] test: fix missing NULL pointer checks
Date: Tue, 27 Jan 2015 15:42:42 +0100 [thread overview]
Message-ID: <3160954.49hHdJy1hX@xps13> (raw)
In-Reply-To: <1422368268-10068-1-git-send-email-danielx.t.mrzyglod@intel.com>
2015-01-27 15:17, Daniel Mrzyglod:
> In test_sched, we are missing NULL pointer checks after calls to create the
> mempool and to allocate an mbuf. Add in these checks using TEST_ASSERT_NOT_NULL macros.
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
[...]
> + TEST_ASSERT_NOT_NULL(mp, "Error create mempool\n");
Asked previously (http://dpdk.org/ml/archives/dev/2014-December/010392.html),
it seems to be a typo: create -> creating
Sorry to insist but I'm not an english native and it seems weird to me.
--
Thomas
prev parent reply other threads:[~2015-01-27 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 14:17 Daniel Mrzyglod
2015-01-27 14:21 ` Thomas Monjalon
2015-01-27 14:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3160954.49hHdJy1hX@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).