From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 9CC876029 for ; Tue, 27 Jan 2015 15:43:09 +0100 (CET) Received: by mail-we0-f180.google.com with SMTP id m14so15288188wev.11 for ; Tue, 27 Jan 2015 06:43:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0cJWr6x3+zyMqxWH7BnjObKf535P7zH9351YD1xaNRk=; b=Wm1TT+zIC7gELJiiUkioxQWNDMZLDuXRp2rgmFqt1meEU1ppWBdrHcjKbS6cALCc7/ LVpimMHeNZqyyuod85ODW3/sIKywL9Z44R58JP5xIh9VGId8ToJsaXFGMGjiU0g3xiiy 1kHpePY/qRCDQ6aBIsI/7Q3ChoTNrS1DIXcWqw1QMpGyaXR9ANt4fZqX/5uBS8dS7fwS +0CrwyaPEI+dl/jk5pBg8SxVlo/GHX0cmslfO+U7XB6//A0PhTqX7foWvmbE4dN3hjEU q/kSZ8JW+eXmKSxOjAb5ftMGVeLXvb9zR/EmUDvWPaN/nDE0S1xsicbCZiELpaqR3qLw JMHg== X-Gm-Message-State: ALoCoQlJzkGQ6corDqQvBWlC/hWhAynmgwa2ms6Cj2bEqzB68wOrYQPUx3qgTWQA7gKN0U/gHVnu X-Received: by 10.194.175.202 with SMTP id cc10mr504021wjc.27.1422369789327; Tue, 27 Jan 2015 06:43:09 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id d6sm2465741wic.1.2015.01.27.06.43.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 06:43:08 -0800 (PST) From: Thomas Monjalon To: Daniel Mrzyglod Date: Tue, 27 Jan 2015 15:42:42 +0100 Message-ID: <3160954.49hHdJy1hX@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1422368268-10068-1-git-send-email-danielx.t.mrzyglod@intel.com> References: <1422368268-10068-1-git-send-email-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] test: fix missing NULL pointer checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 14:43:10 -0000 2015-01-27 15:17, Daniel Mrzyglod: > In test_sched, we are missing NULL pointer checks after calls to create the > mempool and to allocate an mbuf. Add in these checks using TEST_ASSERT_NOT_NULL macros. > > Signed-off-by: Daniel Mrzyglod [...] > + TEST_ASSERT_NOT_NULL(mp, "Error create mempool\n"); Asked previously (http://dpdk.org/ml/archives/dev/2014-December/010392.html), it seems to be a typo: create -> creating Sorry to insist but I'm not an english native and it seems weird to me. -- Thomas