* [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc
@ 2022-07-06 6:55 835703180
2022-07-06 9:07 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: 835703180 @ 2022-07-06 6:55 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, Shiqi Liu
From: Shiqi Liu <835703180@qq.com>
As the possible failure of the malloc(), the not_checked and
checked could be NULL pointer.
Therefore, it should be better to check it in order to avoid
the dereference of the NULL pointer.
Fixes: b7aaf417f93 ("raw/ioat: add bus driver for device scanning automatically")
Signed-off-by: Shiqi Liu <835703180@qq.com>
---
drivers/raw/ioat/idxd_bus.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/raw/ioat/idxd_bus.c b/drivers/raw/ioat/idxd_bus.c
index 539f51b1b1..ba2bbe0f7e 100644
--- a/drivers/raw/ioat/idxd_bus.c
+++ b/drivers/raw/ioat/idxd_bus.c
@@ -301,6 +301,10 @@ dsa_scan(void)
IOAT_PMD_DEBUG("%s(): found %s/%s", __func__, path, wq->d_name);
dev = malloc(sizeof(*dev));
+ if (dev == NULL) {
+ closedir(dev_dir);
+ return -ENOMEM;
+ }
if (dsa_addr_parse(wq->d_name, &dev->addr) < 0) {
IOAT_PMD_ERR("Error parsing WQ name: %s", wq->d_name);
free(dev);
--
2.35.1.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc
2022-07-06 6:55 [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc 835703180
@ 2022-07-06 9:07 ` Bruce Richardson
2022-10-10 15:48 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2022-07-06 9:07 UTC (permalink / raw)
To: 835703180; +Cc: dev
On Wed, Jul 06, 2022 at 02:55:48PM +0800, 835703180@qq.com wrote:
> From: Shiqi Liu <835703180@qq.com>
>
> As the possible failure of the malloc(), the not_checked and
> checked could be NULL pointer.
> Therefore, it should be better to check it in order to avoid
> the dereference of the NULL pointer.
>
> Fixes: b7aaf417f93 ("raw/ioat: add bus driver for device scanning automatically")
> Signed-off-by: Shiqi Liu <835703180@qq.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc
2022-07-06 9:07 ` Bruce Richardson
@ 2022-10-10 15:48 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-10-10 15:48 UTC (permalink / raw)
To: 835703180; +Cc: dev, Bruce Richardson
06/07/2022 11:07, Bruce Richardson:
> On Wed, Jul 06, 2022 at 02:55:48PM +0800, 835703180@qq.com wrote:
> > From: Shiqi Liu <835703180@qq.com>
> >
> > As the possible failure of the malloc(), the not_checked and
> > checked could be NULL pointer.
> > Therefore, it should be better to check it in order to avoid
> > the dereference of the NULL pointer.
> >
> > Fixes: b7aaf417f93 ("raw/ioat: add bus driver for device scanning automatically")
> > Signed-off-by: Shiqi Liu <835703180@qq.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-10 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 6:55 [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc 835703180
2022-07-06 9:07 ` Bruce Richardson
2022-10-10 15:48 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).