From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 156C31BD4B for ; Fri, 21 Dec 2018 01:33:58 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7844221165; Thu, 20 Dec 2018 19:33:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 19:33:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wfkzti0xJpTEs9qH1v+3ioGWAlGZdU9MdFZh75CwNaE=; b=MFiGf3OGMV9u jX6VUy5hrjHNVx4VMXFxhiwPeQdcsNA+EsrqVCYJMzQ9GRTyi+eif34WCy4nZOej yBm8H4avmX6pUyZbE/5LdkQEuXjJVaoh0H/gDtyAgjtusSFHLwBi4FCl0dSmY2U1 GFfZMsIWeEQi8GJxhBH8o++Q/F4zrHw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Wfkzti0xJpTEs9qH1v+3ioGWAlGZdU9MdFZh75CwN aE=; b=uBNTMwVuwHB28ooeMmAxQln7R0383hKY2EcgYWelM5UX6S+g+9capoc4Q hA4SNQWU4OClp9KYXUZlxbYPwNwOvg39zmFGcsN9Q/2TVgFgfVYzf44vmjOx9g2l Ejarib+ELvjADwJHNC6lHmaGmmJN2lzjyY4OKIjy3ePVOKGSIT6u+gVEQ1KUx8Es wgGMizJMXmzHJr57/tpKAmfhaQ6zKCd5HZVFFAcDHIyLfm7bhX3wbmYqD6h9f2eU nCk8IZWKLuGKE/NnU1DGWTRUwrjC39bRhDqD5OqcZQRxA8d28B0R1Sarfk2fnofb qsNlyI9YTcWuEtX+2pYvyGQN/p2yg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejgedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C8EEE436E; Thu, 20 Dec 2018 19:33:56 -0500 (EST) From: Thomas Monjalon To: "Hunt, David" , Liang Ma Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Fri, 21 Dec 2018 01:33:52 +0100 Message-ID: <3161770.XceykbziDS@xps> In-Reply-To: <3440914.i2vn9u2s4q@xps> References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com> <546f1cd6-6f02-95ef-008a-d0885f6b53e0@intel.com> <3440914.i2vn9u2s4q@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 00:33:58 -0000 21/12/2018 01:30, Thomas Monjalon: > 20/12/2018 15:52, Hunt, David: > > On 19/12/2018 8:31 PM, Thomas Monjalon wrote: > > > 19/12/2018 10:09, Hunt, David: > > >> On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > > >>> 14/12/2018 14:11, Liang Ma: > > >>>> Previously, in order to use the power library, it was necessary > > >>>> for the user to disable the intel_pstate driver by adding > > >>>> =E2=80=9Cintel_pstate=3Ddisable=E2=80=9D to the kernel command lin= e for the system, > > >>>> which causes the acpi_cpufreq driver to be loaded in its place. > > >>>> > > >>>> This patch adds the ability for the power library use the intel-ps= tate > > >>>> driver. > > >>>> > > >>>> It adds a new suite of functions behind the current power library = API, > > >>>> and will seamlessly set up the user facing API function pointers to > > >>>> the relevant functions depending on whether the system is running = with > > >>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a gue= st, > > >>>> using kvm. The library API and ABI is unchanged. > > >>>> > > >>>> Signed-off-by: Liang Ma > > >>>> > > >>>> Reviewed-by: Anatoly Burakov > > >>>> --- > > >>> Please write a changelog when sending a new version. > > >>> > > >>> Dave, any comment on this patch? > > >> > > >> Looks good to me. > > >> > > >> Acked-by: David Hunt > > >> > > >> > > >>>> --- /dev/null > > >>>> +++ b/lib/librte_power/power_pstate_cpufreq.c > > >>>> @@ -0,0 +1,770 @@ > > >>>> +/* SPDX-License-Identifier: BSD-3-Clause > > >>>> + * Copyright(c) 2018-2018 Intel Corporation > > >>> Something wrong here :) > > >> Yes, should simply be "Copyright(c) 2018 Intel Corporation" > > > > > > There is also a compilation error with meson: > > > > > > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: > > > rte_timer.h: No such file or directory > > > > > > Clearly, some quality checks are missing. > > > > > > I'm afraid we won't have any patch for power library in 19.02. > >=20 > >=20 > > Hi Thomas, > >=20 > > We have just pushed a v4, and tested with make, meson/ninja, and severa= l=20 > > different build environments. I believe this version should be=20 > > acceptable for 19.02. >=20 > I don't think so. > I will give more comments in v4 and will give up for 19.02. Sorry I looked at the wrong things. The v4 looks OK.