From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id A7B8C9A9A
 for <dev@dpdk.org>; Sun,  8 Mar 2015 22:12:42 +0100 (CET)
Received: by wggx12 with SMTP id x12so13302462wgg.10
 for <dev@dpdk.org>; Sun, 08 Mar 2015 14:12:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=346F7hExQ5euid8nwPT8HEVy9EGFdyl0gDrZGmH1YzM=;
 b=CYZwypfwcLnlzd1PDywolG7jP9y+mEtlhZUOm9cDxGmxt0jVzO+4Qo8w/o57YBYLPG
 Tmfv6hbvWU5c00r3dxfXO0nU+tT9tsCGZEepjSmsFtuPUVbeaAbnWwIiZLsn6l7sOstY
 +6ED1HI2wATmTLdoBNIV2cOXEQECCUuXDl+xuVU7i7KJmgVlXIlSWOXsF5TyAQHGQzy3
 EpYp3S6JDbeDpXAIlUm4yZABgashfdfob3ryQ/kVuZiU82IoGc5c6TaDYJjO+xe3h/5o
 9jvlHi55CXHxTtUCW+XsHJjorcAMakFPvMbXCP8DagsxNPj7ZPspLzdk7dT43kegQg5p
 0NgQ==
X-Gm-Message-State: ALoCoQk2g4EuKx9cq27QGgWKoasCayDQ0XZBBFEv07pBwwdxD3A+7yhOOvgC/P6N8cThKT5smYgZ
X-Received: by 10.194.9.98 with SMTP id y2mr52513583wja.85.1425849162381;
 Sun, 08 Mar 2015 14:12:42 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gi9sm29341505wib.21.2015.03.08.14.12.41
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 08 Mar 2015 14:12:41 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Vlad Zolotarov <vladz@cloudius-systems.com>
Date: Sun, 08 Mar 2015 22:12:08 +0100
Message-ID: <3162156.p89LbuxRO9@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1425823498-30385-3-git-send-email-vladz@cloudius-systems.com>
References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com>
 <1425823498-30385-3-git-send-email-vladz@cloudius-systems.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx
	CRC stripping for x540 devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Mar 2015 21:12:42 -0000

Hi Vlad,

2015-03-08 16:04, Vlad Zolotarov:
> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should
> be configured to the same value as HLREG0.RXCRCSTRP.
> 
> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec
> but seems harmless.
> 
> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>

You are mixing a fix (this patch) and enhancements (LRO) in the same series.
Could you separate them please, as LRO is not going into 2.0 but this fix
is a good candidate.

Thanks