From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 955BFA0093; Fri, 11 Mar 2022 09:01:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 277CF40140; Fri, 11 Mar 2022 09:01:54 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 34F9540042; Fri, 11 Mar 2022 09:01:53 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 801485C0178; Fri, 11 Mar 2022 03:01:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 11 Mar 2022 03:01:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=Xvyun5BOsfoIER 01kilo/hp+3UyNKFIYoWwOy5dr6D0=; b=b/Ge/rFjjSRLEPtS6QDT8Q91W7HwS7 53aXpi6UjNydJo75ES5nDRIJnAe7RGMPJcxqYIfYazf+fw+HFtoMTW4pRsa9aFJI a2TbDhXGGcYrp6K+L4igoak+an8mYoD5j+mQLdSdqX9FWF+mOPKi49GQ1bvW9/To z9W4RvwJQfOsTXQOzl9PqAqS1oON9ye0GdDs/qXPxqDLkOLtZdISDbHsi7C/oFwk nDLWU3zthTsCphoP/sxlOCUelSSQxU9Q9fSN8LR2l6kFEWSG4btEKfW7RQJL8cci cnplCfbZFUdLMjcMfXOsH5XJme4p59NpuBIOF4MbuSGFFOVhWtbZuhhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Xvyun5BOsfoIER01kilo/hp+3UyNKFIYoWwOy5dr6 D0=; b=mgcQDrih5AajEmdpGDxdniUJlG+5d+ATBasnftl4hrBsP0HMQX5m0MsPC ipIOCxtK2SKclo/qKiJxQWFmXyJ1UShssK6rte99DqC/Os/a0WGcXQyNydOANAiz MWliUC80fV0xrpTb2NgZzkLS9XBg9gmBswHRKEdJ9dJtlenZ9jfpUglYZpT0u7gU PJUkzJkD6JdCjihC15y2/v/uFKbPeJGDRcx7OsPojDKlI9aa4V+Z6w434TgV1ceJ 9TeMGiugQipZCx+3mzDdi7UayDSASQJDSBGRmeHG2fkKTts6YRpToij19li6KUN/ VSmM6oiJQFr2CIJYsjYINuf8OnKBw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Mar 2022 03:01:51 -0500 (EST) From: Thomas Monjalon To: Junxiao Shi , "Loftus, Ciara" Cc: "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [PATCH] net/af_xdp: fix custom program loading with multiple queues Date: Fri, 11 Mar 2022 09:01:49 +0100 Message-ID: <3163221.44csPzL39Z@thomas> In-Reply-To: References: <2c42e3e23c18fd60@cs.arizona.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/03/2022 09:49, Loftus, Ciara: > > When the PMD is configured to load a custom XDP program, it sets > > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from > > loading its default XDP program. However, when queue_count is set to > > greater than 1, this flag is only set for the first XSK socket but not > > for subsequent XSK sockets. This causes XSK socket creation failure. > > > > This commit ensures that XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag is > > set for all XSK socket creations when custom XDP program is being used. > > > > Fixes: 01fa83c94d7e ("net/af_xdp: workaround custom program loading") > > > > Signed-off-by: Junxiao Shi > > Thanks for the patch! > It's probably too late to make it into 22.03 but cc-ing stable as it should be backported to 21.11.x. > > Acked-by: Ciara Loftus I can take it in -rc4. How much are you confident there is no regression?