DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE
@ 2021-05-12  6:42 Jiawei Wang
  2021-05-12  9:36 ` Slava Ovsiienko
  2021-05-12 10:24 ` [dpdk-dev] [PATCH v2] net/mlx5: fix " Jiawei Wang
  0 siblings, 2 replies; 6+ messages in thread
From: Jiawei Wang @ 2021-05-12  6:42 UTC (permalink / raw)
  To: matan, viacheslavo, orika, jackmin, thomas; +Cc: dev, rasland, stable

Currently RSS expansion only support GRE and GRE KEY.
This patch add RSS expansion for NVGRE item so PMD can expand flow item
correctly.

Fixes: f4b901a46aec ("net/mlx5: add flow GRE item")
Cc: stable@dpdk.org

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Xiaoyu Min <jackmin@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 32634c9af7..73cc9acbd7 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -407,6 +407,7 @@ enum mlx5_expansion {
 	MLX5_EXPANSION_VXLAN,
 	MLX5_EXPANSION_VXLAN_GPE,
 	MLX5_EXPANSION_GRE,
+	MLX5_EXPANSION_NVGRE,
 	MLX5_EXPANSION_GRE_KEY,
 	MLX5_EXPANSION_MPLS,
 	MLX5_EXPANSION_ETH,
@@ -465,6 +466,7 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 			(MLX5_EXPANSION_OUTER_IPV4_UDP,
 			 MLX5_EXPANSION_OUTER_IPV4_TCP,
 			 MLX5_EXPANSION_GRE,
+			 MLX5_EXPANSION_NVGRE,
 			 MLX5_EXPANSION_IPV4,
 			 MLX5_EXPANSION_IPV6),
 		.type = RTE_FLOW_ITEM_TYPE_IPV4,
@@ -487,7 +489,8 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 			 MLX5_EXPANSION_OUTER_IPV6_TCP,
 			 MLX5_EXPANSION_IPV4,
 			 MLX5_EXPANSION_IPV6,
-			 MLX5_EXPANSION_GRE),
+			 MLX5_EXPANSION_GRE,
+			 MLX5_EXPANSION_NVGRE),
 		.type = RTE_FLOW_ITEM_TYPE_IPV6,
 		.rss_types = ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |
 			ETH_RSS_NONFRAG_IPV6_OTHER,
@@ -526,6 +529,10 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 		.type = RTE_FLOW_ITEM_TYPE_GRE_KEY,
 		.optional = 1,
 	},
+	[MLX5_EXPANSION_NVGRE] = {
+		.next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_ETH),
+		.type = RTE_FLOW_ITEM_TYPE_NVGRE,
+	},
 	[MLX5_EXPANSION_MPLS] = {
 		.next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_IPV4,
 						  MLX5_EXPANSION_IPV6),
-- 
2.18.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE
  2021-05-12  6:42 [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE Jiawei Wang
@ 2021-05-12  9:36 ` Slava Ovsiienko
  2021-05-12  9:54   ` Jiawei(Jonny) Wang
  2021-05-12 10:24 ` [dpdk-dev] [PATCH v2] net/mlx5: fix " Jiawei Wang
  1 sibling, 1 reply; 6+ messages in thread
From: Slava Ovsiienko @ 2021-05-12  9:36 UTC (permalink / raw)
  To: Jiawei(Jonny) Wang, Matan Azrad, Ori Kam, Jack Min,
	NBU-Contact-Thomas Monjalon
  Cc: dev, Raslan Darawsheh, stable

> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Wednesday, May 12, 2021 9:43
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Jack Min
> <jackmin@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: support RSS expansion for NVGRE
> 
> Currently RSS expansion only support GRE and GRE KEY.
> This patch add RSS expansion for NVGRE item so PMD can expand flow item
> correctly.
Please, fix typos:
support -> supportS
add -> addS

Also, the "fix" should be in headline.

With best regards,
Slava



> 
> Fixes: f4b901a46aec ("net/mlx5: add flow GRE item")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Xiaoyu Min <jackmin@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 32634c9af7..73cc9acbd7 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -407,6 +407,7 @@ enum mlx5_expansion {
>  	MLX5_EXPANSION_VXLAN,
>  	MLX5_EXPANSION_VXLAN_GPE,
>  	MLX5_EXPANSION_GRE,
> +	MLX5_EXPANSION_NVGRE,
>  	MLX5_EXPANSION_GRE_KEY,
>  	MLX5_EXPANSION_MPLS,
>  	MLX5_EXPANSION_ETH,
> @@ -465,6 +466,7 @@ static const struct mlx5_flow_expand_node
> mlx5_support_expansion[] = {
>  			(MLX5_EXPANSION_OUTER_IPV4_UDP,
>  			 MLX5_EXPANSION_OUTER_IPV4_TCP,
>  			 MLX5_EXPANSION_GRE,
> +			 MLX5_EXPANSION_NVGRE,
>  			 MLX5_EXPANSION_IPV4,
>  			 MLX5_EXPANSION_IPV6),
>  		.type = RTE_FLOW_ITEM_TYPE_IPV4,
> @@ -487,7 +489,8 @@ static const struct mlx5_flow_expand_node
> mlx5_support_expansion[] = {
>  			 MLX5_EXPANSION_OUTER_IPV6_TCP,
>  			 MLX5_EXPANSION_IPV4,
>  			 MLX5_EXPANSION_IPV6,
> -			 MLX5_EXPANSION_GRE),
> +			 MLX5_EXPANSION_GRE,
> +			 MLX5_EXPANSION_NVGRE),
>  		.type = RTE_FLOW_ITEM_TYPE_IPV6,
>  		.rss_types = ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |
>  			ETH_RSS_NONFRAG_IPV6_OTHER,
> @@ -526,6 +529,10 @@ static const struct mlx5_flow_expand_node
> mlx5_support_expansion[] = {
>  		.type = RTE_FLOW_ITEM_TYPE_GRE_KEY,
>  		.optional = 1,
>  	},
> +	[MLX5_EXPANSION_NVGRE] = {
> +		.next =
> MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_ETH),
> +		.type = RTE_FLOW_ITEM_TYPE_NVGRE,
> +	},
>  	[MLX5_EXPANSION_MPLS] = {
>  		.next =
> MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_IPV4,
>  						  MLX5_EXPANSION_IPV6),
> --
> 2.18.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE
  2021-05-12  9:36 ` Slava Ovsiienko
@ 2021-05-12  9:54   ` Jiawei(Jonny) Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Jiawei(Jonny) Wang @ 2021-05-12  9:54 UTC (permalink / raw)
  To: Slava Ovsiienko, Matan Azrad, Ori Kam, Jack Min,
	NBU-Contact-Thomas Monjalon
  Cc: dev, Raslan Darawsheh, stable



> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, May 12, 2021 5:37 PM
> To: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Jack Min
> <jackmin@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: RE: [PATCH] net/mlx5: support RSS expansion for NVGRE
> 
> > -----Original Message-----
> > From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> > Sent: Wednesday, May 12, 2021 9:43
> > To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Jack Min
> > <jackmin@nvidia.com>; NBU-Contact-Thomas Monjalon
> > <thomas@monjalon.net>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> > stable@dpdk.org
> > Subject: [PATCH] net/mlx5: support RSS expansion for NVGRE
> >
> > Currently RSS expansion only support GRE and GRE KEY.
> > This patch add RSS expansion for NVGRE item so PMD can expand flow
> > item correctly.
> Please, fix typos:
> support -> supportS
> add -> addS
> 
> Also, the "fix" should be in headline.
> 

Thank Slava! Will send v2 patch to fix it.

> With best regards,
> Slava
> 
> 
> 
> >[snip]


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] net/mlx5: fix RSS expansion for NVGRE
  2021-05-12  6:42 [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE Jiawei Wang
  2021-05-12  9:36 ` Slava Ovsiienko
@ 2021-05-12 10:24 ` Jiawei Wang
  2021-05-12 11:51   ` Matan Azrad
  1 sibling, 1 reply; 6+ messages in thread
From: Jiawei Wang @ 2021-05-12 10:24 UTC (permalink / raw)
  To: matan, viacheslavo, orika, jackmin, thomas, Shahaf Shuler,
	Xiaoyu Min, Dekel Peled
  Cc: dev, rasland, stable

Currently RSS expansion only supports GRE and GRE KEY.
This patch adds RSS expansion for NVGRE item so PMD can expand flow item
correctly.

Fixes: ea81c1b816f7 ("net/mlx5: fix NVGRE matching")
Cc: stable@dpdk.org

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Xiaoyu Min <jackmin@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 32634c9af7..73cc9acbd7 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -407,6 +407,7 @@ enum mlx5_expansion {
 	MLX5_EXPANSION_VXLAN,
 	MLX5_EXPANSION_VXLAN_GPE,
 	MLX5_EXPANSION_GRE,
+	MLX5_EXPANSION_NVGRE,
 	MLX5_EXPANSION_GRE_KEY,
 	MLX5_EXPANSION_MPLS,
 	MLX5_EXPANSION_ETH,
@@ -465,6 +466,7 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 			(MLX5_EXPANSION_OUTER_IPV4_UDP,
 			 MLX5_EXPANSION_OUTER_IPV4_TCP,
 			 MLX5_EXPANSION_GRE,
+			 MLX5_EXPANSION_NVGRE,
 			 MLX5_EXPANSION_IPV4,
 			 MLX5_EXPANSION_IPV6),
 		.type = RTE_FLOW_ITEM_TYPE_IPV4,
@@ -487,7 +489,8 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 			 MLX5_EXPANSION_OUTER_IPV6_TCP,
 			 MLX5_EXPANSION_IPV4,
 			 MLX5_EXPANSION_IPV6,
-			 MLX5_EXPANSION_GRE),
+			 MLX5_EXPANSION_GRE,
+			 MLX5_EXPANSION_NVGRE),
 		.type = RTE_FLOW_ITEM_TYPE_IPV6,
 		.rss_types = ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |
 			ETH_RSS_NONFRAG_IPV6_OTHER,
@@ -526,6 +529,10 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 		.type = RTE_FLOW_ITEM_TYPE_GRE_KEY,
 		.optional = 1,
 	},
+	[MLX5_EXPANSION_NVGRE] = {
+		.next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_ETH),
+		.type = RTE_FLOW_ITEM_TYPE_NVGRE,
+	},
 	[MLX5_EXPANSION_MPLS] = {
 		.next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_IPV4,
 						  MLX5_EXPANSION_IPV6),
-- 
2.18.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS expansion for NVGRE
  2021-05-12 10:24 ` [dpdk-dev] [PATCH v2] net/mlx5: fix " Jiawei Wang
@ 2021-05-12 11:51   ` Matan Azrad
  2021-05-12 11:58     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Matan Azrad @ 2021-05-12 11:51 UTC (permalink / raw)
  To: Jiawei(Jonny) Wang, Slava Ovsiienko, Ori Kam, Jack Min,
	NBU-Contact-Thomas Monjalon, Shahaf Shuler, Jack Min,
	Dekel Peled
  Cc: dev, Raslan Darawsheh, stable



From: Jiawei(Jonny) Wang
> Currently RSS expansion only supports GRE and GRE KEY.
> This patch adds RSS expansion for NVGRE item so PMD can expand flow item
> correctly.
> 
> Fixes: ea81c1b816f7 ("net/mlx5: fix NVGRE matching")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Xiaoyu Min <jackmin@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix RSS expansion for NVGRE
  2021-05-12 11:51   ` Matan Azrad
@ 2021-05-12 11:58     ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2021-05-12 11:58 UTC (permalink / raw)
  To: Jiawei(Jonny) Wang
  Cc: Slava Ovsiienko, Ori Kam, Jack Min, stable, dev,
	Raslan Darawsheh, Matan Azrad

> > Currently RSS expansion only supports GRE and GRE KEY.
> > This patch adds RSS expansion for NVGRE item so PMD can expand flow item
> > correctly.
> > 
> > Fixes: ea81c1b816f7 ("net/mlx5: fix NVGRE matching")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> > Acked-by: Xiaoyu Min <jackmin@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Applied in next-net-mlx, thanks.




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-05-12 11:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12  6:42 [dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE Jiawei Wang
2021-05-12  9:36 ` Slava Ovsiienko
2021-05-12  9:54   ` Jiawei(Jonny) Wang
2021-05-12 10:24 ` [dpdk-dev] [PATCH v2] net/mlx5: fix " Jiawei Wang
2021-05-12 11:51   ` Matan Azrad
2021-05-12 11:58     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).