From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Wei Zhao <wei.zhao1@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, bernard.iremonger@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: remove port stop check for macsec
Date: Sun, 30 Jun 2019 23:50:32 +0200 [thread overview]
Message-ID: <3169691.2REKQABzIT@xps> (raw)
In-Reply-To: <62d5ba5d-fcad-0f16-ed73-c7d89a5f735f@intel.com>
27/06/2019 19:23, Ferruh Yigit:
> On 6/10/2019 7:07 AM, Wei Zhao wrote:
> > There is no need to do such a check when set macsec for ixgbe, and
> > reconfig_device_queueand is also useless. If we do not delete this
> > unnessary code, users have to stop port before enable or disable
> > macsec, then restart this port after make configuration. All these
> > process are useless. As this cmdline is a private API which is only
> > used by ixgbe NIC, so remove it.
> >
> > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
I disagree with the purpose of this patch.
It is removing some "generic" code with the argument that it is
not needed in the case of ixgbe, and ixgbe is the only user.
We may (and probably will) have other PMDs using this command,
so the argument is not OK.
I do not merge this patch in master for now.
Sorry for the inconvenience.
next prev parent reply other threads:[~2019-06-30 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 7:20 [dpdk-dev] [PATCH] " Wei Zhao
2019-05-09 7:20 ` Wei Zhao
2019-05-10 8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-05-10 8:41 ` Wei Zhao
2019-05-13 3:30 ` Zhao1, Wei
2019-05-13 3:30 ` Zhao1, Wei
2019-06-07 13:59 ` Iremonger, Bernard
2019-06-10 6:40 ` Zhao1, Wei
2019-06-10 6:07 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2019-06-27 17:23 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-06-30 21:50 ` Thomas Monjalon [this message]
2019-07-01 16:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3169691.2REKQABzIT@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).