From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 829427D30 for ; Thu, 4 Jan 2018 18:28:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0D32720914; Thu, 4 Jan 2018 12:28:47 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 04 Jan 2018 12:28:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=bPaJR40bW8KTxhf9JvSqYnBlSw QT3KYErxFOiXQ4guU=; b=c1C8jsUV/+bn73EGBk74ARJkvPIy6tg8CVoO/m82/k EzI2wV+MsGOEfv+2vsVOZYGagI+AmxbEnUQF9OsIzPS6XCeb4DeVYtabpwceh4da Ur+ylV6NJ4wahaHsxNsujPvmFv1jN3RfvKW9p/5JtlpjlbydU7Cj8ys/zd4dRNTX 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=bPaJR4 0bW8KTxhf9JvSqYnBlSwQT3KYErxFOiXQ4guU=; b=ctMT/+xIqM0ljcj/UOnUXt BRNOfcr8YBbwFQsmv+enM5RuMrTtpqSWTiDM8TC0n/LbwTY32FyXyfilwQxhrqKJ fTSNeHxFVBCAMErZrI+b7LwWstDaaks/5DvFJBF4EtY3hWwclBRB3ISXdlLaxU7Q J94m6ini5cN+8iq3kwqdASbqNWrIcUappdzKPWM77s4TT2WdP3gv6HswU9SFltRw XqsnAre3Fp8PJ+BzETBDERdj4XOWSFRsRk2T4N4syLY2vAnmaIWd8VmM79J4OFaH rl1cTYa6su7zP0cdhJ/YEsf9n+IK3sRL4KJ/IaK7XFhWFKW3N4ZC+u9tepVScDBA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AB4AF7E17D; Thu, 4 Jan 2018 12:28:46 -0500 (EST) From: Thomas Monjalon To: Shachar Beiser Cc: dev@dpdk.org, Adrien Mazarguil , Nelio Laranjeiro Date: Thu, 04 Jan 2018 18:28:27 +0100 Message-ID: <3169993.7H2tOZFFXA@xps> In-Reply-To: References: <37757d5cfe32610ef1c7a17d72ea6bc1466023de.1511450393.git.shacharbe@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 17:28:47 -0000 Hi, 31/12/2017 08:52, Shachar Beiser: > MLX5 PMD loads libraries: libibverbs and libmlx5. > MLX5 PMD is not linked to external libraries. > > Signed-off-by: Shachar Beiser Please better describe the change, even if it is obvious: how it is before, after and why making this change. > --- /dev/null > +++ b/drivers/net/mlx5/lib/mlx5_dll.c What means "dll"? Isn't it a Windows wording? Maybe this file is better described as "verbs glue"? > @@ -0,0 +1,294 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright 2017 6WIND S.A. > + * Copyright 2017 Mellanox. I think it should be Copyright 2017 Mellanox Technologies, Ltd. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of 6WIND S.A. nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ Please replace the license text by SPDX identifier. Example: https://dpdk.org/patch/32809/