From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7B1DA0560; Tue, 18 Oct 2022 12:07:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A01C4021E; Tue, 18 Oct 2022 12:07:51 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 88F1D4021D for ; Tue, 18 Oct 2022 12:07:49 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id d7-20020a17090a2a4700b0020d268b1f02so16879755pjg.1 for ; Tue, 18 Oct 2022 03:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=qVzpJYnL1u8kcQ3LlTFIIskp87BkAcrQZX02vQkqEQU=; b=l0KcrLxQpZJDrfo1zmoPQ/K8/LLFjVBAAhqAeApu8XLpZJk/21Qf+E2UkmRNhEdvEP pFwlys63g1DFJuawZCTO4H/HfvOQ5QJHPy0slIl1olvxUiVQE4TgdasNXRYZT3IaC8DE /HPhIqflA9uCYbP8UcyvbABBO5jjkj73+st0uh/5B4JrURElLkixJvTZdM1da2wQMN9w KHUI/0zO0kLVVy7mIRQ4B6wDpSYGmIBAA1akHQ4LjqJ1vS5MFmWDt1/GX0a1UhA/Ur81 awgjAB5C9S0MvpqET64W1YUwJkBj+OVc1w2SxI/JHSEt2ablPwvWvdlR0ptVAtqsK/lg g/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qVzpJYnL1u8kcQ3LlTFIIskp87BkAcrQZX02vQkqEQU=; b=Bdc9kJgUdyHUF0Ohc7FAGfXQfTKLXcxIOlavwmn2KEvfAGbw1eRRy+DHdNFEWExUdN U5uD6Py9EABO8vGcuyASJ025g41vPGStssqwP+shhemC74h8QqqbXVRoF8rjP8947mZg a7isHzaw8ZGT+HLf2dqZ7bdnGkjve0FFN0iuVKLqHH5sRz+yihTbSuMUociCS4TKHHh9 K7FF+RXrrUVYGXGCO1+IDatbDG6UGjmr20PATEPIOXo6HoE2280QAvJQjsgfImhFxs4W +DTPsB3g56dF3YtUNQaQh9H0atagaPvSExZKD5xSiRZKaGvXzY+CUwftM6VmivR92eiv lQbA== X-Gm-Message-State: ACrzQf0cXNlG7Pna8nDT1hVQ/OSo9v2ZCUDZPPynJbhPZ8dq+5CtVHW2 0D+Tjs0oRPEx5rOHsPephSNcsQ== X-Google-Smtp-Source: AMsMyM4dIIzb40TQ3+DJ/0HsyX1I6NtKjbgBlS4VC+EpcZWxCtb4YXBzEwawSqVU02+BXHzXq17xKw== X-Received: by 2002:a17:90b:1d8a:b0:20c:a6db:5713 with SMTP id pf10-20020a17090b1d8a00b0020ca6db5713mr38750923pjb.135.1666087668701; Tue, 18 Oct 2022 03:07:48 -0700 (PDT) Received: from [100.64.100.6] ([199.101.192.140]) by smtp.gmail.com with ESMTPSA id 73-20020a63064c000000b0043c732e1536sm7701056pgg.45.2022.10.18.03.07.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Oct 2022 03:07:48 -0700 (PDT) Subject: Re: crypto/uadk: introduce uadk crypto driver To: Zhangfei Gao , Akhil Goyal , "techboard@dpdk.org" Cc: "dev@dpdk.org" , "acc@openeuler.org" References: <9e897e5c-b6db-bea7-3490-b57c1f76a8ba@linaro.org> From: Zhangfei Gao Message-ID: <316c505f-8072-5da8-0ca0-d5105ea479a6@linaro.org> Date: Tue, 18 Oct 2022 18:07:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <9e897e5c-b6db-bea7-3490-b57c1f76a8ba@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Akhil > > On 2022/10/17 下午3:02, Akhil Goyal wrote: >> >> Hi everyone, >> >> We have a new crypto PMD submitted on ML >> (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zhangfei.gao@linaro.org/) >> >> This PMD is dependent on an external library which needs to be cross >> compiled for ARM on x86. >> >> It mandatorily need “numactl” also cross-compiled and instead of >> using pkg-config of libnuma, it need the library and headers to be >> copied manually to aarch toolchain. >> >> And if that is also done, it is not generating pkg-config which DPDK >> can use to compile the PMD. >> > > Thanks for the guidance > > We are trying to provide pkgconfig file for uadk libs > https://github.com/Linaro/uadk/pull/513 > > And have fixed the x86 local build. > https://github.com/Linaro/uadk/pull/512 Under this git pull, I have verified building and installing dpdk on x86 with this diff to switch to pkg-config diff --git a/drivers/crypto/uadk/meson.build b/drivers/crypto/uadk/meson.build index dda6c6b257..f6fae0a239 100644 --- a/drivers/crypto/uadk/meson.build +++ b/drivers/crypto/uadk/meson.build @@ -8,18 +8,12 @@ if not is_linux      subdir_done()  endif -if arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_64') -    build = false -    reason = 'only supported on aarch64' -    subdir_done() -endif -  sources = files(          'uadk_crypto_pmd.c',  )  deps += 'bus_vdev' -dep = cc.find_library('libwd_crypto', required: false) +dep = dependency('libwd_crypto', required: false, method: 'pkg-config')  if not dep.found()         build = false         reason = 'missing dependency, "libwd_crypto"' @@ -27,7 +21,7 @@ else         ext_deps += dep  endif -dep = cc.find_library('libwd', required: false) +dep = dependency('libwd', required: false, method: 'pkg-config')  if not dep.found()         build = false         reason = 'missing dependency, "libwd"' One uncertainty is numa,  "Requires: numa", This requires numa.pc has to be installed, so numa only can be installed from source code (make install). While apt-get install libnuma-dev does not install numa.pc, so system can not search numa. So do we have to build numa from source code? Thanks