Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification

[Thomas Monjalon <thomas@monjalon.net>]

29/03/2019 16:09, Burakov, Anatoly:
> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote:
> > 18/03/2019 12:56, Hajkowski:
> >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> >> --- a/doc/guides/rel_notes/release_19_05.rst
> >> +++ b/doc/guides/rel_notes/release_19_05.rst
> >> @@ -120,6 +120,8 @@ API Changes
> >> +   * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions
> >> +     have been modified to be thread safe.
> > 
> > The deprecation notice was recently sent,
> > so I guess this patch is for DPDK 19.08.
> 
> Yes, this is changing API so the target was 19.08. However, first patch 
> is a fix and can be applied to 19.05 as well. The API documentation 
> stated that the function was not thread safe, but the code itself was 
> thread safe (it wasn't because it was buggy, but the intention of being 
> thread safe was there), so this could be considered fixing docs to match 
> the intended behavior of the code.
> 
> > Review from the maintainer (David) may help.
> > Thanks

What is the follow-up here?
We still have an old deprecation notice:
	http://git.dpdk.org/dpdk/commit/?id=3477b7a2cc

I wonder how such things can be forgotten.
I feel some help is needed in prioritization,
so let's consider this deprecation as the priority #1
gating any other change in the power library.

Priority #2: cleaning up API which are secretly exported
for example convenience. It is an old design issue never fixed:
	http://inbox.dpdk.org/dev/6046120.mQ0ExDuKPD@thomas/

Priority #3: request feedbacks from other maintainers
to add a generic API in ethdev to get a hook for power management.