[dpdk-dev] [PATCH] app/test: fix qat autotest failure

[dpdk-dev] [PATCH] app/test: fix qat autotest failure

[Deepak Kumar JAIN]

This patch fix the QAT autotest failure when run for multiple times.
it was caused as mbuf was not freed.

Fixes: 202d375c60b (app/test: add cryptodev unit and performance tests)

This patch depends on following patch:
cryptodev API changes
http://dpdk.org/ml/archives/dev/2016-February/034212.html

Signed-off-by: Deepak Kumar JAIN <deepak.k.jain@intel.com>
---
 app/test/test_cryptodev.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 208fc14..acba98a 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -1845,6 +1845,18 @@ test_multi_session(void)
 				sessions[i], ut_params, ts_params),
 				"Failed to perform decrypt on request "
 				"number %u.", i);
+		/* free crypto operation structure */
+		if (ut_params->op)
+			rte_crypto_op_free(ut_params->op);
+
+		/*
+		 * free mbuf - both obuf and ibuf are usually the same,
+		 * but rte copes even if we call free twice
+		 */
+		if (ut_params->obuf) {
+			rte_pktmbuf_free(ut_params->obuf);
+			ut_params->obuf = 0;
+		}
 	}
 
 	/* Next session create should fail */
-- 
2.1.0

Re: [dpdk-dev] [PATCH] app/test: fix qat autotest failure

[Trahe, Fiona]

> -----Original Message-----
> From: Jain, Deepak K
> Sent: Tuesday, March 01, 2016 4:55 PM
> To: dev@dpdk.org
> Cc: Griffin, John; Trahe, Fiona; Jain, Deepak K
> Subject: [PATCH] app/test: fix qat autotest failure
> 
> This patch fix the QAT autotest failure when run for multiple times.
> it was caused as mbuf was not freed.
> 
> Fixes: 202d375c60b (app/test: add cryptodev unit and performance tests)
> 
> This patch depends on following patch:
> cryptodev API changes
> http://dpdk.org/ml/archives/dev/2016-February/034212.html
> 
> Signed-off-by: Deepak Kumar JAIN <deepak.k.jain@intel.com>
> ---
>  app/test/test_cryptodev.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 208fc14..acba98a 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -1845,6 +1845,18 @@ test_multi_session(void)
>  				sessions[i], ut_params, ts_params),
>  				"Failed to perform decrypt on request "
>  				"number %u.", i);
> +		/* free crypto operation structure */
> +		if (ut_params->op)
> +			rte_crypto_op_free(ut_params->op);
> +
> +		/*
> +		 * free mbuf - both obuf and ibuf are usually the same,
> +		 * but rte copes even if we call free twice
> +		 */
> +		if (ut_params->obuf) {
> +			rte_pktmbuf_free(ut_params->obuf);
> +			ut_params->obuf = 0;
> +		}
>  	}
> 
>  	/* Next session create should fail */
> --
> 2.1.0
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] app/test: fix qat autotest failure

[Thomas Monjalon]

> > This patch fix the QAT autotest failure when run for multiple times.
> > it was caused as mbuf was not freed.
> > 
> > Fixes: 202d375c60b (app/test: add cryptodev unit and performance tests)
> > 
> > This patch depends on following patch:
> > cryptodev API changes
> > http://dpdk.org/ml/archives/dev/2016-February/034212.html
> > 
> > Signed-off-by: Deepak Kumar JAIN <deepak.k.jain@intel.com>
> 
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied, thanks