From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 277568E82 for <dev@dpdk.org>; Wed, 25 Nov 2015 00:05:35 +0100 (CET) Received: by wmec201 with SMTP id c201so47551560wme.1 for <dev@dpdk.org>; Tue, 24 Nov 2015 15:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=F8lKa5y4FOG/TBW6j87p+xG66RvN6FU9vzEYgUmNgLg=; b=FoHU8pTJGtIzVdLuzh2GF2YxOOEqypgbPhIwyb8Lipd37/UoDfsublt2aquw/JwmGo GbtlbYNXXcrEgC8PLSIqt6jyuZTVV7k1yC8ErcZa+iGS8fNBH10NWRq1LJno1Ivh5/y0 PIBo+GvLBI5iyoMgffsekxUPUVh6BhYQymtzSdxn90b3Sxa8YfNnalKMTIbW5/1SysnS mU6xectwRCaZKosiENuyiUAy99mnfb/NAq554xKOHF8klnowtzGKdCNktguqDwFLesWN DtF07qe3kRBo31T1XunuAzwcH4+dqgdyh0yIerQtdEZW+U1HhFe28DB9At6fkh7MPCI7 OAKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=F8lKa5y4FOG/TBW6j87p+xG66RvN6FU9vzEYgUmNgLg=; b=OHh2rn5zyhwInyRGBoLmxp3WgQBLpWcGyeckYtMxOiVIeaVc3i68XbNYgpibSsMpc4 1eck+NxoL+v57T15lPdi05q2rMbVFCEDGI+w7GI5pS3QiozRVuzpeuSqZAGR64g5TZp1 hJ2PCAC1BOXc6LJSZfGR0QhMgtvCAWQTGiQLsDLGPKhnLUGgFOS6cRHpKbWFN8wr+XdH afGl6SLmNMON9Vk0v/76d2LDezXrGBfcAkACJ/Gv8UMqHAMkMZ3FJalvwGM+gvlWT5e+ I21cv3zfzy5HmUh97f3FMUMpEDrXexzYi4CfNhgcYOQH5qO+aUu/tAvpW9lxJOy6pzTv 40Sw== X-Gm-Message-State: ALoCoQki5F7Gxh1uMpEZcCAmQOq7plL+0pGQI+6zDKfRgqE8LbQlsKcZ7tALBs3ZR3EKxZRhFAtG X-Received: by 10.28.153.130 with SMTP id b124mr974896wme.12.1448406335030; Tue, 24 Nov 2015 15:05:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id uq3sm20313866wjc.10.2015.11.24.15.05.33 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 15:05:34 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 25 Nov 2015 00:04:16 +0100 Message-ID: <3179262.cyHqZdDHPg@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151124144403.79811c0a@xeon-e3> References: <1448219615-63746-1-git-send-email-zhihong.wang@intel.com> <1640963.TLMeDD9tfp@xps13> <20151124144403.79811c0a@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Nov 2015 23:05:35 -0000 2015-11-24 14:44, Stephen Hemminger: > On Tue, 24 Nov 2015 22:13:28 +0100 > Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > > > 2015-11-22 18:28, Stephen Hemminger: > > > On Sun, 22 Nov 2015 14:13:35 -0500 > > > Zhihong Wang <zhihong.wang@intel.com> wrote: > > > > > > > The kernel fills new allocated (huge) pages with zeros. > > > > DPDK just has to populate page tables to trigger the allocation. > > > > > > > > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com> > > > > > > Nice, especially on slow machines or with large memory. > > > > > > Acked-by: Stephen Hemminger <stephen@networkplumber.org> > > > > Yes very nice. > > I think it's too late to integrate this change which can have some > > unpredictable side effects. > > Do you agree to wait for 2.3? > > What side effects? Either it is zero or it is not. > Only some broken architecture would have an issue. I mean it changes the memory allocator behaviour. It's not something we want to discover a new bug just before the release. This kind of important change must be integrated at the beginning of the release cycle. I'm asking for opinions because it would be really nice to have.