* [dpdk-dev] [PATCH] crypto/mlx5: support BF2 and ConnectX6-DX devices @ 2021-11-07 16:22 Raja Zidane 2021-11-07 16:26 ` Raja Zidane 0 siblings, 1 reply; 12+ messages in thread From: Raja Zidane @ 2021-11-07 16:22 UTC (permalink / raw) To: dev; +Cc: Matan Azrad Starting from MLNX_OFED 5.5. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane <rzidane@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- dependant on https://patchwork.dpdk.org/project/dpdk/cover/20211104124929.24899-1-rzidane@nvidia.com/ doc/guides/cryptodevs/mlx5.rst | 6 +++++- doc/guides/rel_notes/release_21_11.rst | 4 ++++ drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..4ca0f7e5ea 100644 --- a/doc/guides/cryptodevs/mlx5.rst +++ b/doc/guides/cryptodevs/mlx5.rst @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: should not be specified. All the device ports should set it in order to move to operational mode. + For BlueField2, also the internal ports in the ARMs system should be set. - Query CRYPTO_OPERATIONAL register to make sure the device is in Operational mode. @@ -141,6 +142,8 @@ Supported NICs -------------- * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) +* Mellanox\ |reg| BlueField 2 SmartNIC +* Mellanox\ |reg| ConnectX\ |reg|-6DX Limitations @@ -158,7 +161,8 @@ Prerequisites Linux Prerequisites ~~~~~~~~~~~~~~~~~~~ -- Mellanox OFED version: **5.3** +- Mellanox OFED version: starts at 5.3 for ConnectX6. + Mellanox OFED version: 5.5 for ConnectX6DX and BF2. see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. - Compilation can be done also with rdma-core v15+. diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 9bf4479002..490a8859d7 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -401,6 +401,10 @@ New Features overruns in C/C++ programs, and other similar errors, as well as printing out detailed debug information whenever an error is detected. +* **Updated mlx5 crypto driver.** + + * Added support for BF2. + * Added support for CX6DX. Removed Items ------------- diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 038526c023..316cb46ebf 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -1034,6 +1034,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = { RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_CONNECTX6) }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) + }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) + }, { .vendor_id = 0 } -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-07 16:22 [dpdk-dev] [PATCH] crypto/mlx5: support BF2 and ConnectX6-DX devices Raja Zidane @ 2021-11-07 16:26 ` Raja Zidane 2021-11-07 17:29 ` [dpdk-dev] [PATCH V2] " Raja Zidane 0 siblings, 1 reply; 12+ messages in thread From: Raja Zidane @ 2021-11-07 16:26 UTC (permalink / raw) To: dev; +Cc: Matan Azrad Starting from MLNX_OFED 5.5. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane <rzidane@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- dependant on https://patchwork.dpdk.org/project/dpdk/cover/20211104124929.24899-1-rzidane@nvidia.com/ V2: fix checkpatch warning. doc/guides/cryptodevs/mlx5.rst | 6 +++++- doc/guides/rel_notes/release_21_11.rst | 4 ++++ drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..4ca0f7e5ea 100644 --- a/doc/guides/cryptodevs/mlx5.rst +++ b/doc/guides/cryptodevs/mlx5.rst @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: should not be specified. All the device ports should set it in order to move to operational mode. + For BlueField2, also the internal ports in the ARMs system should be set. - Query CRYPTO_OPERATIONAL register to make sure the device is in Operational mode. @@ -141,6 +142,8 @@ Supported NICs -------------- * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) +* Mellanox\ |reg| BlueField 2 SmartNIC +* Mellanox\ |reg| ConnectX\ |reg|-6DX Limitations @@ -158,7 +161,8 @@ Prerequisites Linux Prerequisites ~~~~~~~~~~~~~~~~~~~ -- Mellanox OFED version: **5.3** +- Mellanox OFED version: starts at 5.3 for ConnectX6. + Mellanox OFED version: 5.5 for ConnectX6DX and BF2. see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. - Compilation can be done also with rdma-core v15+. diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 9bf4479002..490a8859d7 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -401,6 +401,10 @@ New Features overruns in C/C++ programs, and other similar errors, as well as printing out detailed debug information whenever an error is detected. +* **Updated mlx5 crypto driver.** + + * Added support for BF2. + * Added support for CX6DX. Removed Items ------------- diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 038526c023..316cb46ebf 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -1034,6 +1034,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = { RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_CONNECTX6) }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) + }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) + }, { .vendor_id = 0 } -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH V2] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-07 16:26 ` Raja Zidane @ 2021-11-07 17:29 ` Raja Zidane 2021-11-07 17:44 ` Thomas Monjalon ` (2 more replies) 0 siblings, 3 replies; 12+ messages in thread From: Raja Zidane @ 2021-11-07 17:29 UTC (permalink / raw) To: dev; +Cc: Matan Azrad Starting from MLNX_OFED 5.5. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane <rzidane@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- dependant on https://patchwork.dpdk.org/project/dpdk/cover/20211104124929.24899-1-rzidane@nvidia.com/ V2: fixed checkpatch warning. fixed doc. doc/guides/cryptodevs/mlx5.rst | 6 +++++- doc/guides/rel_notes/release_21_11.rst | 4 ++++ drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..ab52dde4ce 100644 --- a/doc/guides/cryptodevs/mlx5.rst +++ b/doc/guides/cryptodevs/mlx5.rst @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: should not be specified. All the device ports should set it in order to move to operational mode. + For BlueField2, also the internal ports in the ARMs system should be set. - Query CRYPTO_OPERATIONAL register to make sure the device is in Operational mode. @@ -141,6 +142,8 @@ Supported NICs -------------- * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) +* Mellanox\ |reg| BlueField 2 SmartNIC +* Mellanox\ |reg| ConnectX\ |reg|-6DX Limitations @@ -158,7 +161,8 @@ Prerequisites Linux Prerequisites ~~~~~~~~~~~~~~~~~~~ -- Mellanox OFED version: **5.3** +- Mellanox OFED version: **5.3** for ConnectX6. + Mellanox OFED version: **5.5** for ConnectX6DX and BF2. see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. - Compilation can be done also with rdma-core v15+. diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 9bf4479002..490a8859d7 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -401,6 +401,10 @@ New Features overruns in C/C++ programs, and other similar errors, as well as printing out detailed debug information whenever an error is detected. +* **Updated mlx5 crypto driver.** + + * Added support for BF2. + * Added support for CX6DX. Removed Items ------------- diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 038526c023..316cb46ebf 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -1034,6 +1034,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = { RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_CONNECTX6) }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) + }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) + }, { .vendor_id = 0 } -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH V2] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-07 17:29 ` [dpdk-dev] [PATCH V2] " Raja Zidane @ 2021-11-07 17:44 ` Thomas Monjalon 2021-11-07 19:03 ` Tal Shnaiderman 2021-11-08 13:18 ` [dpdk-dev] [PATCH V3] " Raja Zidane 2 siblings, 0 replies; 12+ messages in thread From: Thomas Monjalon @ 2021-11-07 17:44 UTC (permalink / raw) To: Raja Zidane; +Cc: dev, Matan Azrad 07/11/2021 18:29, Raja Zidane: > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -401,6 +401,10 @@ New Features > overruns in C/C++ programs, and other similar errors, as well as > printing out detailed debug information whenever an error is detected. > > +* **Updated mlx5 crypto driver.** > + > + * Added support for BF2. > + * Added support for CX6DX. I you don't know where to put something in a list, choosing to put at the end is almost always a bad decision. In the case of the release notes, the order is described at the beginning. And in this particular case, there is already a matching section: * **Updated Mellanox mlx5 crypto driver.** * Added Windows support. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH V2] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-07 17:29 ` [dpdk-dev] [PATCH V2] " Raja Zidane 2021-11-07 17:44 ` Thomas Monjalon @ 2021-11-07 19:03 ` Tal Shnaiderman 2021-11-08 13:18 ` [dpdk-dev] [PATCH V3] " Raja Zidane 2 siblings, 0 replies; 12+ messages in thread From: Tal Shnaiderman @ 2021-11-07 19:03 UTC (permalink / raw) To: Raja Zidane, dev; +Cc: Matan Azrad > Subject: [dpdk-dev] [PATCH V2] crypto/mlx5: support BF2 and ConnectX6-DX > devices > > External email: Use caution opening links or attachments > > > Starting from MLNX_OFED 5.5. version, the BlueField2 and ConnextX6-DX > adapters support crypto operations. > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane <rzidane@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> > --- > dependant on > https://patchwork.dpdk.org/project/dpdk/cover/20211104124929.24899-1- > rzidane@nvidia.com/ > V2: fixed checkpatch warning. > fixed doc. > doc/guides/cryptodevs/mlx5.rst | 6 +++++- > doc/guides/rel_notes/release_21_11.rst | 4 ++++ > drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ > 3 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/cryptodevs/mlx5.rst > b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..ab52dde4ce 100644 > --- a/doc/guides/cryptodevs/mlx5.rst > +++ b/doc/guides/cryptodevs/mlx5.rst > @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: > should not be specified. > > All the device ports should set it in order to move to operational mode. > + For BlueField2, also the internal ports in the ARMs system should be set. > > - Query CRYPTO_OPERATIONAL register to make sure the device is in > Operational > mode. > @@ -141,6 +142,8 @@ Supported NICs > -------------- > > * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) > +* Mellanox\ |reg| BlueField 2 SmartNIC > +* Mellanox\ |reg| ConnectX\ |reg|-6DX > > > Limitations > @@ -158,7 +161,8 @@ Prerequisites > Linux Prerequisites > ~~~~~~~~~~~~~~~~~~~ > > -- Mellanox OFED version: **5.3** > +- Mellanox OFED version: **5.3** for ConnectX6. > + Mellanox OFED version: **5.5** for ConnectX6DX and BF2. > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. Does a new OFED version a Prerequisite for ConnectX6DX and BF2? Doesn't it depend solely on the FW version? > > - Compilation can be done also with rdma-core v15+. > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > index 9bf4479002..490a8859d7 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -401,6 +401,10 @@ New Features > overruns in C/C++ programs, and other similar errors, as well as > printing out detailed debug information whenever an error is detected. > > +* **Updated mlx5 crypto driver.** > + > + * Added support for BF2. > + * Added support for CX6DX. > > Removed Items > ------------- > diff --git a/drivers/crypto/mlx5/mlx5_crypto.c > b/drivers/crypto/mlx5/mlx5_crypto.c > index 038526c023..316cb46ebf 100644 > --- a/drivers/crypto/mlx5/mlx5_crypto.c > +++ b/drivers/crypto/mlx5/mlx5_crypto.c > @@ -1034,6 +1034,14 @@ static const struct rte_pci_id > mlx5_crypto_pci_id_map[] = { > RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > PCI_DEVICE_ID_MELLANOX_CONNECTX6) > }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) > + }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) > + }, > { > .vendor_id = 0 > } > -- > 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH V3] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-07 17:29 ` [dpdk-dev] [PATCH V2] " Raja Zidane 2021-11-07 17:44 ` Thomas Monjalon 2021-11-07 19:03 ` Tal Shnaiderman @ 2021-11-08 13:18 ` Raja Zidane 2021-11-08 14:03 ` Tal Shnaiderman 2021-11-10 12:27 ` [dpdk-dev] [PATCH V4] " Raja Zidane 2 siblings, 2 replies; 12+ messages in thread From: Raja Zidane @ 2021-11-08 13:18 UTC (permalink / raw) To: dev; +Cc: Matan Azrad Starting from MLNX_OFED 5.5. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane <rzidane@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- dependant on https://patchwork.dpdk.org/project/dpdk/cover/20211104124929.24899-1-rzidane@nvidia.com/ V2: fixed checkpatch warning. V3: fixed doc. doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- doc/guides/rel_notes/release_21_11.rst | 2 +- drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..fe18a20717 100644 --- a/doc/guides/cryptodevs/mlx5.rst +++ b/doc/guides/cryptodevs/mlx5.rst @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: should not be specified. All the device ports should set it in order to move to operational mode. + For BlueField2, also the internal ports in the ARMs system should be set. - Query CRYPTO_OPERATIONAL register to make sure the device is in Operational mode. @@ -141,6 +142,8 @@ Supported NICs -------------- * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) +* Mellanox\ |reg| BlueField 2 SmartNIC +* Mellanox\ |reg| ConnectX\ |reg|-6DX Limitations @@ -155,10 +158,16 @@ Limitations Prerequisites ------------- +FW Prerequisites +~~~~~~~~~~~~~~~~ + +- xx.31.0328 for ConnectX6. +- xx.32.0108 for ConnectX6DX and BlueField2. + Linux Prerequisites ~~~~~~~~~~~~~~~~~~~ -- Mellanox OFED version: **5.3** +- Mellanox OFED version: **5.3**. see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. - Compilation can be done also with rdma-core v15+. diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 8da19c613a..2c4f601cef 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -285,6 +285,7 @@ New Features * **Updated Mellanox mlx5 crypto driver.** * Added Windows support. + * Added support for BF2 and CX6DX. * **Updated NXP dpaa_sec crypto PMD.** @@ -410,7 +411,6 @@ New Features overruns in C/C++ programs, and other similar errors, as well as printing out detailed debug information whenever an error is detected. - Removed Items ------------- diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 3caa22f35f..47da3d115b 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -994,6 +994,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = { RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_CONNECTX6) }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) + }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) + }, { .vendor_id = 0 } -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH V3] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-08 13:18 ` [dpdk-dev] [PATCH V3] " Raja Zidane @ 2021-11-08 14:03 ` Tal Shnaiderman 2021-11-10 12:27 ` [dpdk-dev] [PATCH V4] " Raja Zidane 1 sibling, 0 replies; 12+ messages in thread From: Tal Shnaiderman @ 2021-11-08 14:03 UTC (permalink / raw) To: Raja Zidane, dev; +Cc: Matan Azrad > Subject: [dpdk-dev] [PATCH V3] crypto/mlx5: support BF2 and ConnectX6-DX > devices > > External email: Use caution opening links or attachments > > > Starting from MLNX_OFED 5.5. version, the BlueField2 and ConnextX6-DX > adapters support crypto operations. "Starting from FW version xx.32.0108..." > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane <rzidane@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-08 13:18 ` [dpdk-dev] [PATCH V3] " Raja Zidane 2021-11-08 14:03 ` Tal Shnaiderman @ 2021-11-10 12:27 ` Raja Zidane 2021-11-10 12:47 ` Tal Shnaiderman ` (2 more replies) 1 sibling, 3 replies; 12+ messages in thread From: Raja Zidane @ 2021-11-10 12:27 UTC (permalink / raw) To: dev; +Cc: Matan Azrad Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane <rzidane@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- V2: fixed checkpatch warning. V3: fixed doc. V4: fixed commit log. doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- doc/guides/rel_notes/release_21_11.rst | 2 +- drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..fe18a20717 100644 --- a/doc/guides/cryptodevs/mlx5.rst +++ b/doc/guides/cryptodevs/mlx5.rst @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: should not be specified. All the device ports should set it in order to move to operational mode. + For BlueField2, also the internal ports in the ARMs system should be set. - Query CRYPTO_OPERATIONAL register to make sure the device is in Operational mode. @@ -141,6 +142,8 @@ Supported NICs -------------- * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) +* Mellanox\ |reg| BlueField 2 SmartNIC +* Mellanox\ |reg| ConnectX\ |reg|-6DX Limitations @@ -155,10 +158,16 @@ Limitations Prerequisites ------------- +FW Prerequisites +~~~~~~~~~~~~~~~~ + +- xx.31.0328 for ConnectX6. +- xx.32.0108 for ConnectX6DX and BlueField2. + Linux Prerequisites ~~~~~~~~~~~~~~~~~~~ -- Mellanox OFED version: **5.3** +- Mellanox OFED version: **5.3**. see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. - Compilation can be done also with rdma-core v15+. diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 01923e2deb..96d14e01fd 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -291,6 +291,7 @@ New Features * **Updated Mellanox mlx5 crypto driver.** * Added Windows support. + * Added support for BF2 and CX6DX. * **Updated NXP dpaa_sec crypto PMD.** @@ -416,7 +417,6 @@ New Features overruns in C/C++ programs, and other similar errors, as well as printing out detailed debug information whenever an error is detected. - Removed Items ------------- diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 3caa22f35f..47da3d115b 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -994,6 +994,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = { RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_CONNECTX6) }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) + }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) + }, { .vendor_id = 0 } -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-10 12:27 ` [dpdk-dev] [PATCH V4] " Raja Zidane @ 2021-11-10 12:47 ` Tal Shnaiderman 2021-11-11 11:11 ` [EXT] " Akhil Goyal 2021-11-11 13:51 ` [PATCH V5] " Raja Zidane 2 siblings, 0 replies; 12+ messages in thread From: Tal Shnaiderman @ 2021-11-10 12:47 UTC (permalink / raw) To: Raja Zidane, dev; +Cc: Matan Azrad > Subject: [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX > devices > > External email: Use caution opening links or attachments > > > Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6- > DX adapters support crypto operations. > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane <rzidane@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> > --- > V2: fixed checkpatch warning. > V3: fixed doc. > V4: fixed commit log. > doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- > doc/guides/rel_notes/release_21_11.rst | 2 +- > drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/cryptodevs/mlx5.rst > b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..fe18a20717 100644 > --- a/doc/guides/cryptodevs/mlx5.rst > +++ b/doc/guides/cryptodevs/mlx5.rst > @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: > should not be specified. > > All the device ports should set it in order to move to operational mode. > + For BlueField2, also the internal ports in the ARMs system should be set. > > - Query CRYPTO_OPERATIONAL register to make sure the device is in > Operational > mode. > @@ -141,6 +142,8 @@ Supported NICs > -------------- > > * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) > +* Mellanox\ |reg| BlueField 2 SmartNIC > +* Mellanox\ |reg| ConnectX\ |reg|-6DX > > > Limitations > @@ -155,10 +158,16 @@ Limitations > Prerequisites > ------------- > > +FW Prerequisites > +~~~~~~~~~~~~~~~~ > + > +- xx.31.0328 for ConnectX6. > +- xx.32.0108 for ConnectX6DX and BlueField2. > + > Linux Prerequisites > ~~~~~~~~~~~~~~~~~~~ > > -- Mellanox OFED version: **5.3** > +- Mellanox OFED version: **5.3**. > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > - Compilation can be done also with rdma-core v15+. > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > index 01923e2deb..96d14e01fd 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -291,6 +291,7 @@ New Features > * **Updated Mellanox mlx5 crypto driver.** > > * Added Windows support. > + * Added support for BF2 and CX6DX. > > * **Updated NXP dpaa_sec crypto PMD.** > > @@ -416,7 +417,6 @@ New Features > overruns in C/C++ programs, and other similar errors, as well as > printing out detailed debug information whenever an error is detected. > > - > Removed Items > ------------- > > diff --git a/drivers/crypto/mlx5/mlx5_crypto.c > b/drivers/crypto/mlx5/mlx5_crypto.c > index 3caa22f35f..47da3d115b 100644 > --- a/drivers/crypto/mlx5/mlx5_crypto.c > +++ b/drivers/crypto/mlx5/mlx5_crypto.c > @@ -994,6 +994,14 @@ static const struct rte_pci_id > mlx5_crypto_pci_id_map[] = { > RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > PCI_DEVICE_ID_MELLANOX_CONNECTX6) > }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) > + }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) > + }, > { > .vendor_id = 0 > } > -- > 2.17.1 Acked-by: Tal Shnaiderman <talshn@nvidia.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [EXT] [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-10 12:27 ` [dpdk-dev] [PATCH V4] " Raja Zidane 2021-11-10 12:47 ` Tal Shnaiderman @ 2021-11-11 11:11 ` Akhil Goyal 2021-11-11 13:51 ` [PATCH V5] " Raja Zidane 2 siblings, 0 replies; 12+ messages in thread From: Akhil Goyal @ 2021-11-11 11:11 UTC (permalink / raw) To: Raja Zidane, dev; +Cc: Matan Azrad > Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6- > DX > adapters support crypto operations. > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane <rzidane@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> > --- > V2: fixed checkpatch warning. > V3: fixed doc. > V4: fixed commit log. > doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- > doc/guides/rel_notes/release_21_11.rst | 2 +- > drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/cryptodevs/mlx5.rst > b/doc/guides/cryptodevs/mlx5.rst > index 9bd8c6fe85..fe18a20717 100644 > --- a/doc/guides/cryptodevs/mlx5.rst > +++ b/doc/guides/cryptodevs/mlx5.rst > @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: > should not be specified. > > All the device ports should set it in order to move to operational mode. > + For BlueField2, also the internal ports in the ARMs system should be set. Rephrase it to For BlueField2, the internal ports in the ARMs system should also be set. > > - Query CRYPTO_OPERATIONAL register to make sure the device is in > Operational > mode. > @@ -141,6 +142,8 @@ Supported NICs > -------------- > > * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) > +* Mellanox\ |reg| BlueField 2 SmartNIC > +* Mellanox\ |reg| ConnectX\ |reg|-6DX > > > Limitations > @@ -155,10 +158,16 @@ Limitations > Prerequisites > ------------- > > +FW Prerequisites > +~~~~~~~~~~~~~~~~ > + > +- xx.31.0328 for ConnectX6. > +- xx.32.0108 for ConnectX6DX and BlueField2. > + > Linux Prerequisites > ~~~~~~~~~~~~~~~~~~~ > > -- Mellanox OFED version: **5.3** > +- Mellanox OFED version: **5.3**. > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > - Compilation can be done also with rdma-core v15+. > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > index 01923e2deb..96d14e01fd 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -291,6 +291,7 @@ New Features > * **Updated Mellanox mlx5 crypto driver.** > > * Added Windows support. > + * Added support for BF2 and CX6DX. You may use Bluefield2 and ConnectX6-DX instead. > > * **Updated NXP dpaa_sec crypto PMD.** > > @@ -416,7 +417,6 @@ New Features > overruns in C/C++ programs, and other similar errors, as well as > printing out detailed debug information whenever an error is detected. > > - Do not remove this line. > Removed Items > ------------- > > diff --git a/drivers/crypto/mlx5/mlx5_crypto.c > b/drivers/crypto/mlx5/mlx5_crypto.c > index 3caa22f35f..47da3d115b 100644 > --- a/drivers/crypto/mlx5/mlx5_crypto.c > +++ b/drivers/crypto/mlx5/mlx5_crypto.c > @@ -994,6 +994,14 @@ static const struct rte_pci_id > mlx5_crypto_pci_id_map[] = { > RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > > PCI_DEVICE_ID_MELLANOX_CONNECTX6) > }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + > PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) > + }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + > PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) > + }, > { > .vendor_id = 0 > } > -- > 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH V5] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-10 12:27 ` [dpdk-dev] [PATCH V4] " Raja Zidane 2021-11-10 12:47 ` Tal Shnaiderman 2021-11-11 11:11 ` [EXT] " Akhil Goyal @ 2021-11-11 13:51 ` Raja Zidane 2021-11-12 8:43 ` [EXT] " Akhil Goyal 2 siblings, 1 reply; 12+ messages in thread From: Raja Zidane @ 2021-11-11 13:51 UTC (permalink / raw) To: dev; +Cc: Matan Azrad Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane <rzidane@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> Acked-by: Tal Shnaiderman <talshn@nvidia.com> --- V2: fixed checkpatch warning. V3: fixed doc. V4: fixed commit log. V5: fixed doc. doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst index 9bd8c6fe85..af85fd2f8f 100644 --- a/doc/guides/cryptodevs/mlx5.rst +++ b/doc/guides/cryptodevs/mlx5.rst @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: should not be specified. All the device ports should set it in order to move to operational mode. + For BlueField2, the internal ports in the ARMs system should also be set. - Query CRYPTO_OPERATIONAL register to make sure the device is in Operational mode. @@ -141,6 +142,8 @@ Supported NICs -------------- * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) +* Mellanox\ |reg| BlueField 2 SmartNIC +* Mellanox\ |reg| ConnectX\ |reg|-6DX Limitations @@ -155,10 +158,16 @@ Limitations Prerequisites ------------- +FW Prerequisites +~~~~~~~~~~~~~~~~ + +- xx.31.0328 for ConnectX6. +- xx.32.0108 for ConnectX6DX and BlueField2. + Linux Prerequisites ~~~~~~~~~~~~~~~~~~~ -- Mellanox OFED version: **5.3** +- Mellanox OFED version: **5.3**. see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. - Compilation can be done also with rdma-core v15+. diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 01923e2deb..393ff492ef 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -291,6 +291,7 @@ New Features * **Updated Mellanox mlx5 crypto driver.** * Added Windows support. + * Added support for Bluefield2 and ConnectX6-DX. * **Updated NXP dpaa_sec crypto PMD.** diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 3caa22f35f..47da3d115b 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -994,6 +994,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = { RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_CONNECTX6) }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) + }, + { + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, + PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) + }, { .vendor_id = 0 } -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [EXT] [PATCH V5] crypto/mlx5: support BF2 and ConnectX6-DX devices 2021-11-11 13:51 ` [PATCH V5] " Raja Zidane @ 2021-11-12 8:43 ` Akhil Goyal 0 siblings, 0 replies; 12+ messages in thread From: Akhil Goyal @ 2021-11-12 8:43 UTC (permalink / raw) To: Raja Zidane, dev; +Cc: Matan Azrad > Starting from FW version xx.32.0108. version, the BlueField2 and > ConnextX6-DX adapters support crypto operations. > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane <rzidane@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> > Acked-by: Tal Shnaiderman <talshn@nvidia.com> > --- > V2: fixed checkpatch warning. > V3: fixed doc. > V4: fixed commit log. > V5: fixed doc. > doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- > doc/guides/rel_notes/release_21_11.rst | 1 + > drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ > 3 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/cryptodevs/mlx5.rst > b/doc/guides/cryptodevs/mlx5.rst > index 9bd8c6fe85..af85fd2f8f 100644 > --- a/doc/guides/cryptodevs/mlx5.rst > +++ b/doc/guides/cryptodevs/mlx5.rst > @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: > should not be specified. > > All the device ports should set it in order to move to operational mode. > + For BlueField2, the internal ports in the ARMs system should also be set. Changed ARMs -> ARM as reported by spell check. Applied to dpdk-next-crypto ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-11-12 8:43 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-11-07 16:22 [dpdk-dev] [PATCH] crypto/mlx5: support BF2 and ConnectX6-DX devices Raja Zidane 2021-11-07 16:26 ` Raja Zidane 2021-11-07 17:29 ` [dpdk-dev] [PATCH V2] " Raja Zidane 2021-11-07 17:44 ` Thomas Monjalon 2021-11-07 19:03 ` Tal Shnaiderman 2021-11-08 13:18 ` [dpdk-dev] [PATCH V3] " Raja Zidane 2021-11-08 14:03 ` Tal Shnaiderman 2021-11-10 12:27 ` [dpdk-dev] [PATCH V4] " Raja Zidane 2021-11-10 12:47 ` Tal Shnaiderman 2021-11-11 11:11 ` [EXT] " Akhil Goyal 2021-11-11 13:51 ` [PATCH V5] " Raja Zidane 2021-11-12 8:43 ` [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).