From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 464557D4F for ; Wed, 23 Aug 2017 23:35:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CD55620E29; Wed, 23 Aug 2017 17:35:18 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 23 Aug 2017 17:35:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=AlyQPfR0cwGVSYA p/TSTaALxmXiVaA2ZMKXt4ciDKkY=; b=hK/BMkag6wxcgOaUX9lJaP345Qppo7y 6RUPNXa+vyvh8ZIr6BR/EDBPDZ7lFFhlgFaraWuwRWiIbfQW+Y3u4TPiW3s3kWaA a/+gHwg1rro2H2d9sJ2TVTC8gEr5nwcAt+cUiSVob1TcearRwpLoHRhGUlRMfJWg LZbGtDC/nM4s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=AlyQPfR0cwGVSYAp/TSTaALxmXiVaA2ZMKXt4ciDKkY=; b=jyXtdEhn 4zgBEnVQvu3YHM6hbb6RtufqovRmZBdMvQZx/SA8T2FrG2YeUdIp47bNeRM3jX1J GMbiTLWqUFLb7/OxoGWWaeAHTwBXR2tYWFEBbnivfgd7WEzeJa3hQ7KqTl9+Zcxy pLz1+wr18Hv3yEyCPxUOom85I15/9mv2EEE/BrBPuZyO+vOJptkHiTFzv1rii5i2 7hyUA+PdwJz2roAd0gw1k1OVoMnLUsuN7SVnkHwGtIG8xCgz5yd4zwqs1iUbvugq NV2RCC4CbjsyQY4uAnGb7WCxQnc1s8Tc1E05JqxzhgVdn9WL/q9yOpsBZHWjye7K YwfgfE6msppAMw== X-ME-Sender: X-Sasl-enc: nd7ALH+w/hhZwYXi57SEECgf/ODsnvddk3i+ymK95HjX 1503524118 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8474E7E7AD; Wed, 23 Aug 2017 17:35:18 -0400 (EDT) From: Thomas Monjalon To: "David Harton (dharton)" Cc: dev@dpdk.org Date: Wed, 23 Aug 2017 23:35:17 +0200 Message-ID: <3182064.VHB3C4Eh1Z@xps> In-Reply-To: <840715e081a542788c217ef639dac766@XCH-RCD-016.cisco.com> References: <20170823011937.37579-1-dharton@cisco.com> <3459676.trPQTB1ucG@xps> <840715e081a542788c217ef639dac766@XCH-RCD-016.cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 21:35:19 -0000 23/08/2017 23:27, David Harton (dharton): > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 23/08/2017 14:18, David Harton (dharton): > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 23/08/2017 04:55, David Harton: > > > > > rte_eth_stats_get() unconditonally would set rx_nombuf even if the > > > > > device was setting the value. A check has been added in > > > > > rte_eth_stats_get() to leave the device value in-tact when non-zero. > > > > > > > > If we get this counter from stats->rx_nombuf, why keeping > > > > dev->data->rx_mbuf_alloc_failed ? > > > > We could rework other PMDs to not use this global variable. > > > > It is inconsistent to use it for some PMDs but not all. > > > > And it seems not used outside of PMDs. > > > > > > Are you also asking to remove dev->data->rx_mbuf_alloc_failed as well > > since we will have an ABI breakage anyway? > > > > Not asking, just giving my thought :) > > I did some more digging. For this count it looks like some devices: > - have their own internal version > - have a count shared with the pf > - rely on this field to maintain the count > - don't count this failure at all :( > > With that said I'd like to keep with the requested changes. > > Thoughts? I don't see how it is a problem for removing dev->data->rx_mbuf_alloc_failed. If this field is used, we just have to replace it by a PMD internal variable. Isn't it?