Re: [PATCH 2/2] test: enable most driver tests on Windows

[Thomas Monjalon <thomas@monjalon.net>]

29/03/2022 14:10, Tyler Retzlaff:
> On Tue, Mar 29, 2022 at 01:29:55PM +0200, Thomas Monjalon wrote:
> > 29/03/2022 11:32, Tyler Retzlaff:
> > > On Tue, Mar 29, 2022 at 11:12:21AM +0200, Thomas Monjalon wrote:
> > > > 29/03/2022 11:02, Tyler Retzlaff:
> > > > > enable most of the driver tests to run on windows, most tests will be
> > > > > skipped since the drivers themselves are not available on windows.
> > > > [...]
> > > > >  if not is_windows
> > > > >      driver_test_names += [
> > > > > -            'cryptodev_aesni_mb_autotest',
> > > > > -            'cryptodev_aesni_gcm_autotest',
> > > > > -            'cryptodev_cn9k_autotest',
> > > > > -            'cryptodev_cn10k_autotest',
> > > > > -            'cryptodev_dpaa_sec_autotest',
> > > > > -            'cryptodev_dpaa2_sec_autotest',
> > > > > -            'cryptodev_null_autotest',
> > > > > -            'cryptodev_openssl_autotest',
> > > > >              'cryptodev_openssl_asym_autotest',
> > > > > -            'cryptodev_qat_autotest',
> > > > > -            'cryptodev_sw_armv8_autotest',
> > > > > -            'cryptodev_sw_kasumi_autotest',
> > > > > -            'cryptodev_sw_mvsam_autotest',
> > > > > -            'cryptodev_sw_snow3g_autotest',
> > > > > -            'cryptodev_sw_zuc_autotest',
> > > > > -            'dmadev_autotest',
> > > > >              'eventdev_selftest_octeontx',
> > > > >              'eventdev_selftest_sw',
> > > > > -            'rawdev_autotest',
> > > > >      ]
> > > > 
> > > > Please could you mention the reason for keeping few tests 
> > > > in the conditional list?
> > > 
> > > i indicated in the cover for the series.
> > > 
> > > * remaining driver tests require further investigation and will not be
> > >   addressed in this series.
> > 
> > Does it mean you did not try to run these tests?
> > Or did you see some issues to enable them?
> 
> cryptodev_openssl_asym_autotest
>   test fails because it does not bother checking to see if required
>   driver is available ias the other cryptodev tests do.
> 
> eventdev_selftest_octeontx, eventdev_selftest_sw
>   because it has a dependency on eventdev library which doesn't build
>   on windows.

It should be handled in the meson file with a condition
"if dpdk_conf.has('RTE_LIB_EVENT')"

> the dump_xxx tests were not evaluated, i did not try to build them or
> run them.

OK, they are all useful information, please add remaining issues
in the commit log, if not fixed before.