* RE: [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface parameter
[not found] <20220829084956.288858-1-arshdeep.kaur@intel.com>
@ 2022-09-06 16:17 ` Pattan, Reshma
2022-09-12 12:53 ` [PATCH v2] dumpcap: fix interface parameter check Arshdeep Kaur
1 sibling, 0 replies; 6+ messages in thread
From: Pattan, Reshma @ 2022-09-06 16:17 UTC (permalink / raw)
To: Kaur, Arshdeep, dev; +Cc: Stephen Hemminger
> -----Original Message-----
> From: Kaur, Arshdeep <arshdeep.kaur@intel.com>
> Subject: [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface
> parameter
>
> Bug: IF condition to handle -i parameter was not incorrect.
>
Hi ,
Remove SCSY* from heading
No need to add *Bug word in the heading.
Heading should have the example name that you are fixing that is "dumpcap".
So, Heading can be as simple as "dumpcap: fix interface parameter check"
Need to add fixes line to the commit message for any fix. Refer the section 7.7 in the link on how to add the fixes line. https://doc.dpdk.org/guides/contributing/patches.html
With these changes you can send the V2.
Thanks,
Reshma
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] dumpcap: fix interface parameter check.
[not found] <20220829084956.288858-1-arshdeep.kaur@intel.com>
2022-09-06 16:17 ` [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface parameter Pattan, Reshma
@ 2022-09-12 12:53 ` Arshdeep Kaur
2022-09-12 13:06 ` Pattan, Reshma
2022-09-15 8:16 ` [PATCH v3] " Arshdeep Kaur
1 sibling, 2 replies; 6+ messages in thread
From: Arshdeep Kaur @ 2022-09-12 12:53 UTC (permalink / raw)
To: dev
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index a6041d4ff4..8972c45a71 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -240,7 +240,7 @@ static void select_interface(const char *arg)
{
uint16_t port;
- if (strcmp(arg, "*"))
+ if (!strcmp(arg, "*"))
select_all_interfaces();
else if (rte_eth_dev_get_port_by_name(arg, &port) == 0)
add_interface(port, arg);
--
2.37.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] dumpcap: fix interface parameter check.
2022-09-12 12:53 ` [PATCH v2] dumpcap: fix interface parameter check Arshdeep Kaur
@ 2022-09-12 13:06 ` Pattan, Reshma
2022-09-15 8:16 ` [PATCH v3] " Arshdeep Kaur
1 sibling, 0 replies; 6+ messages in thread
From: Pattan, Reshma @ 2022-09-12 13:06 UTC (permalink / raw)
To: Kaur, Arshdeep, dev
> -----Original Message-----
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> Sent: Monday, September 12, 2022 1:53 PM
> To: dev@dpdk.org
> Subject: [PATCH v2] dumpcap: fix interface parameter check.
>
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Can you add short commit message description .
Thanks,
Reshma
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] dumpcap: fix interface parameter check.
2022-09-12 12:53 ` [PATCH v2] dumpcap: fix interface parameter check Arshdeep Kaur
2022-09-12 13:06 ` Pattan, Reshma
@ 2022-09-15 8:16 ` Arshdeep Kaur
2022-09-15 8:44 ` Pattan, Reshma
1 sibling, 1 reply; 6+ messages in thread
From: Arshdeep Kaur @ 2022-09-15 8:16 UTC (permalink / raw)
To: dev
Correction in handling 'IF' condition for -i parameter.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index a6041d4ff4..8972c45a71 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -240,7 +240,7 @@ static void select_interface(const char *arg)
{
uint16_t port;
- if (strcmp(arg, "*"))
+ if (!strcmp(arg, "*"))
select_all_interfaces();
else if (rte_eth_dev_get_port_by_name(arg, &port) == 0)
add_interface(port, arg);
--
2.37.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v3] dumpcap: fix interface parameter check.
2022-09-15 8:16 ` [PATCH v3] " Arshdeep Kaur
@ 2022-09-15 8:44 ` Pattan, Reshma
2022-10-31 13:45 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Pattan, Reshma @ 2022-09-15 8:44 UTC (permalink / raw)
To: Kaur, Arshdeep, dev
> -----Original Message-----
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> Subject: [PATCH v3] dumpcap: fix interface parameter check.
>
> Correction in handling 'IF' condition for -i parameter.
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dumpcap: fix interface parameter check.
2022-09-15 8:44 ` Pattan, Reshma
@ 2022-10-31 13:45 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2022-10-31 13:45 UTC (permalink / raw)
To: Kaur, Arshdeep; +Cc: dev, Pattan, Reshma
15/09/2022 10:44, Pattan, Reshma:
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> >
> > Correction in handling 'IF' condition for -i parameter.
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Sorry for not noticing, it was merged in DPDK 22.11-rc1.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-31 13:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220829084956.288858-1-arshdeep.kaur@intel.com>
2022-09-06 16:17 ` [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface parameter Pattan, Reshma
2022-09-12 12:53 ` [PATCH v2] dumpcap: fix interface parameter check Arshdeep Kaur
2022-09-12 13:06 ` Pattan, Reshma
2022-09-15 8:16 ` [PATCH v3] " Arshdeep Kaur
2022-09-15 8:44 ` Pattan, Reshma
2022-10-31 13:45 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).