[dpdk-dev] [PATCH 1/2] pipeline: fix incorrect resource free function

[dpdk-dev] [PATCH 1/2] pipeline: fix incorrect resource free function

[Cristian Dumitrescu]

Due to a typo, the selector_free() function incorrectly takes an early
return when the selectors array is non-NULL, as opposed to the other
way around.

Coverity issue: 371912
Fixes: cdaa937d3eaab ("pipeline: support selector table")

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 lib/pipeline/rte_swx_ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c
index f1480bc27b..dc093860de 100644
--- a/lib/pipeline/rte_swx_ctl.c
+++ b/lib/pipeline/rte_swx_ctl.c
@@ -815,7 +815,7 @@ selector_free(struct rte_swx_ctl_pipeline *ctl)
 {
 	uint32_t i;
 
-	if (ctl->selectors)
+	if (!ctl->selectors)
 		return;
 
 	for (i = 0; i < ctl->info.n_selectors; i++) {
-- 
2.17.1

[dpdk-dev] [PATCH 2/2] examples/pipeline: fix incorrect array out of bounds check

[Cristian Dumitrescu]

Fix the incorrect array out of bounds check within the function
pipeline_selector_group_member_read().

Coverity issue: 371911
Fixes: 598fe0dd0d8e3 ("examples/pipeline: support selector table")

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/pipeline/cli.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index f67783c8fa..a29be05ef4 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -1511,7 +1511,7 @@ pipeline_selector_group_member_read(const char *string,
 		if (!token || token_is_comment(token))
 			break;
 
-		if (n_tokens > GROUP_MEMBER_INFO_TOKENS_MAX)
+		if (n_tokens >= GROUP_MEMBER_INFO_TOKENS_MAX)
 			goto error;
 
 		token_array[n_tokens] = token;
-- 
2.17.1

Re: [dpdk-dev] [PATCH 2/2] examples/pipeline: fix incorrect array out of bounds check

[Thomas Monjalon]

12/07/2021 20:18, Cristian Dumitrescu:
> Fix the incorrect array out of bounds check within the function
> pipeline_selector_group_member_read().
> 
> Coverity issue: 371911
> Fixes: 598fe0dd0d8e3 ("examples/pipeline: support selector table")
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Pathset applied, thanks.