From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 901925679 for ; Fri, 22 Jul 2016 00:31:10 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id q128so36647707wma.1 for ; Thu, 21 Jul 2016 15:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5tHez5h3EHYdU/7I2yEwXLxYAtZ5on5IQwondTs30Cs=; b=SXqpPTf9gmPXuOUjJwU5rbmTOwa6dH6KPP0gjuB9vFDy0jVsEFbd+nZL1nNOU0nBz1 /fqsvv9Kqpofevb5NhC4+s5KjhRSQHrhmYlEJIQY1AldfuJxHkpjc7ckBoPVzkCjNXIv gWJOFef62KVd8jAUi54jl4z/u6Rx9grvmTfCoQBU7I8OKYwTTo2R6+ghJv6JMg+PU0wV Al+oG74kL6KaULMsG1fhkoQtgtt2kXDejetMgPhmTOR7fu/i0yHAQrMABiMFXgUtgt7a qPG8UWm1HpYJfIaslmbhgyBDhwMkznzNye9r3gt8vxPP8WNz6InrN1J3h6pwIlHMd3M7 +4cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5tHez5h3EHYdU/7I2yEwXLxYAtZ5on5IQwondTs30Cs=; b=Ji6p4JKvr9hi/+0KlsP746/Ea57qAr0jYjOsHbdlybj1kc4EjcYZwM54EvXo1RRR8l fx2P/8ntblU9mCpBpy0acrLM89yE36ZwyIqiQvTSOn+Ct2022ZtdjR1/zfRe8lrr51iI pIPKEIE/vJMqJEAoME92s4/RikbNUJ6fXlf6whfQCdQ5KmDMS7gZ57jQKjRso0MZlHxJ pKvG378Po2uPJdoBTq0PAU59VQbd+FUwB0nazfOCAAFQn/FiMv3/pJ74CCRQT+t6xNBI GiCnLd+HTywDDoE9o96Ne6eOUY0tdnltFu4khlSNR2h0jUOnncrP4qk1v+vBIwptVw9w hKbw== X-Gm-Message-State: ALyK8tL5XHb7ZT0Y86HxOaJev23YmFQRpsogS9oPb9S0ejZD3qDTImFMzy/egKUGQr8lpxNQ X-Received: by 10.28.131.199 with SMTP id f190mr21300494wmd.30.1469140270255; Thu, 21 Jul 2016 15:31:10 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b203sm7742040wmh.20.2016.07.21.15.31.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 15:31:09 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org Date: Fri, 22 Jul 2016 00:31:08 +0200 Message-ID: <31963607.SkieP2J2tS@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1468895993-3292-1-git-send-email-yuanhan.liu@linux.intel.com> References: <95aa6068-2444-304e-2dc1-ff1975f6132a@6wind.com> <1468895993-3292-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix crash on null dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 22:31:10 -0000 2016-07-19 10:39, Yuanhan Liu: > The rxq/txq for the queue_release callback could be NULL, say when > rte_eth_dev_configure() fails that the queue is not setup at all. > > Do a simple NULL check would fix the crash issue. > > Fixes: 01ad44fd374f ("net/virtio: split Rx/Tx queue") > > Reported-by: Olivier Matz > Signed-off-by: Yuanhan Liu Applied, thanks