DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] build: support i686 target on x86 64-bit hosts
Date: Fri, 06 Nov 2020 18:54:21 +0100
Message-ID: <3197660.YvmjQU8Io0@thomas> (raw)
In-Reply-To: <CADyeNECcDFqOJXnwJTVjC7SLwPJsGG-zWz66v6Xgx9AaHkBeHg@mail.gmail.com>

06/10/2020 16:35, Lance Richardson:
> On Tue, Oct 6, 2020 at 4:30 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 25/09/2020 15:27, Lance Richardson:
> > > Bruce Richardson wrote:
> > > > On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote:
> > > > > Add meson cross files for building i686 targets using gcc on x86_64
> > > > > linux hosts.
> > > > >
> > > > > Uusage example:
> > > > >
> > > > >     meson --cross-file config/x86/cross-i686-linux-gcc build-i686
> > > > >     ninja -C build-i686
> > > > >
> > > > > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> > > > > ---
> > > > > Red Hat distros use a different name for the 32-bit pkg-config
> > > > > command from most other distros, maybe there is a better way
> > > > > to handle this than using separate files.
> > > > >
> > > > > Others will probably have better naming suggestions for the files.
> > > > >
> > > > Just to note that rather than using cross-files, building i686 on x86_64
> > > > should be possible by just setting environment variables.
> > > >
> > > > For example, on Ubuntu 20.04, this works for me:
> > > >
> > > > PKG_CONFIG_LIBDIR=/usr/lib/i386-linux-gnu/pkgconfig CFLAGS='-m32' LDFLAGS='-m32' meson --werror build-32bit
> > > > ninja -C build-32bit/
> > > >
> > > > For Fedora or Redhat system the PKG_CONFIG_LIBDIR will be different (I
> > > > think just /usr/lib/pkgconfig), but the rest should work identically.
> > >
> > > Thanks, that does work, although I'll have some trouble remembering it
> > > for future
> >
> > Would it help to have this command in devtools/test-meson-builds.sh ?
> >
> 
> I think it would help, although using cross-files was suggested when
> that was proposed here:
>      http://patchwork.dpdk.org/patch/69067/
> 
> Having the i686 build command in a document like the GSG might be
> helpful as well.
> 
> Ideally it seems there should be a consistent way to build for different
> architectures using meson, I think we mostly have that now with the
> native architecture being used by default and otherwise using a
> cross-file found under config/<arch>/.

Bruce added the doc and the command in test-meson-builds.sh.
Are we fine now? Should we mark this patch as rejected?





  reply	other threads:[~2020-11-06 17:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 16:37 Lance Richardson
2020-09-25  9:13 ` Bruce Richardson
2020-09-25 13:27   ` Lance Richardson
2020-09-25 13:44     ` Bruce Richardson
2020-09-25 14:08       ` Lance Richardson
2020-09-25 14:28         ` Bruce Richardson
2020-09-25 14:48           ` Ferruh Yigit
2020-10-06  8:30     ` Thomas Monjalon
2020-10-06 14:35       ` Lance Richardson
2020-11-06 17:54         ` Thomas Monjalon [this message]
2020-11-06 18:02           ` Lance Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3197660.YvmjQU8Io0@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=lance.richardson@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git