From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2301EA0C41; Tue, 19 Oct 2021 17:20:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A74E84117E; Tue, 19 Oct 2021 17:20:25 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id CAD3C41171; Tue, 19 Oct 2021 17:20:23 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6CFBB5C01D3; Tue, 19 Oct 2021 11:20:23 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Tue, 19 Oct 2021 11:20:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=lSBtOWZmLieY8xfbbY1egBll63J6u8A 923C3QTpZgpo=; b=0FK76pqg2lpBBxU4ySAzHxNi8Q8dKHGU1Vf4hsDf+oyV8iK G/JE59hFKGlb7pmj3BKYjlBWNVNVotCYOe5dMxmLkoP00aXptKQe2k6wS2Uo3Fq+ NKWk3bSynxfY2Tha/Kd18TJ1L/wdOc2YRqFcYVHOCZxyajiQwgKJ+SIqqAIwHRGP wAtu0a6ovyh/dyHT0VH3/Ob4+DbPbzskLftfySGyYjINwOgqIhKUq8G7FeU0yM+W YkVa7SrShlSaMUm0NkeUJs2CJlSxTnscauEZB4G9mNoC2OcjaW2zqDCwndUBBdtw RVWBdT8MJSghpNMe64oSwPMSacstittffCcRxwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=lSBtOW ZmLieY8xfbbY1egBll63J6u8A923C3QTpZgpo=; b=LahRwUfxzakhRqE7MzBPGe ficECJ292289oDGZrFr5OCS3GZPmoD6NpBJbVZdhu6WThUPVLsR5BeVfJdSXv/bp 5p9mgOCQRbrcPI1owrbD5sISM0RFaCgZmws3X6eedcdPs1qWvrfh+PeJcNTJU5DT q2xcP5OjBkQ4kqL9xpzGejOZW6O4/ugkKhn7zcfG3ygfcgNXDW+BEM5kKAPNe8xK iwJLp3WfVVwxoN4dr4ak2ruT59jaQc2apabsqMthACDwujhgitXwJJ0Vye94PrC2 sVAP5Qdz3bOtWFsGGTpAolELoGq1C4ttZ5vv9nDzBTIZl0TpkxS+J3ZKdP1ZTafw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvvddgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepifgrtoht rghnpgftihhvvghtuceoghhrihhvvgesuhdvheeirdhnvghtqeenucggtffrrghtthgvrh hnpefguefhffelleduueehueetueefgedtieevudduhfegveetuedtleeuffeuheekfeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhhivh gvsehuvdehiedrnhgvth X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 192F821E006E; Tue, 19 Oct 2021 11:20:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1369-gd055fb5e7c-fm-20211018.002-gd055fb5e Mime-Version: 1.0 Message-Id: <31a52f69-4a8a-4cc8-8445-45344ff4eb2c@www.fastmail.com> In-Reply-To: <20211005155435.279043-3-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211005155435.279043-1-xuemingl@nvidia.com> <20211005155435.279043-3-xuemingl@nvidia.com> Date: Tue, 19 Oct 2021 17:19:49 +0200 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Xueming(Steven) Li" , dev@dpdk.org Cc: "Thomas Monjalon" , "David Marchand" , stable@dpdk.org Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v1 2/3] devargs: make bus key parsing optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 5, 2021, at 17:54, Xueming Li wrote: > Global devargs syntax is used as device iteration filter like > "class=vdpa", a devargs without bus args is valid from parsing > perspective. > > This patch makes bus args optional. > > Fixes: d2a66ad79480 ("bus: add device arguments name parsing") > Cc: stable@dpdk.org I agree with the change, but I'm not sure it should go into stable. The question goes further than that: is there a spec describing the valid syntax to users, that would allow to say the current parsing is buggy? I haven't found it in the doc. If there is a change such as this one, it should also be notified in the release notes. This is user-facing. So, not saying you should do it and not part of this patch, but a doc might help in doc/guides/howto maybe. The general grammar of a devargs could be formally described (in BNF?). Each layers should document their supported keys as well. Not sure it would be better gathered in a single file or within each driver. Now that the global syntax has been enabled for users, it should be documented. > > Signed-off-by: Xueming Li For this patch and beside the stable considerations, Reviewed-by: Gaetan Rivet -- Gaetan Rivet