From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2D3802B94 for ; Fri, 16 Nov 2018 16:44:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2018 07:43:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,240,1539673200"; d="scan'208";a="105172477" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.124]) ([10.237.220.124]) by fmsmga002.fm.intel.com with ESMTP; 16 Nov 2018 07:43:57 -0800 To: Thomas Monjalon Cc: "Richardson, Bruce" , "Wiles, Keith" , Stephen Hemminger , dev , "Mcnamara, John" , "De Lara Guarch, Pablo" , "Hunt, David" , "Awal, Mohammad Abdul" , "Yigit, Ferruh" References: <59AF69C657FD0841A61C55336867B5B0726E11E8@IRSMSX103.ger.corp.intel.com> <2017620.fyvpj9GtK5@xps> From: "Burakov, Anatoly" Message-ID: <31bc1c07-0c41-1a53-445b-3f56302e35a9@intel.com> Date: Fri, 16 Nov 2018 15:43:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2017620.fyvpj9GtK5@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2018 15:44:01 -0000 On 16-Nov-18 2:55 PM, Thomas Monjalon wrote: > 16/11/2018 15:37, Burakov, Anatoly: >> On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: >>> From: Wiles, Keith >>>>> On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly >>>>> On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: >>>>>> Anatoly Burakov wrote: >>>>>>> This is a placeholder for Python library abstracting away many of >>>>>>> mundane details DPDK configuration scripts have to deal with. We >>>>>>> need __init__.py file to make the subdirectory a package so that >>>>>>> Python scripts in usertools/ can find their dependencies. >>>>>>> >>>>>>> Signed-off-by: Anatoly Burakov >>>>>> >>>>>> Doing this a better than current code, but can we go farther? >>>>>> I would like DPDK to get out of doing binds directly and switch to >>>>>> using driverctl which also handles persistent rebind on reboot. >>>>> >>>>> Wasn't the objection that it's not available everywhere? (for the >>>>> record, i have no horse in the race - i don't much care exactly how >>>>> it's done) >>>> >>>> If it works on FreeBSD and Linux then I am all for it. On windows does it >>>> support this method too? >>> >>> Binding and unbinding is completely different on each OS. FreeBSD has no overlap >>> of scripts with Linux, so replacing some of our tools with driverctl won't affect >>> that OS. >>> >>> /Bruce >> >> ...however, we could abstract that away in our tools, and use >> OS-appropriate tools independently of what we're running on. There could >> still be value in fixing devbind everyone knows and love to work on all >> OS's without too much hassle :) > > Yes, easier script is always better. > > Another thought, I would like we think about integrating binding/unbinding > code inside EAL and bus drivers, and manage it via the PMDs. > There could be an option to bind on scan and unbind on rte_dev_remove. > I didn't like it back when it was a thing, and i don't particularly like this idea now, to be honest. Port binding should not be under purview of the application, but is firmly in the domain of system administrator IMO. I don't think it's our place to change system configuration while we're running. -- Thanks, Anatoly