From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 487C842D16; Wed, 21 Jun 2023 18:52:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38EAF4068E; Wed, 21 Jun 2023 18:52:40 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2043.outbound.protection.outlook.com [40.107.100.43]) by mails.dpdk.org (Postfix) with ESMTP id B11EA4003C for ; Wed, 21 Jun 2023 18:52:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kCNIYkJqSplYn2916JQDhowUu+0tMWkcYnHoyXA51qfb//2I5BV7tbzx4FReKDs44jgRbPDGfIE6Z6jCrmOfGCAlEYSpuCFE89ZEnTo4mEO0HGLTYCqJ9Xp/378T9JDtAwCbCTNmkAsKY10O7DzsPHj7XcKeFdkdPftDnNWISry7LDFPbBDGda6u1aJwLQ07gMOoJYYD91S7qvAbqKypqLWTzqMMCldRNiPVgECSJupkexev3kYAd0ibW+Eqmqa/1DyRb4ljlYRrDgYaaaPO0SdnwtcQsaCa97EwIltNsR+9R31jtfqaeV+G0DCBl8+oOzdfQLu50ug3PZUjepfkAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vgxbcKAsOL1d2SO9vC5oVVDoo5n3ZA8lGvKrdMxCyPI=; b=hWFOfxX+nR+JVRxLYgL8hyslN7ozZnp4LfS5PlheO1FOuRgDhyKS1fSUu/VYjCecqbtoY3/4sgTPx22qB8HY/wiB4SNH2PQJwTeSBNtsn/fxYguDe7qdP69SnGC+rrCV5Ng70PxY0BV5L68L5KfT/1O5pgXsNN3bzVizP5HKoezrPVtGu/KqAjmbTdosL9pHr7G5rrz5bJksO3cqsvS/42HAU8E4LZDzmtQNRWzp1Ug38IuCXIgsrMaZD9N9sk84McQmwn6M2+CRHMAL94yj4kgVrYgBc/f7QPiDgl7EJVs+N1V4sVIOCq7D+0VrPVH81h+3bDPZxGBwPhsrLJ7dvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vgxbcKAsOL1d2SO9vC5oVVDoo5n3ZA8lGvKrdMxCyPI=; b=lM0UUeqPHqQJwaiQFHfJVlr2+JBg+EnD0fzfsrBxOoJaoyAJkrCTCjPuncND+DZ/oH3VK8Bz1K8Ht3L6pIOSe48I6OmcJOkHZ/DKAV6w21eHY4zwUwyOyEhyGKZS13UGa/lYR2O4Kme0oYkw6wcLglBDyuQ/SuIrgmRZ37Rx6qs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Wed, 21 Jun 2023 16:52:37 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 16:52:37 +0000 Message-ID: <31d362d3-3c19-a739-038d-012a40a715ab@amd.com> Date: Wed, 21 Jun 2023 17:52:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko , Denis Pryazhennikov , Andy Moreton References: <20230601195538.8265-1-ivan.malov@arknetworks.am> <20230607130245.8048-1-ivan.malov@arknetworks.am> <20230607130245.8048-2-ivan.malov@arknetworks.am> From: Ferruh Yigit Subject: Re: [PATCH v4 01/34] common/sfc_efx/base: update MCDI headers In-Reply-To: <20230607130245.8048-2-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0455.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::35) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4488:EE_ X-MS-Office365-Filtering-Correlation-Id: 3df9cba7-8521-4e44-62f2-08db7277eb1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1VypNXT/6Gvsdu+dWoPgLGblYwD1hqNjmZ9ICq1Lw25DyBN14bHNm1uaI4y03lFRxflNXCc1cZl/+MMIdIP+mEPxRUIQKoVyMYlT6Jz4dBaLWqDpOHd4lOOE1nVk511IijDJT/0xlL76QA+suaRU4kIIV6ixdPSENyf4x3wBMAGgUUlFl0X+JJzqshkoipssQ5mHEI91hmhpNQwnChADqF+COqtmlAjNqrMnWiiSWYmePWUWkPxfkcwCbI4HL7IMFX/lf6FkSavkqu44C/Yr/pr7U1/iqGqxeLPhSgL97NLZE5bU2iUCWF5FohCkyuuHrIBbYuGfwULzQZ6a9PpGaBsqsSZl7zmecBZsl4oYoz+Ip2HqGo0E6IrSDxOOAVdGCLgoqjNsu+NwOXMSk6kVr4BS5sA8iV/AOuS/hQuGM+VBKSP4dC8XgdtBWXbl8H8Bpz1WmEla3aBT1ykfpTwTOORLXE0Tyx5uUXK1me2SSvDldHJHmXSDrwbXdZ5sbQJNEgMa+ctgNrUHxbm+TB4/Lrz1hmNZX0k9pPcKgZ4ULV7lp+0KrGvW2trAynp78nFLArVe3LFM2Nt+CES375bsB5pzwZlJ6h1VboXU3/dXUg6bu9UzrwThLtR+jBU3KFKgTImbZoKDoPO9ASShxRbADw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199021)(53546011)(31686004)(36756003)(44832011)(5660300002)(38100700002)(41300700001)(66476007)(8676002)(4326008)(8936002)(86362001)(31696002)(316002)(66946007)(6506007)(6486002)(2906002)(6512007)(15650500001)(186003)(26005)(478600001)(83380400001)(54906003)(66556008)(2616005)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3Vwc0txM3dGSXk1Vk9zNTZwUGFkQ2NNRUpGQWVHVFNaTDRjTUcwQTd0N2gz?= =?utf-8?B?Qm4xYWRaU2I3K2FCTjI5Z2x5N2lYc1BHUll1Zk52OU81OGgxQzRHVGZVbjM5?= =?utf-8?B?U0ZpM1NJdlRoREZCZ0xuQnhxcDdoTDFwUXZoYzFBTng4NkF5T0J0NFd0eWs5?= =?utf-8?B?MlltRkE0Yk1KdDlHYzB2Y2VUS094NHpmMTNnbnFvYUF1SjhnRG5HOEsvM3JH?= =?utf-8?B?OUJUNEdGME1TNjRlYndGVHlYaFczT1FoOWNRQm92cnZLeG1rSDhvRlBIUmR6?= =?utf-8?B?OE1DdlAvWGp4MU0yeUFBR1RyR20yYllWNCs2S0VMQWlPYm9hRWFLdjhQS011?= =?utf-8?B?bGhzd2RqRllkekE1QUVaZEhXaTFsUW11N2pkaXJhY1NLbWtQNlNacXdJcmdp?= =?utf-8?B?MndJTFNnMnlvT0RGWUpldjZZMElSdjNjeldkOTQ3ZkhkR0E1N1RxTHJBeUVQ?= =?utf-8?B?Q3d1OHczcVBUR1ZxRkFTOEVmdDRxZVVqTDgwR1F0SjhiR04xTFF4NlBOYktv?= =?utf-8?B?VWNnVnR0Z2EyMnJHOE92aWJCNngzV0tVMzdpZkJ6NUdHM2c3bmdPRzNpN3NV?= =?utf-8?B?TWxMYkQyR1RYeTJXcUxxNW1PRzZyOVJxMkc0UGFTem10aXdvd3FYWWhYT3dv?= =?utf-8?B?SThBYVhoR3AvaWlPa3EvcXNML3B5aDBOQnhNaVkzT2VGQWZkckdSNUVyYThZ?= =?utf-8?B?bWNySHVOUldNdndLaUZ6MXNQRnM1alZXWWN2OTE0UlRaZFVGT3NiVXdxVU1K?= =?utf-8?B?Qm9hVlhOU3VFQk81NGc2N3lmdzcyWFJDV0VvYVBxNjZMKys5ZmpKR216NVI0?= =?utf-8?B?VGk0N2NrQTFBL25kNklqVnd4cktJZ1ZYY3JaRG5iTEJiUjM3UUxwQVl5SWls?= =?utf-8?B?eWRXSTRjVzYwWkNDcW1wZDdzWnpsRkFGOHJUUVBIcUgralY3em1kSHFoaUkv?= =?utf-8?B?aVR0WmRsbndTbWIvcTFnNWRkLzdYSmZCLzZnQXVMSWQyeFMrc1gvdjlhUExG?= =?utf-8?B?cDlDdVZRS21VZ3VjZFRsV1MvRDdpK3BDcUw4blZ6ODVwN1FtVDVIM3Y5V1M2?= =?utf-8?B?MHllSGFJaFowb0dtMkJSZXZkMTNGTExVY1p4eDVoT1p4b2laOENwRld3b1hz?= =?utf-8?B?TWNLbnJkUStqcmJCQUZCNjI2T08rYXRWYW5heW5mVjc1WmJmWkw4RlhjY2Vu?= =?utf-8?B?R0UvV0s5RnpnOWdRK2dZbEQvcDgxM3VCMHBuWVVoc3VaWVh0MFNIbGVubm9T?= =?utf-8?B?cE83aVdscmZnOUdCU09LNjNZT0hXWStFUytXK2dmZUh0d1ZGQUszbUR4ZWNr?= =?utf-8?B?bFFMNVlsek1KQWJoQzJoS1JjbzRpSk5vUDFOWWZPcGE3MFZIV3k5WUo1aCtl?= =?utf-8?B?WGNZZ3lvNzRPeUpPTlRITTNObHpIaWFGUHp4dEVPL0FFdWdja2ZvRVVPQ2dh?= =?utf-8?B?SFdmTnhPSFZjWFhTdkVOTHJDV3FBQkhCdmZzMHlQVDlqRDNOUEhFdmlmeEZj?= =?utf-8?B?QWFFdEtzUWRUd1JubE42MkM3UmZSVjhHS3FSVTZkcmlCRGx3RGxSRVBKSVVN?= =?utf-8?B?WXBIdjVlNTNSRyt0d0tpWjlhblJkaG4rN1VFZlJ0ZjVBVUhoSm9GZHNyYmdU?= =?utf-8?B?YTZlM0pKczNCTm94TVoxclcrNWJaS0RXMWt2UytackVXbk5TUUd5aVplYnRG?= =?utf-8?B?Mm1KaVVGSU0vRXptaWRZNWJZMHprNjR3Uys0QklPNndtcHUxMlFaSjZrZDFZ?= =?utf-8?B?QTZuY1pKR0Z3WnZ4QzlTZWJyNEw1SUtsalJwUGdPT2grUEU0ZUVjeVBHa2lL?= =?utf-8?B?elJ0b1pMOU1IbXZjUDFIT1RubjdTNDRTcHdMQVVGVEoxcU1XcjJBZ0NtdDlD?= =?utf-8?B?UUlVaWpFT2JyWWFtUVJDWExuSEN5UzhtbVREcm0wQjlwSjRyM0lPS0dOQzNX?= =?utf-8?B?MVJIbVVXcEVFdllXa3NVRVJqMGU0L2dNeTVnVVc4NjdaeWd6N3RsTnArYktZ?= =?utf-8?B?MWE1bWhGcTFoUmdlT2NFTjdwc04wd2FQRVFQdUNqTmc2STUzL2l4QXhoZ3l3?= =?utf-8?B?TWhLNjZFVlF3Q1RVcjlSb01zNmF6bVJsZElvWkQzUmQwWWt3eXJ5Z25XYXkw?= =?utf-8?Q?D54hM92JejIx0cmviAKnfyNw+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3df9cba7-8521-4e44-62f2-08db7277eb1d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 16:52:37.5769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tzfEztjyWu8FBo9QgUuRHRNRg0kTLBuAJDLb1FnjUKTLBUMeKiv64jhb6rGlZz0X X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4488 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 2:02 PM, Ivan Malov wrote: > From: Denis Pryazhennikov > > Pickup new FW interface definitions. > > Signed-off-by: Denis Pryazhennikov > Reviewed-by: Ivan Malov > Reviewed-by: Andy Moreton <...> > @@ -9127,15 +10514,13 @@ > /***********************************/ > /* MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS > * Get descriptions for a set of sensors, specified as an array of sensor > - * handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST > - * > - * Any handles which do not correspond to a sensor currently managed by the MC > - * will be dropped from from the response. This may happen when a sensor table > - * update is in progress, and effectively means the set of usable sensors is > - * the intersection between the sets of sensors known to the driver and the MC. > - * > - * On Riverhead this command is implemented as a a wrapper for > - * `get_descriptions` in the sensor_query SPHINX service. > + * handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST. Any handles which do not > + * correspond to a sensor currently managed by the MC will be dropped from from typo "from from" fixed. This is reported by checkpatch. > + * the response. This may happen when a sensor table update is in progress, and > + * effectively means the set of usable sensors is the intersection between the > + * sets of sensors known to the driver and the MC. On Riverhead this command is > + * implemented as a wrapper for `get_descriptions` in the sensor_query SPHINX > + * service. > */ > #define MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS 0x67 > #define MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS_MSGSET 0x67 > @@ -9173,19 +10558,15 @@ > /***********************************/ > /* MC_CMD_DYNAMIC_SENSORS_GET_READINGS > * Read the state and value for a set of sensors, specified as an array of > - * sensor handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST. > - * > - * In the case of a broken sensor, then the state of the response's > - * MC_CMD_DYNAMIC_SENSORS_VALUE entry will be set to BROKEN, and any value > - * provided should be treated as erroneous. > - * > - * Any handles which do not correspond to a sensor currently managed by the MC > - * will be dropped from from the response. This may happen when a sensor table > - * update is in progress, and effectively means the set of usable sensors is > - * the intersection between the sets of sensors known to the driver and the MC. > - * > - * On Riverhead this command is implemented as a a wrapper for `get_readings` > - * in the sensor_query SPHINX service. > + * sensor handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST. In the case of a > + * broken sensor, then the state of the response's MC_CMD_DYNAMIC_SENSORS_VALUE > + * entry will be set to BROKEN, and any value provided should be treated as > + * erroneous. Any handles which do not correspond to a sensor currently managed > + * by the MC will be dropped from from the response. This may happen when a ditto, fixed "from from"