From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2226432FA; Sat, 11 Nov 2023 05:18:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C8F2402A6; Sat, 11 Nov 2023 05:18:38 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2069.outbound.protection.outlook.com [40.107.212.69]) by mails.dpdk.org (Postfix) with ESMTP id 718CC4025C; Sat, 11 Nov 2023 05:18:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eWIVJURQ1B8k6NF9mFx1lgZgVDyu96aaBTVEYU1JU4FAekhVq+P21N+ZUqHk6LrYckFtRuQ6gojbNwIW8HfEZkCb7tqE2zBF2569h5wsNb/3hMcuUTspztTKr6ykJJFBvatSG5NIVIqyTW+8nXa6ozNGl9VnQJseuJilxI3Mdv5/uIdDiCT0ZKfsdlRpL5D1nvT+1f/AZMUt4aXm86nbSJ2ByeTOfjK7ohlGg42oay6aXbNxU4MA3h1gWScNpVL+etU9CZT8Qk3/oMFXbEuUzGM3Z3rLy1CDHu/WYpFHaOVmHAvHDQR6cEfk5Kc50+xWbR3Mk3GrUBQTNidwzlADng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVvfWmPjoxW3H2ph0QFA3aPVUQ0MJxYs8i/krlzGg0Q=; b=eRX+DMPInwhnGSkRwGuIGWnT/ObE4oZeDxRRF9MbFeVoy04wYszzCK4kSLcE9zHIhIoSBITPAhllVr7xG1azHjazhxwHlhPwi/AtjS923W5QIadTvu7zHOrd7+KtdGI3p6fz0p9HNgDcpxpig5TYyBFtcnzhde6gfLwShrPGrQxucvmtqv9cWdJ+Bf0PTZHAa1sCFXDGrA0eH5MtApuw0Jfea9MBjwOFHqpQgVc2qzhTj9lMQJP/88O3TaBzfq6CNiJNss/GlBG9L4+YwwbJo5S5uJCFV6RtlNtA90Lfcaaqt9PbpGLqxzFd5QTXGk/8nt75pQ6Bpf+GMdVmg7DaPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVvfWmPjoxW3H2ph0QFA3aPVUQ0MJxYs8i/krlzGg0Q=; b=hm1PaQYlnriYoDThC/6tuUkXSzzvmZtRxWjhFMQwFcsTgV/jxihy1bu5o3DJ09UmYSoEQJ3UKz7UhIZal5cQMD9GE/zKV+v1Jxeb2c456YaNzu8ThJYUVjG1HBByuWPSv3V17+QN8hD+JHFj6g+bFC7vPX2p7Qr5jCN+jXs0CNg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6564.namprd12.prod.outlook.com (2603:10b6:510:210::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.21; Sat, 11 Nov 2023 04:18:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Sat, 11 Nov 2023 04:18:32 +0000 Message-ID: <31e8f62f-c0f9-4d16-92b0-cec08d73cee0@amd.com> Date: Sat, 11 Nov 2023 04:18:08 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/gve: fix RX buffer size alignment Content-Language: en-US To: Joshua Washington , Junfeng Guo , Jeroen de Borst , Rushil Gupta , Xiaoyun Li Cc: dev@dpdk.org, stable@dpdk.org References: <20231111003410.2950594-1-joshwash@google.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231111003410.2950594-1-joshwash@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6564:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d3bd106-8766-4638-e744-08dbe26d43fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ot8w6/5epAmPZJ+oegRi01rbPv9Hkzh5xAsqxr9cRelTDb27Zw2ZrDQBVtfpxUR96ksKJML/shUgKPdMACN+BUvXB1zXQlHrGh1Qxb4tAE2uY3drj+XEHaHJ/PMQT2Flpub+X8liuiofdq7D/URafSxiOvBnvdOxkVg3SgMdmX4E7HskQCOi4GFeySkqXqnUKYIrHXv2kE7rk2KYQX0aLhKG6cIEn5UiJujIVEKhhYiwJYhGMCUQ6DLeN1yHlgDFNwpEio2FjW0ugmho697GGgoHLY3CeGS7mSBXCDeZ/BaJIv6HN5k60IT4tDs/DPgk3KuTBZLvcKjLshp5U590dsDa82yz2OtTRAslGsgbQeoHz9ozb9o7qaXkWDjZpbhQjWbHDRCL9zrINJh6CpqzGV7xlnOPsiZOZ2+vpM01lR/r3wZDE7S8lGorQmV7cwCurLepprrLyAR0FVyt5lkzFy7Fo1XDtcNqq+PVHCDZIftLCTiQ2w6oREefcNK9FKPXb20E5XmpN24ynKFx0y7qHaz80bCJDxX9srp/eG/y+qEvDLS/VGJGVe4WyeTAoj9JTV1dVWGJk+3dE9QjImsy4g6beTGzJ1C98CdaaTgTntwpbWrauZnmZOdSSQqqLYBMaEj6wUT+JvY+y+fh/ad67g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(5660300002)(44832011)(41300700001)(2906002)(83380400001)(26005)(31686004)(8676002)(4326008)(8936002)(2616005)(316002)(38100700002)(66556008)(66476007)(110136005)(66946007)(53546011)(6512007)(6506007)(966005)(478600001)(6486002)(31696002)(36756003)(86362001)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEVGenEvMGQyV0RqUis0aDdRUkR3RUZidGZiT05hY3ZlazNMeElHWXZZaUkz?= =?utf-8?B?TGxIeklqWlo0ZlVrbUF0WUp1VFlMVnhpVXV4cklCU2Q1elJlS1JqYnU5bTlr?= =?utf-8?B?SnpJTE1FMFRuWEhXVE94ZTRrOEwxTjJDNGdSejVpSDRqRmY3aFBiUjc3bnpS?= =?utf-8?B?QjFoRVVrZjJoTmdmZDc1U21MREhwZjEvVzZ1SzVtLzEya1g3cElIOURpMjFW?= =?utf-8?B?QW9GWVJPOVFHZyttU3VPQnMwNEYvVlZxSVMyUWJIeTZYcVVjS1M5Sld2dXBy?= =?utf-8?B?bUdGMzJaNTZaN29GcmFsK3B2YWUweERqYjFmZW5OQVZMcGt1cURyUnMyaGYr?= =?utf-8?B?S1IxLzVtTjJCN3I2Mk0rQURDRUNTallmMmJwTzhDL2dTUzFzYVVVNk9tYWVx?= =?utf-8?B?SU84dTAzOE8xbituSlFmZ05GY3hTYjVyOFFPZURyMjhpemx4MnZyOWtwYlF2?= =?utf-8?B?R3hCTUY1ZVUwbjdNc2hKOTdjcXRRWlpEL3VRYkhXUHdheG5kdXdpZmthQkpj?= =?utf-8?B?VEdUa3EvTUsxS0hxclc2ald4Y2p3RFgwWkJwMkRZdDAzbVRMWlZXVGIyclA4?= =?utf-8?B?cUJEMEpSNEc4S2k5V3hJeGZzeHBDWStRSXRXMWFMNXBydDVLVDI2SFhXRlB1?= =?utf-8?B?WUtxSm1ESFlkY1B4L05xWUliSm9PMUlGYko1V2RHWjBYR0RnbXMyVm9WSmJo?= =?utf-8?B?b2lBZytnbnVyNmRkVG8xdnd4dDJmYlpKcFkvUVpiV2FRMlRnSTJTS0FTU09G?= =?utf-8?B?cVFZdWI1d2J3bEFoRk9FajlESFFxd29xWmZoSEZkTU1ESkNaZmRzOUI4RzNL?= =?utf-8?B?eGRkVloySGUxbldkQ0RaL3pUTG5qQ3BNdHkweEJZNmV6SVVManQ5dHFNMVRj?= =?utf-8?B?cUR0QWdUVzNJOW4yRFgyTXQ2bVZtYnhQRTh0bTVVU0NNK2MyakJ1akNPUmlB?= =?utf-8?B?czI3SmtJeHNydUs0M0kwYm5WNG12UjUyR1dUWUdvU3pGVHgxS2QySE1KZExB?= =?utf-8?B?Yjh1SDVxd0xmZHpVU2ZoMXVwdXlla2Vrdk4yU3lsM21RckVudzBzaXJ5QlFE?= =?utf-8?B?Z2hzWW9Id3d4UlMweHdnNndubmE1SERQYUtHWFg0cjVFNlNCVlFaSnRVdmRr?= =?utf-8?B?WDhHMGlzVnc1cnR0Si9NSWtObVVJU2Y3VGlSeXA5azg4MDBPNkc1OURIYURm?= =?utf-8?B?emNCWURrbzB5SURjSFMzdWxVcHI2ejJmSWh0dXZjbXFuaTcwejJyM3dCeFIv?= =?utf-8?B?MlUzcDUrMy9uSWZtS1MySHg2a0U0N28wNmsvZ0pYU1RscVg3cnMvK011RHFu?= =?utf-8?B?M0VnUFJtVlVUMjFVdk1Ob2lZQ1ZlTDZwN0xPOG11QXRQSUhKY0lJY3Rmem4v?= =?utf-8?B?djVKTmNINUtCV2ZFQjhpZ3Rxb0VBaG0xTlhoTEFtTW1ZaGJoR0gxeFEydmlW?= =?utf-8?B?Y1oyVS9UZnlmaTFtOCswa2pyekdrUTVlcllzQmhqbzFaUUUwam14Szk5K0xl?= =?utf-8?B?QlViMnoxY21QNGZReS9obmFXTGJnTEJhVmJHbFphajdUWVR0bnpwQm8wZ3A1?= =?utf-8?B?WG9qU3QwbHY3U3YzNHRNcDkwR2crQmRVRzNnd1NobExIVzl4ODVYeDUrejBp?= =?utf-8?B?OU5YT3lQNXdnRVRmSXJHa28zZng2RWh5djlMN1l0elR4TCtSb09sWlUzaVpU?= =?utf-8?B?ZkhnR3pORXROU21uWGFlRU9TTi82ZHBVSTJhVEg3Ylorb2hTYnFVL3RWaWRB?= =?utf-8?B?VW9MenVjeHNmRE50Qk5DWkNNUDA1RWRZSkk2Y2hiWXhCSzNiYUV3TTI5NVJk?= =?utf-8?B?V0Y3Wm1KTUR3TE85QWZWVjBiVk1NWTdkYTFoUXh6ZnMvMDY0MTFkdjZwSWV3?= =?utf-8?B?R3BBaXpFUEo1VWJzSldsTEI2ZEZyakZEMTR4Yk5kOG9qcE5URmR2WGQ1WTRz?= =?utf-8?B?bG0rTklubGl3RG90UUx2SzZCTkZydm11OWI0bjRBVThJalhrV0tIZmNFNlQv?= =?utf-8?B?T0FaOVl4UzFhYnpLVDhmR2pxVlp5dUszL2lHWWw2VDZtUForT3dvd3dFSFJz?= =?utf-8?B?Tys0MXVsTlZkSlFtVXphMmkyQ2xDbEdvc3hxNFRRRnJKNUIwSDFPMURRVkpQ?= =?utf-8?Q?1c3xHLNwVS1tDw2s5FXS+LlVo?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d3bd106-8766-4638-e744-08dbe26d43fc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2023 04:18:32.5686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ncLbqLWAOvOI7fupCq6JSL55G0Z3XGiI6ggCyPDu8iZKLWF2qbLvwve3jVlDRenN X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6564 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/11/2023 12:34 AM, Joshua Washington wrote: > In GVE, both queue formats have RX buffer size alignment requirements > which are not respected whenever the mbuf size is greater than the > minimum required by DPDK (2048 + 128). > Hi Joshua, We don't have a way to inform application about the alignment requirement, so drivers enforces these as you are doing in this patch. But I am not clear with what is "minimum required by DPDK", since application can provide smaller mbufs. Also not clear why this alignment cause problem only with mbuf size bigger than 2048 + 128 bytes. Can you please clarify? > This causes the driver to break > silently in initialization, and no queues are created, leading to no > network traffic. > > This change aims to remedy this by restricting the RX receive buffer > sizes to valid sizes for their respective queue formats. > > Fixes: 4bec2d0b5572 ("net/gve: support queue operations") > Fixes: 1dc00f4fc74b ("net/gve: add Rx queue setup for DQO") > Cc: junfeng.guo@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Joshua Washington > Reviewed-by: Rushil Gupta <...> > @@ -337,6 +343,20 @@ gve_clear_device_rings_ok(struct gve_priv *priv) > &priv->state_flags); > } > > +static inline int > +gve_validate_rx_buffer_size(struct gve_priv *priv, uint16_t rx_buffer_size) > +{ > + uint16_t min_rx_buffer_size = gve_is_gqi(priv) ? > + GVE_RX_MIN_BUF_SIZE_GQI : GVE_RX_MIN_BUF_SIZE_DQO; > + if (rx_buffer_size < min_rx_buffer_size) { > + PMD_DRV_LOG(ERR, "mbuf size must be at least %hu bytes", > + min_rx_buffer_size); > + return -EINVAL; > + } > + > When 'dev_info->min_rx_bufsize' set correctly, above check should be done in ethdev level, can you please check 'rte_eth_check_rx_mempool()'. > + return 0; > +} > + > int > gve_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id, uint16_t nb_desc, > unsigned int socket_id, const struct rte_eth_rxconf *conf, > diff --git a/drivers/net/gve/gve_rx.c b/drivers/net/gve/gve_rx.c > index b8c92ccda0..0049c6428d 100644 > --- a/drivers/net/gve/gve_rx.c > +++ b/drivers/net/gve/gve_rx.c > @@ -301,6 +301,7 @@ gve_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id, > const struct rte_memzone *mz; > struct gve_rx_queue *rxq; > uint16_t free_thresh; > + uint32_t mbuf_len; > int err = 0; > > if (nb_desc != hw->rx_desc_cnt) { > @@ -344,7 +345,14 @@ gve_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id, > rxq->hw = hw; > rxq->ntfy_addr = &hw->db_bar2[rte_be_to_cpu_32(hw->irq_dbs[rxq->ntfy_id].id)]; > > - rxq->rx_buf_len = rte_pktmbuf_data_room_size(rxq->mpool) - RTE_PKTMBUF_HEADROOM; > + mbuf_len = > + rte_pktmbuf_data_room_size(rxq->mpool) - RTE_PKTMBUF_HEADROOM; > + err = gve_validate_rx_buffer_size(hw, mbuf_len); > + if (err) > + goto err_rxq; > + rxq->rx_buf_len = > + RTE_MIN((uint16_t)GVE_RX_MAX_BUF_SIZE_GQI, > + RTE_ALIGN_FLOOR(mbuf_len, GVE_RX_BUF_ALIGN_GQI)); > Just for your info, this release 'dev_info.max_rx_bufsize' and ethdev layer note added [1] if user provides mbuf size bigger than this value. Ethdev layer not is mainly for memmory optimization, but above check is required for driver. [1] https://git.dpdk.org/dpdk/commit/?id=75c7849a9dcca356985fdb87f2d11cae135dfb1a