DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>
Subject: Re: [dpdk-dev] [PATCH v5 00/23] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver
Date: Thu, 11 Oct 2018 14:11:03 +0100	[thread overview]
Message-ID: <31efc979-cf0a-9c6e-1edf-bfe9adc0f03c@intel.com> (raw)
In-Reply-To: <cover.1539249721.git.igor.russkikh@aquantia.com>

On 10/11/2018 11:34 AM, Igor Russkikh wrote:
> Hello DPDK community!
> 
> Aquantia would like to contribute PMD for aQtion AQC10X NIC family:
> https://www.aquantia.com/products/aqtion/chips/
> These are 10G ethernet NICs with various features.
> 
> We do base this work on parts of the existing native linux kernel
> driver source (atlantic). Shared code is hw_atl hardware and registers access module.
> 
> We'd like to target this driver for 18.11 DPDK release timeline,
> it'd be good to hear comments from the community on how feasible is this.
> 
> This patchset implements basic driver infrastructure,
> vlan offloads, checksumm offloads, rss control,
> multiring, jumbo frames and other features.
> 
> Later on, we plan to share HW MACSEC offloads, rxflows and other features.
> 
> version 5 changes:
> - MTU configuration is now in separate patch
> - Custom LED api removed. Will resubmit separately later on
> - Add product link to docs, rearranged adapter features file
> - MAINTAINERS file update
> - logging name prefix fixed
> - rte_eth_copy_pci_info is not needed in init
> - dev->security_ctx is not used (removed free)
> - fixed adapter_stopped and dev stop/close states interactions
> - return error if get_fw_version fails
> - added port# to important error logs
> - rte_eth_linkstatus_get instead of atomic64 ops
> - swstats are now cleared in stats_reset
> - xstats_reset callback declared as atl_dev_stats_reset
> - stats_mapping_set removed
> - check-git-logs fixes
> 
> version 4 changes:
> - fixed build errors with -Werror on gcc7
> - validated build on arm64, freebsd x86_64
> - PPC marked as unsupported arch
> - stdbool.h is used instead of bool redefines
> 
> version 3 changes:
> - patchset fixed to be incrementally buildable
> - extra includes removed and cleaned up
> - license changed to dual GPL-BSD for pieces shared with linux
> - removed extra logging #defines
> - misc comments from previous review session
> 
> version 2 changes:
> - fixed build on freebsd (no ETIME const)
> - fixed a bunch of checkpatch failures and warnings
> - removed extra CFLAGS disabled warning
> - making static arrays const
> 
> Igor Russkikh (9):
>   net: atlantic: maintainers and documentation
>   net/atlantic: logging macroses and some typedefs
>   net/atlantic: hardware registers access routines
>   net/atlantic: atlantic hardware layer routines
>   net/atlantic: firmware operations layer
>   net/atlantic: b0 hardware layer main logic
>   net/atlantic: receive side structures and implementation
>   net/atlantic: support for RSS and RETA manipulation API
>   net/atlantic: release notes
> 
> Pavel Belous (14):
>   net/atlantic: atlantic PMD driver skeleton
>   net/atlantic: rte device start/stop/initial configuration
>   net/atlantic: initial support for Tx/Rx
>   net/atlantic: transmit side structures and implementation
>   net/atlantic: link status and interrupt management
>   net/atlantic: device statistics support
>   net/atlantic: support for Rx/Tx descriptors information
>   net/atlantic: promisc and allmulti configuration
>   net/atlantic: flow control configuration
>   net/atlantic: support for MAC address manipulations
>   net/atlantic: support for MTU configuration
>   net/atlantic: support for VLAN filters and offloads
>   net/atlantic: support for EEPROM get/set
>   net/atlantic: read MAC registers for debug purposes

Hi Igor,

Patchset mostly looks good to me, I put a few comments.

Also I think patch 1/23 & 2/23 can be merged into single commit.

And can you please follow the below format in patch title:
<subsystem>: <start with verb in lowercase and describe what is done>,

like:

from: "net/atlantic: logging macroses and some typedefs"
to: "net/atlantic: add logging structure"

from "net/atlantic: atlantic hardware layer routines"
to: "net/atlantic: add hardware layer routines"

from: "net/atlantic: transmit side structures and implementation"
to: "net/atlantic: implement Tx"

thanks,
ferruh

  parent reply	other threads:[~2018-10-11 13:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 10:34 Igor Russkikh
2018-10-11 10:34 ` [dpdk-dev] [PATCH v5 01/23] net/atlantic: atlantic PMD driver skeleton Igor Russkikh
2018-10-11 10:34 ` [dpdk-dev] [PATCH v5 02/23] net: atlantic: maintainers and documentation Igor Russkikh
2018-10-11 10:34 ` [dpdk-dev] [PATCH v5 03/23] net/atlantic: logging macroses and some typedefs Igor Russkikh
2018-10-11 10:34 ` [dpdk-dev] [PATCH v5 04/23] net/atlantic: hardware registers access routines Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 05/23] net/atlantic: atlantic hardware layer routines Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 06/23] net/atlantic: firmware operations layer Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 07/23] net/atlantic: b0 hardware layer main logic Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 08/23] net/atlantic: rte device start/stop/initial configuration Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 09/23] net/atlantic: initial support for Tx/Rx Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 10/23] net/atlantic: receive side structures and implementation Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 11/23] net/atlantic: transmit " Igor Russkikh
2018-10-11 12:58   ` Ferruh Yigit
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 12/23] net/atlantic: link status and interrupt management Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 13/23] net/atlantic: device statistics support Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 14/23] net/atlantic: support for Rx/Tx descriptors information Igor Russkikh
2018-10-11 12:57   ` Ferruh Yigit
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 15/23] net/atlantic: promisc and allmulti configuration Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 16/23] net/atlantic: support for RSS and RETA manipulation API Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 17/23] net/atlantic: flow control configuration Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 18/23] net/atlantic: support for MAC address manipulations Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 19/23] net/atlantic: support for MTU configuration Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 20/23] net/atlantic: support for VLAN filters and offloads Igor Russkikh
2018-10-11 12:58   ` Ferruh Yigit
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 21/23] net/atlantic: support for EEPROM get/set Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 22/23] net/atlantic: read MAC registers for debug purposes Igor Russkikh
2018-10-11 10:35 ` [dpdk-dev] [PATCH v5 23/23] net/atlantic: release notes Igor Russkikh
2018-10-11 13:11 ` Ferruh Yigit [this message]
2018-10-11 13:26   ` [dpdk-dev] [PATCH v5 00/23] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31efc979-cf0a-9c6e-1edf-bfe9adc0f03c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Igor.Russkikh@aquantia.com \
    --cc=Pavel.Belous@aquantia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).