From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7F3AE5F28; Wed, 19 Dec 2018 09:46:32 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1550122255; Wed, 19 Dec 2018 03:46:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 19 Dec 2018 03:46:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MnxGL2KS53/wBplXoG7omFKQpyiYQjioHM7nAAVIfB0=; b=oQjFprSWe32h W87MEqI0zw8wZIyS9g3g2SSRty8IX+T+UFUz3uDIfCGyYhR14+XiUmWzHbFUgK37 AURYTfeI9LyNOPBBQiByKi1qjrIWXCnFNszQkngEQ66N10MQ+7WsnTDOu62U74Pu 8AKPShnqV1iNnMiEicaQKRu5CvS8sBU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MnxGL2KS53/wBplXoG7omFKQpyiYQjioHM7nAAVIf B0=; b=ymZq9h3CYpqUiMMmkZFYlxQbcTI+a5si0MSMKB2Bm0yQMNtTstpk4EDHU T2mzRDs7HBUFHMc+WhJETGYUJ5Ax/1XKRFhRD7tKRp1fbPZlLMThqgGV3MiH6+wA 7MUneZsgdh5okabKhVE911vXQNYgB1B3vrXxUFbm0Gu9KFMIOo6u/sgCdL7ON3oG hJvDqOoU0j2At8EQbjaqu9sIypt+UoiCvFGiye4vHzKqYH6Zkmg8+CL00nAQzfqY 9bSbWu3b1gyReZYKrlQuE0oBEe7/Q4b7CTiTXBaSzjl//FT/IVl1bz73FYcLH7LA L/BZ1NLhIm1GxDQTHePeYXcA54IEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeiledgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C87B8E4599; Wed, 19 Dec 2018 03:46:30 -0500 (EST) From: Thomas Monjalon To: Qi Zhang Cc: anatoly.burakov@intel.com, dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Date: Wed, 19 Dec 2018 09:46:28 +0100 Message-ID: <3200108.0fENqxW6u2@xps> In-Reply-To: <20181219074107.10084-1-qi.z.zhang@intel.com> References: <20181219074107.10084-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: close MP socket during cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 08:46:32 -0000 19/12/2018 08:41, Qi Zhang: > When secondary process quit, the mp_socket* file still exist, that > cause rte_mp_request_sync fail when try to send message on a floating > socket. > > The patch fix the issue by introduce a function rte_mp_channel_fini. > This function will be called by rte_eal_cleanup and it will close the > mp socket and delete the mp_socket* file. Why not call it rte_mp_channel_cleanup, keeping the same wording? [...] > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -1229,6 +1229,7 @@ rte_eal_cleanup(void) > if (rte_eal_process_type() == RTE_PROC_PRIMARY) > rte_memseg_walk(mark_freeable, NULL); > rte_service_finalize(); > + rte_mp_channel_fini(); > return 0; > } Should be called in bsdapp/eal?