From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 97796A0A0E;
	Tue, 11 May 2021 14:01:36 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 834B540140;
	Tue, 11 May 2021 14:01:36 +0200 (CEST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 011974003E
 for <dev@dpdk.org>; Tue, 11 May 2021 14:01:34 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 948BAEAB;
 Tue, 11 May 2021 08:01:33 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Tue, 11 May 2021 08:01:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 jel+bPTAGUNaSt6w3jBM9Sd53UTTpWvSv/4td2beRzg=; b=cTfnYYQrQlRbjt2V
 h7ymO2KCk171X0UWDk+YNg0/kXLo52WSIfIj51arOWvFq0j5wzZEefWkBQaLJpyN
 yF56ETTj4NRvzX8bnfhsnHhv2Tjejx6MONWIauzFjYjQ6g6tJiJiNB97xzrGaKmV
 ygt654WSk4iLPaiXE9ptmbyCBExz37CjUtjRHziIGZ6cFAIMp0jHEbQLwAelzkIR
 a9A0AgkZWt4TCuDN9+9j6FiNH9NanIxrcbRVShONCd5nscSEnH5BzNSmdxqdtJXs
 JD4POzv775EnMQPfgh1F8sI5RTiaBd6xYC3ev7gFry26BIazedAHNTyvylBpFPsZ
 fzV1pw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=jel+bPTAGUNaSt6w3jBM9Sd53UTTpWvSv/4td2beR
 zg=; b=JHenykwqVG/oIwJevMw+iwB3pYotMrNEtl5yG1QBS5J0G+wbNuCuHdO37
 MYsPSv3K8M5E/xyVPKbgGWfos4kvGFC4Hs6IypLVN5hfLLXHap4IUsWEfad6CwTL
 6mNDUgnV6E600Y0GIcI4EnL7yc4JRGy1mSzGavsyzwhc5TUmBTYVijp8AuHq5ckv
 bAydZq4olReWLL2byPp/HHQpUWk/MpuSksbP+i2Oc52o2C8VLuQYt8c3OL/Hjwtn
 6y2u0DfQWPz+p01RaXebkwqfrvMzcnSnnVNDNLdRiALgCGoG9nwFBreBQoYyOSTd
 ztorfclDIabcnLD2WQl1D9vnyo3+Q==
X-ME-Sender: <xms:G3KaYOOGK1LXmeXQyqt3uqcjDfxryDBHeAYFWMxZtKZO5l3wQacxvQ>
 <xme:G3KaYM988pL7y6cb825KnHrn4e-h20VRydZfujiwcPNp0u_zQIJkHeL4Rnkt71h_1
 WBZz8UpfjfwGxgGkA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddggeekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:G3KaYFR2lfWSRM9-hIj2MTpp63K7T97smIBVctaU9AMYIokm8Ar3Bg>
 <xmx:G3KaYOtFRgtFOrOQ7ikQqcanTLkJAvuLsLXiV8ihbddTlsiVovT9Ng>
 <xmx:G3KaYGerpGpBUUbOYPMScZE4rBUvh9akZ_LpbNDazN426tn3b5qffg>
 <xmx:HXKaYHoeXYFcpuC7v-3GviDXU7Nd9ksyWwT6Gcv7mJ4tJBWslP-cXw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA;
 Tue, 11 May 2021 08:01:31 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com,
 David Marchand <david.marchand@redhat.com>
Date: Tue, 11 May 2021 14:01:29 +0200
Message-ID: <3205318.kz0D4tACF5@thomas>
In-Reply-To: <YJpvN2TagX7lXIL5@bricha3-MOBL.ger.corp.intel.com>
References: <20210409124334.24479-1-david.marchand@redhat.com>
 <20210511100927.824319-1-thomas@monjalon.net>
 <YJpvN2TagX7lXIL5@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3] log: register with standardized names
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/05/2021 13:49, Bruce Richardson:
> On Tue, May 11, 2021 at 12:09:27PM +0200, Thomas Monjalon wrote:
> > +log_prefix
> > +	**Default Value = pmd.<class>**
> > +	Some driver classes have a customized log prefix.
> > +	This prefix is combined with the driver name
> > +	when registering a default log name for the driver.
> > +
> 
> I don't think this should be added here. This section is for elements to be
> defined in the meson.build file of each individual driver. This value,
> though, is to be defined per class, rather than per-driver. We don't have a
> doc section for that, but perhaps one is needed.
> 
> For now, I'd just omit documenting this value as it should only be of
> relevance for the couple of existing driver classes that use it. Nobody
> else contributing new code to DPDK should need it.

OK, makes sense.

If I remove these doc lines, is it OK to push the patch to the repository?