From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20072425E1; Mon, 18 Sep 2023 21:58:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3D8D40275; Mon, 18 Sep 2023 21:58:10 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 94ED84025D; Mon, 18 Sep 2023 21:58:09 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 412E45C01D6; Mon, 18 Sep 2023 15:58:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 18 Sep 2023 15:58:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1695067086; x=1695153486; bh=tg9+yWnk4SZRVDo1Zb5iGLdIcuGeWl5dHgc U9JRfYF0=; b=u5hvE5c9Lzu4aiJHHiViCjx9OS750ccvJ9DuxhKx6tlGsnTNZ4U 5YMwbhU+W7Ua57mFVzob76A01ZgXi9Xh5zLpB32g+KEi2jOUTNOGNa+UblZeXeHX GwmYYqW0ldI5JadwFXMgICMleK1C1hlT+102J66KNY5n6nK6KGa6+b7vgzj5dyCK jloWmY6PFK5EPKYf7hiVpldWK1kzhP8EuwMv/EpMLia38pL8OF/PkinuFycSuXOo 0BSGPGaAT8OkXK8rbXoVNHp0SHhu/rqrUwdUb4UEG1iINYhBR9IPdQneNABnT01i Mz6jwakNvmytSSoOOO9nux2LY9pi86ZjIBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695067086; x=1695153486; bh=tg9+yWnk4SZRVDo1Zb5iGLdIcuGeWl5dHgc U9JRfYF0=; b=goh1toNTAUJUYvrrPv7ZfRYalE6SCa7KhegIzeVh6J9wK/aNaOv QzpCMxY/IbFa/HrDLWS3j2meakJDZKK1DmlJlorE9WV4l8pG6/WRi/w9C/VGSGDJ wlC6c43tQR9T3spIXqWOKtp9Waqi2jnL5k/WLrxuygxnHCxp+z/D9nLN7TMEAgPV oQ/u/0vAVZAOnCSNADbdnEtoqOo28uB8Q8VQpQ4c/buI1f2JCNH1jeyjJxVfCkjr CzEAx3YHlpeicatV6JeJe9kRj/a49QBYZgK6QZSTd/F8aewNnJUBXISzOKR+Z8kB ah93ZoV8i//Jq61ZH4mbjfueqI9dhxgOvMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudejkedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhtedu udevtdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Sep 2023 15:58:03 -0400 (EDT) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= , "techboard@dpdk.org" , "maxime.coquelin@redhat.com" , Honnappa Nagarahalli Cc: "dev@dpdk.org" , Ferruh Yigit , "andrew.rybchenko@oktetlabs.ru" , Christian Koue Muf , Renyong Wan Subject: Re: Process for adding a new driver? Date: Mon, 18 Sep 2023 21:58:01 +0200 Message-ID: <3206014.l52yBJDM9G@thomas> In-Reply-To: References: <98CBD80474FA8B44BF855DF32C47DC35D87BB8@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/09/2023 16:36, Honnappa Nagarahalli: > From: Morten Br=F8rup > >=20 > > The process for adding a new library to DPDK is well documented [1]. > >=20 > > What is the process for adding a new (NIC) driver? > >=20 > > It seems like the task of reviewing NIC PMDs from vendors other than > > Broadcom/Intel/Marvell/NVIDIA falls entirely on the next-net tree > > maintainers, Ferruh and Andrew, which doesn't seem like a reasonable > > burden. > >=20 > > The Napatech driver is too large for Ferruh to review, which in my opin= ion [2] > > is an unreasonable argument for not accepting it. > >=20 > > And the 3SNIC driver got no attention by any reviewers [3]. (Although > > Stephen did provide some basic feedback after they polled for review.) > >=20 > > Overall, I think we should put much more trust in hardware vendors to > > provide high quality drivers for their hardware. We want vendors to ups= tream > > their drivers, with all the benefits of having the code public. If we m= ake it too > > difficult, they will simply keep their drivers private instead. >=20 > Difficulty vs quality control? IMO, it is good to add more drivers. May b= e we need to control quality through testing reports? There are different kind of quality aspects. =46unctional testing is one quality criteria. Grouping code in something understandable with clear explanations is anothe= r one. Being consistent with the rest of the codebase (design or code style) may be other quality criteria. The difficult exercise is to ask the right level of investment from the ven= dor. Don't forget that adding a driver is a win-win situation.