From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id DD1F12C17 for ; Thu, 21 Apr 2016 12:11:54 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id n3so124614278wmn.0 for ; Thu, 21 Apr 2016 03:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Oa/U4fjGdf3/6HCPsgqoojuNBh1iHo2r51ndpaXQzcU=; b=AqX3BlLErJ/P7QN7usO9bCuIOw15p47IyP9dbzdRdimwAAyaghX60++6MLyyUGKiP3 uJHC9kMuq0YV+7e0G76ufIya0TfbuaXNE1E6+kIGy6cgTkFgA/ZxtPU5WeJIMUBIDGup HkNaoSmM8i2uxlA+iN6u4sZuGLquAoI/UlRxeD+ptpQRwWX9y+rdQXioX9rbqgtlxrOW sjRDKwH4DmfO8M0ulDYqj/v2OU5Q5y9aGkBu+lSAjVrE7yGIZNbGGBpkf95upKol0sOo 7RyNAjvHq+PhvXnq70e0YTg8TTRqgaxFdIHkcury04rpmt6QFKBM274/2nc8Vh73llby BxIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Oa/U4fjGdf3/6HCPsgqoojuNBh1iHo2r51ndpaXQzcU=; b=Vms2dcAJK323DpjpgsgnwfZT5yOWbZ+JqgF3qdd4cRyMPGauYVxFPpvK/cIxj+N2pS L99pNFOGlYVsL7GLQ4Lvuao/vBmOpCbsVw+iS7KhD7+k+KJehpu9vNOtuVHBFSof699z uhCkM79KsLoN7Drim8kj41e3anzNEIJkJNAn2Qim5vdi/W498/DbATk1t6PnZUima6GF MLM2FneoqU8XBi154/MvItMCTSEWAmHKQ/1P7DAwFyPpTlF+8aQyZl4UlALgNbgyTRr8 nxmqGYzo50T7qpjCP5PBy9fyE9orPLJw+fK7H0xVAAatpmHlDoEG5c1tWetPKC9zHtHJ EpaA== X-Gm-Message-State: AOPr4FX1810keT6YhIMVLDUG+xPxA8PopZa6boH/YTzSSLmgqUT2K9ypTSzKJKnxNhzZHs6+ X-Received: by 10.28.146.135 with SMTP id u129mr13654662wmd.8.1461233514747; Thu, 21 Apr 2016 03:11:54 -0700 (PDT) Received: from xps13.localnet (APoitiers-658-1-12-89.w86-213.abo.wanadoo.fr. [86.213.195.89]) by smtp.gmail.com with ESMTPSA id e140sm14085590wma.13.2016.04.21.03.11.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Apr 2016 03:11:54 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson , Stephen Hurd Cc: Ajit Kumar Khaparde , dev@dpdk.org Date: Thu, 21 Apr 2016 12:11:33 +0200 Message-ID: <3207073.5iacktQG42@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160421100005.GA976@bricha3-MOBL3> References: <1456978137-98097-1-git-send-email-stephen.hurd@broadcom.com> <20160421100005.GA976@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 10:11:55 -0000 2016-04-21 11:00, Bruce Richardson: > On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > > It's not for testing, more for code review and to help understand the code > > > [though > > > as you say, we do need to ensure that each commit doesn't actually break > > > the > > > build]. > > > Right now, the driver code goes in as a single commit - which makes it a > > > hard > > > enough task to review and see what is in there. One suggestion that > > > hopefully > > > wouldn't be too much work might be to split the code up into: basic device > > > init code, RX and TX functions, and then any additional features based on > > > top > > > of that [ideally one patch per added feature]. > > > > > > > The current driver doesn't have much beyond basic TX/RX, but we can give it > > a shot. "Too much work" is relative of course, but splitting it into > > self-contained easily understood chunks will absolutely be a lot of work. > > > > Adding Ajit who will also be working on this. Since he's coming up to > > speed on the driver code, this could be a good way for him to fully > > familiarize himself with it. > > > Sure, thanks. Any splitting you can do at all would be appreciated and help with > reviews. I'd add that it helps newcomers to understand the driver by reading the git history. Thanks