* [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
@ 2018-12-27 19:59 Rami Rosen
2018-12-30 8:23 ` Wisam Monther
2019-01-03 14:00 ` Iremonger, Bernard
0 siblings, 2 replies; 5+ messages in thread
From: Rami Rosen @ 2018-12-27 19:59 UTC (permalink / raw)
To: dev; +Cc: stable, wisamm, Rami Rosen
This patch fixes a typo in testpmd user guide.
Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..ab40b9f5f 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1149,7 +1149,7 @@ set eth-peer
Set the forwarding peer address for certain port::
- testpmd> set eth-peer (port_id) (perr_addr)
+ testpmd> set eth-peer (port_id) (peer_addr)
This is equivalent to the ``--eth-peer`` command-line option.
--
2.19.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
2018-12-27 19:59 [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide Rami Rosen
@ 2018-12-30 8:23 ` Wisam Monther
2019-01-03 14:00 ` Iremonger, Bernard
1 sibling, 0 replies; 5+ messages in thread
From: Wisam Monther @ 2018-12-30 8:23 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: stable
-----Original Message-----
From: Rami Rosen [mailto:ramirose@gmail.com]
Sent: Thursday, December 27, 2018 9:59 PM
To: dev@dpdk.org
Cc: stable@dpdk.org; Wisam Monther; Rami Rosen
Subject: [PATCH] doc: fix a typo in testpmd user guide
This patch fixes a typo in testpmd user guide.
Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..ab40b9f5f 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1149,7 +1149,7 @@ set eth-peer
Set the forwarding peer address for certain port::
- testpmd> set eth-peer (port_id) (perr_addr)
+ testpmd> set eth-peer (port_id) (peer_addr)
This is equivalent to the ``--eth-peer`` command-line option.
--
2.19.2
Acked-by: Wisam Jaddo <wisamm@mellanox.com>
BRs,
Wisam Jaddo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
2018-12-27 19:59 [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide Rami Rosen
2018-12-30 8:23 ` Wisam Monther
@ 2019-01-03 14:00 ` Iremonger, Bernard
2019-01-03 16:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-01-08 15:07 ` Ferruh Yigit
1 sibling, 2 replies; 5+ messages in thread
From: Iremonger, Bernard @ 2019-01-03 14:00 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: stable, wisamm
Hi Rami,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Thursday, December 27, 2018 7:59 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; wisamm@mellanox.com; Rami Rosen
> <ramirose@gmail.com>
> Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
>
> This patch fixes a typo in testpmd user guide.
>
> Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index cbf23e928..ab40b9f5f 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -1149,7 +1149,7 @@ set eth-peer
>
> Set the forwarding peer address for certain port::
>
> - testpmd> set eth-peer (port_id) (perr_addr)
> + testpmd> set eth-peer (port_id) (peer_addr)
>
> This is equivalent to the ``--eth-peer`` command-line option.
>
> --
> 2.19.2
./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_testpmd/doc-fix-a-typo-in-testpmd-user-guide.patch
### doc: fix a typo in testpmd user guide
WARNING:BAD_SIGN_OFF: Duplicate signature
#25:
Signed-off-by: Rami Rosen <ramirose@gmail.com>
total: 0 errors, 1 warnings, 8 lines checked
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix a typo in testpmd user guide
2019-01-03 14:00 ` Iremonger, Bernard
@ 2019-01-03 16:35 ` Ferruh Yigit
2019-01-08 15:07 ` Ferruh Yigit
1 sibling, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2019-01-03 16:35 UTC (permalink / raw)
To: Iremonger, Bernard, Rami Rosen, dev; +Cc: stable, wisamm
On 1/3/2019 2:00 PM, Iremonger, Bernard wrote:
> Hi Rami,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
>> Sent: Thursday, December 27, 2018 7:59 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; wisamm@mellanox.com; Rami Rosen
>> <ramirose@gmail.com>
>> Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
>>
>> This patch fixes a typo in testpmd user guide.
>>
>> Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>> ---
>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> index cbf23e928..ab40b9f5f 100644
>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> @@ -1149,7 +1149,7 @@ set eth-peer
>>
>> Set the forwarding peer address for certain port::
>>
>> - testpmd> set eth-peer (port_id) (perr_addr)
>> + testpmd> set eth-peer (port_id) (peer_addr)
>>
>> This is equivalent to the ``--eth-peer`` command-line option.
>>
>> --
>> 2.19.2
>
> ./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_testpmd/doc-fix-a-typo-in-testpmd-user-guide.patch
>
> ### doc: fix a typo in testpmd user guide
>
> WARNING:BAD_SIGN_OFF: Duplicate signature
> #25:
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> total: 0 errors, 1 warnings, 8 lines checked
There is no double sign-off, this is because Wisam added his ack without quoting
original mail, so patchwork observed second sign-off and added it.
So original patch is OK, please check the error message before copy-paste it
from the console.
And with your error copy-paste, patchwork observed sign-off again and now there
are three copy same sign-off :)
>
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix a typo in testpmd user guide
2019-01-03 14:00 ` Iremonger, Bernard
2019-01-03 16:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-01-08 15:07 ` Ferruh Yigit
1 sibling, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2019-01-08 15:07 UTC (permalink / raw)
To: Iremonger, Bernard, Rami Rosen, dev; +Cc: stable, wisamm
On 1/3/2019 2:00 PM, Iremonger, Bernard wrote:
> Hi Rami,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
>> Sent: Thursday, December 27, 2018 7:59 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; wisamm@mellanox.com; Rami Rosen
>> <ramirose@gmail.com>
>> Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
>>
>> This patch fixes a typo in testpmd user guide.
>>
>> Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
...
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-08 15:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-27 19:59 [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide Rami Rosen
2018-12-30 8:23 ` Wisam Monther
2019-01-03 14:00 ` Iremonger, Bernard
2019-01-03 16:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-01-08 15:07 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).