From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8D6EA04B7; Wed, 14 Oct 2020 12:40:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 794D51DCB1; Wed, 14 Oct 2020 12:40:57 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C22B71DC5C for ; Wed, 14 Oct 2020 12:40:54 +0200 (CEST) IronPort-SDR: fWk1o13vItgN+YT2lZVekxiaENoUEpCMq1e+glEY5xZAVTP8iv0vJqKNexeKd3ZYIWCzZpUNp/ /213cMHf/Gxg== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="153910440" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="153910440" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 03:40:53 -0700 IronPort-SDR: PRFzLEbbTQUrZEups/I9CceZywWlUcDSfU4ngi6We4QNwygJLwQusYGOARn6w0W9y0cQ0S7SNW 0hh+60W0sBjg== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="345612632" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.2.249]) ([10.252.2.249]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 03:40:52 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1602596753-32282-1-git-send-email-arybchenko@solarflare.com> <1602596753-32282-3-git-send-email-arybchenko@solarflare.com> Cc: Thomas Monjalon , Ciara Power From: Ferruh Yigit Message-ID: <320c2924-fc91-8c08-b17f-1875cf5ff8bf@intel.com> Date: Wed, 14 Oct 2020 11:40:48 +0100 MIME-Version: 1.0 In-Reply-To: <1602596753-32282-3-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 02/36] doc: avoid references to removed config variables in net/sfc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 2:45 PM, Andrew Rybchenko wrote: > CONFIG_* variables were used by make-based build system which is > removed. > > Fixes: 3cc6ecfdfe85 ("build: remove makefiles") > > Signed-off-by: Andrew Rybchenko > --- > doc/guides/nics/sfc_efx.rst | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst > index 812c1e7951..84b9b56ddb 100644 > --- a/doc/guides/nics/sfc_efx.rst > +++ b/doc/guides/nics/sfc_efx.rst > @@ -273,17 +273,15 @@ Pre-Installation Configuration > ------------------------------ > > > -Config File Options > -~~~~~~~~~~~~~~~~~~~ > +Build Options > +~~~~~~~~~~~~~ > > -The following options can be modified in the ``.config`` file. > -Please note that enabling debugging options may affect system performance. > - > -- ``CONFIG_RTE_LIBRTE_SFC_EFX_PMD`` (default **y**) > +The following build-time options may be enabled on build time using > +``-Dc_args=`` meson argument (e.g. ``-Dc_args=-DRTE_LIBRTE_SFC_EFX_DEBUG``). > > - Enable compilation of Solarflare libefx-based poll-mode driver. > +Please note that enabling debugging options may affect system performance. > > -- ``CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG`` (default **n**) > +- ``RTE_LIBRTE_SFC_EFX_DEBUG`` (undefined by default) > > Enable compilation of the extra run-time consistency checks. > > This will conflict with Ciara's Make removal patch: https://patches.dpdk.org/patch/80120/ cc'ed Ciara & Thomas to be aware of it.