From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E54A4A0561; Sun, 19 Apr 2020 16:30:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CF701D594; Sun, 19 Apr 2020 16:30:00 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id B0D481D58F for ; Sun, 19 Apr 2020 16:29:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8FE9F5C4; Sun, 19 Apr 2020 10:29:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 19 Apr 2020 10:29:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= K1BP5HN5mqu9WVjAdnNRLlgvC7AQ+7TwsM1lsfDTjuM=; b=SA06geT5Qb7eJD9w M61/BdbwqKm5wg9rWX9hSZrm71yrnazj6XHikQjkCaNm9xLBt13I2Xc5qwaAFJrL KwtzIq3CKM9XUJDyYlaRmlOJvEGm0lVtA2GYUYx53SC0BkW0kGR4umL4bGVbg8OI peEoA2U5EJXOFLOATPCb4Z+kPRZG4aTbubiU0wr4VahhVDiDbaqm4ajCseY+UyeL X4Wa7Zr5D9MxrdkD1SX+6LqtxSi18P6eDEoceIUlhi3NqhlAzlwnBtzwE22FQQFA 3rb2l6kJA92mOt7qJDH/kd6akI0FyIyegVlt+jvWJO34YsUmn2TSwv8gEjrEVpw1 zmVbdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=K1BP5HN5mqu9WVjAdnNRLlgvC7AQ+7TwsM1lsfDTj uM=; b=oCuNP/kObsi/1S/2oId328WLBFHwQFb/F36eN42Abt4GN3gL93gaHQZm/ EafI70TF9jXIsrQb0PruBFPqSis2YRRiM/2o/+3SXwfpS3l51M2a8tqL4pLYVP/g 17LchqsXnMyM8pFzmL/nWqYBHj5Wkq8enh82XcHIoJkbp5oiLUhc+PTzvw3xtx2l 5BaJLz70QF5NQ6IZLd7CnvP0vhHl1hx6kIMkt2isp5iJOEZ5foUwdAbix3tbyVXf 04SmYLUFDsVUzpm9cez4puT7bqH1y04kIipeAQbYuQfmxRGtIa65hK/c1ngerFan NEW4yi47Wq9k6wC7KHe06cVvz9EdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgedugdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepmhgvshhonhgsuhhilhgurdgtohhmnecukfhppeejjedrudefgedrvddtfedr udekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5119328005D; Sun, 19 Apr 2020 10:29:53 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson Date: Sun, 19 Apr 2020 16:29:52 +0200 Message-ID: <3210362.Bm8zEkEi59@thomas> In-Reply-To: References: <20200418131942.1388633-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/04/2020 09:08, David Marchand: > On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon wrote: > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > - options="$options --werror -Dexamples=all" > > + options="$options --werror" > > + if echo $* | grep -qw -- '--default-library=static' ; then > > + options="$options -Dexamples=l3fwd" > > + else > > + options="$options -Dexamples=all" > > + fi > > Ok, this is hypothetical, but this would not work when no > default-library option is passed (static is the default value). No, with meson, shared is the default: https://mesonbuild.com/Builtin-options.html#core-options > How about inverting the check and look for default-library=shared ? > > Besides, you won't catch already configured directories. > While for make environments, this change will have an effect right away. Yes, I think it is OK to keep old configuration in meson builds until the build directories are trashed.