DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>,
	probb@iol.unh.edu, yoan.picchi@foss.arm.com,
	Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 2/2] dts: add steps and verify sections to docstrings
Date: Mon, 11 Aug 2025 12:09:58 +0100	[thread overview]
Message-ID: <321f7361-5f6a-4017-a7b5-6fbd5a10bb17@arm.com> (raw)
In-Reply-To: <20250807145002.297452-2-dmarx@iol.unh.edu>

Looks mostly fine but as noted in the earlier patch, should be * not -. 
Just one small issue:

On 07/08/2025 15:50, Dean Marx wrote:
> diff --git a/dts/tests/TestSuite_mtu.py b/dts/tests/TestSuite_mtu.py
> index d5b3fe02af..0d36f18b00 100644
> --- a/dts/tests/TestSuite_mtu.py
> +++ b/dts/tests/TestSuite_mtu.py
> @@ -127,35 +127,35 @@ def assess_mtu_boundary(self, testpmd_shell: TestPmdShell, mtu: int) -> None:
>       def test_runtime_mtu_updating_and_forwarding(self) -> None:
>           """Verify runtime MTU adjustments and assess packet forwarding behavior.
>   
> -        Test:
> -            * Start TestPMD in a paired topology.
> -            * Set port MTU to 1500.
> -            * Send packets of 1491, 1500 and 1509 bytes.
> -                * Verify the first two packets are forwarded and the last is dropped.
> -
> -            * Set port MTU to 2400.
> -            * Send packets of 1491, 1500 and 1509 bytes.
> -                * Verify all three packets are forwarded.
> -            * Send packets of 2391, 2400 and 2409 bytes.
> -                * Verify the first two packets are forwarded and the last is dropped.
> -
> -            * Set port MTU to 4800.
> -            * Send packets of 1491, 1500 and 1509 bytes.
> -                * Verify all three packets are forwarded.
> -            * Send packets of 4791, 4800 and 4809 bytes.
> -                * Verify the first two packets are forwarded and the last is dropped.
> -
> -            * Set port MTU to 9000.
> -            * Send packets of 1491, 1500 and 1509 bytes.
> -                * Verify all three packets are forwarded.
> -            * Send packets of 8991, 9000 and 9009 bytes.
> -                * Verify the first two packets are forwarded and the last is dropped.
> +        Steps:
> +            - Start TestPMD in a paired topology.
> +            - Set port MTU to 1500.
> +            - Send packets of 1491, 1500 and 1509 bytes.
> +                Verify the first two packets are forwarded and the last is dropped.
Looks like you broke the second level list by removing the *. The format 
of the original looked fine. Same for the below> +
> +            - Set port MTU to 2400.
> +            - Send packets of 1491, 1500 and 1509 bytes.
> +                Verify all three packets are forwarded.
> +            - Send packets of 2391, 2400 and 2409 bytes.
> +                Verify the first two packets are forwarded and the last is dropped.
> +
> +            - Set port MTU to 4800.
> +            - Send packets of 1491, 1500 and 1509 bytes.
> +                Verify all three packets are forwarded.
> +            - Send packets of 4791, 4800 and 4809 bytes.
> +                Verify the first two packets are forwarded and the last is dropped.
> +
> +            - Set port MTU to 9000.
> +            - Send packets of 1491, 1500 and 1509 bytes.
> +                Verify all three packets are forwarded.
> +            - Send packets of 8991, 9000 and 9009 bytes.
> +                Verify the first two packets are forwarded and the last is dropped.
>           Verify:
> -            * Verifies the successful forwarding of packets via a search for an inserted payload.
> +            - Verifies the successful forwarding of packets via a search for an inserted payload.
>                 If the payload is found, the packet was transmitted successfully. Otherwise, the
>                 packet is considered dropped.
>   
> -            * Verify that standard MTU packets forward, in addition to packets within the limits of
> +            - Verify that standard MTU packets forward, in addition to packets within the limits of
>                 an MTU size set during runtime.
>           """
>           with TestPmdShell(tx_offloads=0x8000, mbuf_size=[JUMBO_MTU + 200]) as testpmd:

  reply	other threads:[~2025-08-11 11:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 17:19 [PATCH v1 1/2] doc: add test case docstring example to dts rst Dean Marx
2025-07-22 17:19 ` [PATCH v1 2/2] dts: add steps and verify sections to docstrings Dean Marx
2025-07-29 12:46   ` Luca Vizzarro
2025-07-29 12:45 ` [PATCH v1 1/2] doc: add test case docstring example to dts rst Luca Vizzarro
2025-08-07 14:50 ` [PATCH v2 " Dean Marx
2025-08-07 14:50   ` [PATCH v2 2/2] dts: add steps and verify sections to docstrings Dean Marx
2025-08-11 11:09     ` Luca Vizzarro [this message]
2025-08-11 11:07   ` [PATCH v2 1/2] doc: add test case docstring example to dts rst Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=321f7361-5f6a-4017-a7b5-6fbd5a10bb17@arm.com \
    --to=luca.vizzarro@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).