From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 501D5A00C5; Sun, 26 Apr 2020 11:23:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EE1C1BF9E; Sun, 26 Apr 2020 11:23:11 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 0C0331BF72 for <dev@dpdk.org>; Sun, 26 Apr 2020 11:23:10 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 726FE580090; Sun, 26 Apr 2020 05:23:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 05:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= BxqoGUCYiqeZvqNkmMHKTRyS7UVCr2vMWjV6uZnwP4Y=; b=Mywx2tXrHyiqpM2I OD2wHs4CbhLHMzU6lanBrZqzq4D7mJM8WH+O/EGBsX8NyslXuhncCCMRXGcar8Bv oqTF8vmkCEGd3eNmYJvHMV7Gj0vQvbxNmi31A2E1IjM9pjGxbZhwCpqNMErQNg+u fe6b0tp6TsYsOLVS9LCCf0yqYAN2Uxukua3KnsRm2Mju6MfbVkej3uRoY6Mu6VUf g0En206s3YLt5G6LeZhGecYNK5ILhzADntxiRrSSr2zqUXECpVI0Cqr+NQM3+5Ji Tg1iAEThid0Wl8DK9yxctbfwKCathrisM2XRWj66Bs2aHpCDL5LqHeMA9w34XHcp IfUOiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BxqoGUCYiqeZvqNkmMHKTRyS7UVCr2vMWjV6uZnwP 4Y=; b=0OlLoY9TM9ca6gFVtmcntQN78rAsC6CZq0xmgn+ePZ4KVDHAUKoQWhQ5t yTcYsmAIIfno94C5lNcdowYZrgaF3Y+pcSePy+9Wb99ftMcQSbUVI4pfj1cIal3W LAP8KigYMSl/0ZO9alfztDU43OwAhuZbUJxiu9axoY5Bb4pm1E+i/B+BqrTfHNGS bfHAjw+GsCd4BfW2Jslr1UR5gX5WfEjpZSsVXzr2C29jRbZvXNWMiB7fheOfDGx3 Xf11RCz4N+/payHKAhWQr742wcxCzFBpSE4vDH1q4R8ItiAaiyj4qbIdzss93tMY tAH64K3WG7hC3TSXZeNQb51PJisEw== X-ME-Sender: <xms:-1KlXpFMAga3IAnZezpxdEQb2aNhbWNLCb3uB4R3TMxi21ssFuj1Vg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:-1KlXjSV_QCJ_R86hZ2FywEBoxFtgvVUClCbcuGV2vybtFDAR3jeZw> <xmx:-1KlXvZudWX3E6jqeFOzk0U2NrLRPMqy5I8GTfCA2lA1-k7dA1HXAQ> <xmx:-1KlXu34GmWWRUhe_YeMFKslTf70BSHqi8K6wUec0P11nPg9RKHCmw> <xmx:_VKlXrsbrHBfbUHsdNo1aym3J2iSsux4kFs_O7CfK6hveNCgInhHjw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 811DE3065E1F; Sun, 26 Apr 2020 05:23:05 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Joyce Kong <Joyce.Kong@arm.com> Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "jerinj@marvell.com" <jerinj@marvell.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "ravi1.kumar@amd.com" <ravi1.kumar@amd.com>, "rmody@marvell.com" <rmody@marvell.com>, "shshaikh@marvell.com" <shshaikh@marvell.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>, "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Gavin Hu <Gavin.Hu@arm.com>, Phil Yang <Phil.Yang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com> Date: Sun, 26 Apr 2020 11:23:03 +0200 Message-ID: <3221990.uBEoKPz9u1@thomas> In-Reply-To: <DB7PR08MB3307476EDB0F8E32806092B192AE0@DB7PR08MB3307.eurprd08.prod.outlook.com> References: <20200424032159.992-1-joyce.kong@arm.com> <11850699.hYdu0Ggh8K@thomas> <DB7PR08MB3307476EDB0F8E32806092B192AE0@DB7PR08MB3307.eurprd08.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 1/6] lib/eal: implement the family of common bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 26/04/2020 09:18, Joyce Kong: > From: Thomas Monjalon <thomas@monjalon.net> > > 24/04/2020 05:21, Joyce Kong: > > > Bitwise operation APIs are defined and used in a lot of PMDs, which > > > caused a huge code duplication. To reduce duplication, this patch > > > consolidates them into a common API family. > > [...] > > > +rte_get_bit32_relaxed(unsigned int nr, volatile uint32_t *addr) > > > +rte_set_bit32_relaxed(unsigned int nr, volatile uint32_t *addr) > > > +rte_clear_bit32_relaxed(unsigned int nr, volatile uint32_t *addr) > > > +rte_test_and_set_bit32_relaxed(unsigned int nr, volatile uint32_t > > > +*addr) rte_test_and_clear_bit32_relaxed(unsigned int nr, volatile > > > +uint32_t *addr) rte_get_bit64_relaxed(unsigned int nr, volatile > > > +uint64_t *addr) rte_set_bit64_relaxed(unsigned int nr, volatile > > > +uint64_t *addr) rte_clear_bit64_relaxed(unsigned int nr, volatile > > > +uint64_t *addr) rte_test_and_set_bit64_relaxed(unsigned int nr, > > > +volatile uint64_t *addr) rte_test_and_clear_bit64_relaxed(unsigned > > > +int nr, volatile uint64_t *addr) > > > > Sorry, I have one more naming concern with this series. > > I prefer a common namespace for bit operations. > > Would you be OK to prefix all function names with rte_bit_relaxed_? > > > Hi Thomas, > Do you mean to rename the functions as 'rte_bit_relaxed_get_bit32'? > If the example is ok, I will modify as this in v10. Yes, thank you.