From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06FFFA04E7; Tue, 3 Nov 2020 21:21:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95F1972E9; Tue, 3 Nov 2020 21:21:16 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DFD00592C for ; Tue, 3 Nov 2020 21:21:14 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 90CCF5C00AC; Tue, 3 Nov 2020 15:21:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 15:21:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= I7JnLBkhtWsnkkxjyN8Gg3f0YHBwCK3daXwff4iycio=; b=l08Vk8ryrthfxZwt YPs3a60hxeRfJs9dci4trT6Ni915c67/f5tHCuTzzVkKTmxytaYp7KLODHP8vdDD ecDneSJPMvnSIWtu0ZYJbR4uNcESrZ689AEI3G9CjJP+VhMkqSB7zXJaS25ZhHNt tdQDhIC0zm+0Wdh/wCGQimraX7wqedXMt9nMoyPrm29L6g5S5sc6ediy440m4Swn 6qzEsjk08nkQZedN2YERUJ0bJD0nkv/yzeeqE7Tg3y1kXxpjzSTB+cns+PA8WJQ8 dkOcvTXdTQ2oONEu8pb72pe9Yj0nxVTEHWbZiFJWjaOTJISCqYxIsFLeOIsLZoMC cs17ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=I7JnLBkhtWsnkkxjyN8Gg3f0YHBwCK3daXwff4iyc io=; b=cV3mhB2rpoTravkt+kLopsth0sNPyYtjNIQ/m5Ty2eO7qCyIJPiXwWgJM RdR4BbXMwVJrWYoHQqTbGB/mW2TZBO0seW4DYGxL5ncmt63rnIknZ/IvK3bOLb3e oKVTWrmQXs76aCfwNoWOmrpA/eqSTFMo+KG1nHFeoO3FWJcSeXyz5Cm8lWshWsPv Eb8tv7kEeGDmDdTcuraVk0QZJJb9p78f/lFk2NRSpVdQ5XatyR5bJQBOMYSqZ4XA YcGbGI9i2f3UMvEjc5JsawV3K5ReoFNE9U8cnSFFXZt60Vk0RBl1v5+wLEg/5zv6 4J6C1PHLCScixItZGwdIfY17N5k1A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D10B0328014F; Tue, 3 Nov 2020 15:21:13 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, kevin.laatz@intel.com Date: Tue, 03 Nov 2020 21:21:12 +0100 Message-ID: <3222890.4p7qmXYJiy@thomas> In-Reply-To: <20201103144858.1317742-1-bruce.richardson@intel.com> References: <20201103144858.1317742-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 15:48, Bruce Richardson: > Coverity flags a possible problem where the 8-bit wq_idx value may have > errors when shifted and sign-extended to 64-bits. Since this can only occur > if the shift index is larger than any expected value from hardware, it's > unlikely to cause any real problems, but we can eliminate any > possible errors, and the coverity issue, by explicitly typecasting > the uint8_t value to 64-bits before any shift operations occur. > > Coverity issue: 363695 > Fixes: a33969462135 ("raw/ioat: fix work-queue config size") > > Signed-off-by: Bruce Richardson Applied, thanks