DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning
@ 2020-04-23 10:12 Ray Kinsella
  2020-05-04 21:46 ` Thomas Monjalon
  2020-05-05  8:56 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
  0 siblings, 2 replies; 6+ messages in thread
From: Ray Kinsella @ 2020-04-23 10:12 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, Ray Kinsella, Bruce Richardson, John McNamara,
	Marko Kovacevic

Clarify the reasons behind the three part version numbering scheme.
Documents the fixes made in f26c2b3.

Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/contributing/abi_policy.rst |  3 ++-
 doc/guides/rel_notes/release_20_05.rst | 12 ++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/doc/guides/contributing/abi_policy.rst b/doc/guides/contributing/abi_policy.rst
index 05ca959..86e7dd9 100644
--- a/doc/guides/contributing/abi_policy.rst
+++ b/doc/guides/contributing/abi_policy.rst
@@ -39,7 +39,8 @@ General Guidelines
    releases, over a number of release cycles. This change begins with
    maintaining ABI stability through one year of DPDK releases starting from
    DPDK 19.11. This policy will be reviewed in 2020, with intention of
-   lengthening the stability period.
+   lengthening the stability period. Additional implementation detail can be
+   found in the :ref:`release notes <20_05_abi_changes>`.
 
 What is an ABI?
 ~~~~~~~~~~~~~~~
diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 7f2049a..8653f7a 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -164,6 +164,7 @@ API Changes
    Also, make sure to start the actual text at the margin.
    =========================================================
 
+.. _20_05_abi_changes:
 
 ABI Changes
 -----------
@@ -180,6 +181,17 @@ ABI Changes
    Also, make sure to start the actual text at the margin.
    =========================================================
 
+* The soname for each stable ABI version should be just the ABI version major
+  number without the minor number. Unfortunately both major and minor were used
+  in the v19.11 release, causing version v20.x releases to be incompatible with
+  ABI v20.0.
+
+  The `commit f26c2b3
+  <https://git.dpdk.org/dpdk/commit/?id=f26c2b39b271cdcd857ba518c5e48c78cb1c30af>`_
+  fixed the issue by switching from 2-part to 3-part ABI version numbers so that
+  we can keep v20.0 as soname and using the final digits to identify the DPDK
+  20.x releases which are ABI compatible.
+
 * No ABI change that would break compatibility with DPDK 20.02 and 19.11.
 
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning
  2020-04-23 10:12 [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning Ray Kinsella
@ 2020-05-04 21:46 ` Thomas Monjalon
  2020-05-05  8:07   ` Ray Kinsella
  2020-05-05  8:56 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2020-05-04 21:46 UTC (permalink / raw)
  To: Ray Kinsella
  Cc: dev, ferruh.yigit, Bruce Richardson, John McNamara, Marko Kovacevic

23/04/2020 12:12, Ray Kinsella:
> Clarify the reasons behind the three part version numbering scheme.
> Documents the fixes made in f26c2b3.

Please add these lines:
Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility")
Cc: stable@dpdk.org


> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> --- a/doc/guides/contributing/abi_policy.rst
> +++ b/doc/guides/contributing/abi_policy.rst
> +   lengthening the stability period. Additional implementation detail can be
> +   found in the :ref:`release notes <20_05_abi_changes>`.

The three part version was done in 20.02.
I think you should update the 20.02 release notes instead of 20.05.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning
  2020-05-04 21:46 ` Thomas Monjalon
@ 2020-05-05  8:07   ` Ray Kinsella
  2020-05-05  8:31     ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Ray Kinsella @ 2020-05-05  8:07 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, ferruh.yigit, Bruce Richardson, John McNamara, Marko Kovacevic



On 04/05/2020 22:46, Thomas Monjalon wrote:
> 23/04/2020 12:12, Ray Kinsella:
>> Clarify the reasons behind the three part version numbering scheme.
>> Documents the fixes made in f26c2b3.
> 
> Please add these lines:
> Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility")
> Cc: stable@dpdk.org
> 
> 
>> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>> --- a/doc/guides/contributing/abi_policy.rst
>> +++ b/doc/guides/contributing/abi_policy.rst
>> +   lengthening the stability period. Additional implementation detail can be
>> +   found in the :ref:`release notes <20_05_abi_changes>`.
> 
> The three part version was done in 20.02.
> I think you should update the 20.02 release notes instead of 20.05.
> 

I agreed, 
However I didn't think that was possible on a quarterly, after the release was formally complete.
Wouldn't that involve either a respin or a .1 ?

Ray K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning
  2020-05-05  8:07   ` Ray Kinsella
@ 2020-05-05  8:31     ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-05-05  8:31 UTC (permalink / raw)
  To: Ray Kinsella
  Cc: dev, ferruh.yigit, Bruce Richardson, John McNamara, Marko Kovacevic

05/05/2020 10:07, Ray Kinsella:
> On 04/05/2020 22:46, Thomas Monjalon wrote:
> > 23/04/2020 12:12, Ray Kinsella:
> >> Clarify the reasons behind the three part version numbering scheme.
> >> Documents the fixes made in f26c2b3.
> > 
> > Please add these lines:
> > Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility")
> > Cc: stable@dpdk.org
> > 
> > 
> >> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >> ---
> >> --- a/doc/guides/contributing/abi_policy.rst
> >> +++ b/doc/guides/contributing/abi_policy.rst
> >> +   lengthening the stability period. Additional implementation detail can be
> >> +   found in the :ref:`release notes <20_05_abi_changes>`.
> > 
> > The three part version was done in 20.02.
> > I think you should update the 20.02 release notes instead of 20.05.
> > 
> 
> I agreed, 
> However I didn't think that was possible on a quarterly, after the release was formally complete.
> Wouldn't that involve either a respin or a .1 ?

Yes please respin a v2




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] abi: document reasons behind the three part versioning
  2020-04-23 10:12 [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning Ray Kinsella
  2020-05-04 21:46 ` Thomas Monjalon
@ 2020-05-05  8:56 ` Ray Kinsella
  2020-05-18 16:20   ` Thomas Monjalon
  1 sibling, 1 reply; 6+ messages in thread
From: Ray Kinsella @ 2020-05-05  8:56 UTC (permalink / raw)
  To: dev
  Cc: stable, thomas, Ray Kinsella, Bruce Richardson, Neil Horman,
	John McNamara, Marko Kovacevic

Clarify the reasons behind the three part version numbering scheme.
Documents the fixes made in f26c2b3.

Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility")

Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2:
* Added "fixes" to commit message.

 doc/guides/contributing/abi_policy.rst |  3 ++-
 doc/guides/rel_notes/release_20_05.rst | 12 ++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/doc/guides/contributing/abi_policy.rst b/doc/guides/contributing/abi_policy.rst
index 05ca959..86e7dd9 100644
--- a/doc/guides/contributing/abi_policy.rst
+++ b/doc/guides/contributing/abi_policy.rst
@@ -39,7 +39,8 @@ General Guidelines
    releases, over a number of release cycles. This change begins with
    maintaining ABI stability through one year of DPDK releases starting from
    DPDK 19.11. This policy will be reviewed in 2020, with intention of
-   lengthening the stability period.
+   lengthening the stability period. Additional implementation detail can be
+   found in the :ref:`release notes <20_05_abi_changes>`.

 What is an ABI?
 ~~~~~~~~~~~~~~~
diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index ab20a7d..b2839dc 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -245,6 +245,7 @@ API Changes
   ``rte_mempool_populate_virt()`` changed to return 0 instead of -EINVAL
   when there is not enough room to store one object.

+.. _20_05_abi_changes:

 ABI Changes
 -----------
@@ -261,6 +262,17 @@ ABI Changes
    Also, make sure to start the actual text at the margin.
    =========================================================

+* The soname for each stable ABI version should be just the ABI version major
+  number without the minor number. Unfortunately both major and minor were used
+  in the v19.11 release, causing version v20.x releases to be incompatible with
+  ABI v20.0.
+
+  The `commit f26c2b3
+  <https://git.dpdk.org/dpdk/commit/?id=f26c2b39b271cdcd857ba518c5e48c78cb1c30af>`_
+  fixed the issue by switching from 2-part to 3-part ABI version numbers so that
+  we can keep v20.0 as soname and using the final digits to identify the DPDK
+  20.x releases which are ABI compatible.
+
 * No ABI change that would break compatibility with DPDK 20.02 and 19.11.


--
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] abi: document reasons behind the three part versioning
  2020-05-05  8:56 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
@ 2020-05-18 16:20   ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-05-18 16:20 UTC (permalink / raw)
  To: Ray Kinsella
  Cc: dev, stable, Bruce Richardson, Neil Horman, John McNamara,
	Marko Kovacevic

05/05/2020 10:56, Ray Kinsella:
> Clarify the reasons behind the three part version numbering scheme.
> Documents the fixes made in f26c2b3.
> 
> Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility")
> 
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2:
> * Added "fixes" to commit message.
> 
>  doc/guides/contributing/abi_policy.rst |  3 ++-
>  doc/guides/rel_notes/release_20_05.rst | 12 ++++++++++++

Moved to release_20_02.rst and applied, thanks.
Note: the updated release notes will be published as part of 20.05.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-18 16:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 10:12 [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning Ray Kinsella
2020-05-04 21:46 ` Thomas Monjalon
2020-05-05  8:07   ` Ray Kinsella
2020-05-05  8:31     ` Thomas Monjalon
2020-05-05  8:56 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
2020-05-18 16:20   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).