From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by dpdk.org (Postfix) with ESMTP id 51CD4B6A5 for ; Sat, 21 Feb 2015 12:14:01 +0100 (CET) Received: by wesq59 with SMTP id q59so9923118wes.1 for ; Sat, 21 Feb 2015 03:14:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Xf/MmVDYQO48Sn7vRsCR3YdDpoOtZxXz5aoEe3y/CGs=; b=d3yYBcCct0hd+jMR2YmPBLQRVFlRj/MSd1sz3TnpUzBWq+z5D8/B3mRxrnSb+mt8RD uy+iDOLDsPfFO61GCh1WgsYH0JcH4WuF+bE0cU6c7LHuIEDRYJlVn3nhBV9+rtBTv4QE o8l5/227p3BOeNtu1vRJbB6oNpUOCkEdorxV2dEqDfY0bUIJyDghvGYM3d+5t7/MTC9L vF/iQ3goDnW8EqXwTts4KpAUbqFy6dwURTJ04NWrj+tUQKRN1KKPI7CUjlBuZohWyu87 /y/0YPtHnBXG1O+n2IRwul+lYPMjlt8C3NCoP9ngz+vOP0Gsc5YxfzUc3XcvrYYUMD/J wOLg== X-Gm-Message-State: ALoCoQkt1CFuukzojEib8t1j10n8RK9A9zDQckxD0WT3CPTbuoP7/nelU6kTvgune+s4Z+17qqP9 X-Received: by 10.180.126.98 with SMTP id mx2mr3243326wib.18.1424517241218; Sat, 21 Feb 2015 03:14:01 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id g10sm6528383wic.7.2015.02.21.03.13.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Feb 2015 03:14:00 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Sat, 21 Feb 2015 11:48:03 +0100 Message-ID: <3223516.n06PbLjW1e@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150220181540.3b97dc86@urahara> References: <54DCB16F.7080104@redhat.com> <9190554.3JBlDK3N1R@xps13> <20150220181540.3b97dc86@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 11:14:01 -0000 2015-02-20 18:15, Stephen Hemminger: > On Fri, 20 Feb 2015 13:15:38 +0100 > Thomas Monjalon wrote: > > > 2015-02-12 17:18, Panu Matilainen: > > > Add RTE_DEVEL_BUILD make-variable which can be used to do things > > > differently when doing development vs building a release, > > > autodetected from source root .git presence and overridable via > > > commandline. Use it to only enable -Werror compiler flag when > > > building a git checkout: > > > > > > Failing build on warnings is a useful developer tool but its bad > > > for release tarballs which can and do get built with newer > > > compilers than what was used/available during development. Compilers > > > routinely add new warnings so code which built silently with cc X > > > might no longer do so with X+1. This doesn't make the existing code > > > any more buggier and failing the build in this case does not help > > > not help improve code quality of an already released version either. > > > > Please, could you update documentation to explain RTE_DEVEL_BUILD option? > > Some users could try to build from git, so we should advise to disable RTE_DEVEL_BUILD. > > These files might be updated: > > http://dpdk.org/browse/dpdk/tree/doc/build-sdk-quick.txt > > http://dpdk.org/browse/dpdk/tree/doc/guides/linux_gsg/build_dpdk.rst > > http://dpdk.org/browse/dpdk/tree/doc/guides/freebsd_gsg/build_dpdk.rst > > http://dpdk.org/browse/dpdk/tree/doc/guides/prog_guide/dev_kit_build_system.rst > > > > Thanks > > Also do not allow any patches to into upstream that cause > new warnings with latest stable version of Gcc or Clang? > I don't want a clean project to get littered with warning graffiti. > Maybe a build bot? Yes there are some daily builds with many compilers/distros. We'll have to be sure that they are done in devel mode (with -Werror). Anyway devel build is a sanity check which should be done by every developers and reviewers.