From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id BC214377E for ; Tue, 3 Jan 2017 23:13:24 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id a197so395219590wmd.0 for ; Tue, 03 Jan 2017 14:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=75909/B/J6E3wbeM6NI3vYz5lPo7mIFR8w6Gm8wmiCE=; b=WMR0x6gc9mJofYrbgzESD8oHwLThqcghOAokvj1jxiYsCxHilcVshSBjv018HL9H4y 0vKA9b5PI3jBJgYeBri+oiFLhJLF1+Z2x1CEalMq0bF2kM/E0yfOPCPHzor8YLqQjkD+ AW+S0lcGTtmHpHNENJUSc2tpFgiUSnTxFRWATXGt1FyPiigKTsMEMHcPvU/rXSiXmBA2 TpAj/dq1lbbogyAQDxQCNF8yHwpcWgPBL04nwkCMF/NaSD2JgUZ7srLRTU+vyI/R4Co1 AjDedV7j2FmEW/N7+gzLfZj4sAxx4CsNIQ6GTLJPlcPy+9Pyg35ADO+zvyjj2pIOESnq +IdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=75909/B/J6E3wbeM6NI3vYz5lPo7mIFR8w6Gm8wmiCE=; b=dM/tNBNPcvKfys0uTGd/iQ9vpWCqBINRd4SLs+h01gg6dNLxIR+C8WM55ASR4ZUaGj s3KZghEC33lWM3CbECM3/lRJ3GLVgQpprHf3CqSUnqxUFqPKEkkvTZx0oS3mkyTNqwX3 QsnL3FCgw6IfwE5MO4DGwOxrzgNibiGj4EQXTT7xVSZGOOPjW27ov0ejBhRnVdXZQtyS qnUvJbnaW/DV5lM4aqvPqHXlsJzwZy8Le0cFvArIWanzBcyEGt4Y9pALbqVXgrIK2KNG dLyyTnGi7qF6yIRlHJJ3XeBYHbKZ9WFdJxdl3zz77/0jDA2BceJqolFqQHTwwUvspnG9 uBig== X-Gm-Message-State: AIkVDXJblrD4B+glErsNo5Fd+GzZzFGbjzoO75BvvGaCvgwyjSPyLpErNpzwMVoxTNkmMXk2 X-Received: by 10.28.12.80 with SMTP id 77mr59903214wmm.106.1483481604487; Tue, 03 Jan 2017 14:13:24 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id j6sm95285762wjk.25.2017.01.03.14.13.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2017 14:13:23 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain Cc: david.marchand@6wind.com, dev@dpdk.org Date: Tue, 03 Jan 2017 23:13:23 +0100 Message-ID: <32257536.1rHviD2EUb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1482758645-23057-9-git-send-email-shreyansh.jain@nxp.com> References: <1482756644-13726-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-9-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 08/12] eal/pci: generalize args of PCI scan/match towards RTE device/driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 22:13:24 -0000 2016-12-26 18:54, Shreyansh Jain: > PCI scan and match now work on rte_device/rte_driver rather than PCI > specific objects. These functions can now be plugged to the generic > bus callbacks for scanning and matching devices/drivers. These sentences looks weird :) PCI functions must work with PCI objects, it's simpler. However I agree to register PCI scan, match, init and remove functions with the generic rte_bus. Then the rte_device object is casted into rte_pci_device inside these functions.