From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F133AA00BE; Tue, 7 Jul 2020 11:33:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A9FB1DD91; Tue, 7 Jul 2020 11:32:16 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id DB1AA1DD91 for ; Tue, 7 Jul 2020 11:32:13 +0200 (CEST) IronPort-SDR: 8j0h3z8dE1cpPwxJCTc2EjQ8l6QV0fxevF6D+B0DYXP9ShJxjB7socM/MRjcFvhxlrdK4ikVnf iEH+G8qn+3eQ== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="127156962" X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="127156962" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 02:32:12 -0700 IronPort-SDR: 9KZBRA2EBzNUrmaUCvu6E5Aboqz8aeVPoje246QB5ahEPI79UzvS8s4LxLnQTMaGHo5ENeTrgV Ky8e3vQDwWng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="322612162" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.248.101]) ([10.213.248.101]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jul 2020 02:32:09 -0700 To: Honnappa Nagarahalli , "dev@dpdk.org" , "alialnu@mellanox.com" , "orgerlitz@mellanox.com" , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" Cc: "hemant.agrawal@nxp.com" , "jerinj@marvell.com" , "viacheslavo@mellanox.com" , "thomas@monjalon.net" , Ruifeng Wang , Phil Yang , nd References: <20200617144307.9961-1-honnappa.nagarahalli@arm.com> <20200626220943.22526-1-honnappa.nagarahalli@arm.com> <20200626220943.22526-5-honnappa.nagarahalli@arm.com> <4ca0b9e5-9808-7c2f-a818-225058e875be@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <3226ef2f-54a5-511e-6b01-f07ddad88d51@intel.com> Date: Tue, 7 Jul 2020 10:32:09 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: enable empty polls in burst stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/6/2020 8:11 PM, Honnappa Nagarahalli wrote: > Hi Ferruh, > Thanks for the review comments > > > >> Subject: Re: [PATCH v2 5/5] app/testpmd: enable empty polls in burst stats >> >> On 6/26/2020 11:09 PM, Honnappa Nagarahalli wrote: >>> The number of empty polls provides information about available CPU >>> head room in the presence of continuous polling. >> >> +1 to have it, it can be useful. >> >>> >>> Signed-off-by: Honnappa Nagarahalli >>> Reviewed-by: Phil Yang >>> Reviewed-by: Ruifeng Wang >>> Tested-by: Phil Yang >>> Tested-by: Ali Alnubani >> >> <...> >> >>> /* >>> * First compute the total number of packet bursts and the >>> * two highest numbers of bursts of the same number of packets. >>> */ >>> total_burst = 0; >>> - burst_stats[0] = burst_stats[1] = burst_stats[2] = 0; >>> - pktnb_stats[0] = pktnb_stats[1] = pktnb_stats[2] = 0; >>> + memset(&burst_stats, 0x0, sizeof(burst_stats)); >>> + memset(&pktnb_stats, 0x0, sizeof(pktnb_stats)); >>> + >>> for (nb_pkt = 0; nb_pkt < MAX_PKT_BURST; nb_pkt++) { >>> nb_burst = pbs->pkt_burst_spread[nb_pkt]; >>> - if (nb_burst == 0) >>> - continue; >>> total_burst += nb_burst; >>> - if (nb_burst > burst_stats[0]) { >>> - burst_stats[1] = burst_stats[0]; >>> - pktnb_stats[1] = pktnb_stats[0]; >>> + >>> + /* Show empty poll stats always */ >>> + if (nb_pkt == 0) { >>> burst_stats[0] = nb_burst; >>> pktnb_stats[0] = nb_pkt; >> >> just a minor issue but this assignment is not needed. > The empty poll stats are being shown always (even if there were no empty polls). The check 'nb_pkts == 0' indicates that the burst stats are for empty polls. Hence this assignment is required. But, this can be moved out of the loop to provide clarity. I will do that. It is not required because of 'memset' above, we know 'nb_pkt == 0' and we know 'pktnb_stats[0] == 0', so "pktnb_stats[0] = nb_pkt;" is redundant. > >> >>> - } else if (nb_burst > burst_stats[1]) { >>> + continue; >>> + } >>> + >>> + if (nb_burst == 0) >>> + continue; >> >> again another minor issue, can have this check above 'nb_pkt == 0', to prevent >> unnecssary "burst_stats[0] = nb_burst;" assignment if "nb_burst == 0". > The empty polls are always shown, even if there were 0% empty polls. I got that, again because of memset, "burst_stats[0] == 0", you can skip "burst_stats[0] = nb_burst;" in case "nb_burst == 0", that is why you can move it up. Anyway, both are trivial issues ... > >> >> <...> >> >> Reviewed-by: Ferruh Yigit